Re: [Qemu-devel] [PATCH v4 05/28] qapi: Add new visit_free() function

From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 05/28] qapi: Add new visit_free() function
Date: Fri, 03 Jun 2016 13:46:36 +0200	[thread overview]
Message-ID: <87zir2xzoj.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87oa7kq4l7.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Wed, 01 Jun 2016 18:03:16 +0200")

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
[...]
>> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
>> index 9391dea..235e8a1 100644
>> --- a/qapi/qapi-dealloc-visitor.c
>> +++ b/qapi/qapi-dealloc-visitor.c
>> @@ -107,17 +107,12 @@ static void qapi_dealloc_type_null(Visitor *v, const char *name, Error **errp)
>>  {
>>  }
>>
>> -Visitor *qapi_dealloc_get_visitor(QapiDeallocVisitor *v)
>> -{
>> -    return &v->visitor;
>> -}
>> -
>> -void qapi_dealloc_visitor_cleanup(QapiDeallocVisitor *v)
>> +static void qapi_dealloc_free(Visitor *v)
>>  {
>>      g_free(v);
>
> Uh, shouldn't this be g_free(v, QapiDeallocVisitor, visitor)?  That way,
> we don't assume that visitor is QapiDeallocVisitor's first member.

I mean g_free(container_of(v, QapiDeallocVisitor, visitor), of course.

>
>>  }
>>
>> -QapiDeallocVisitor *qapi_dealloc_visitor_new(void)
>> +Visitor *qapi_dealloc_visitor_new(void)
>>  {
>>      QapiDeallocVisitor *v;
>>
[...]