From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1atCA0-0003hQ-UE
	for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:48:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1atC9v-0006bZ-V7
	for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:48:36 -0400
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:38480)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1atC9v-0006bV-PA
	for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:48:31 -0400
Received: by mail-wm0-x22b.google.com with SMTP id u206so125593227wme.1
	for <qemu-devel@nongnu.org>; Thu, 21 Apr 2016 03:48:31 -0700 (PDT)
References: <1460147350-7601-1-git-send-email-pbonzini@redhat.com>
	<1460147350-7601-45-git-send-email-pbonzini@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1460147350-7601-45-git-send-email-pbonzini@redhat.com>
Date: Thu, 21 Apr 2016 11:48:29 +0100
Message-ID: <87zisnteyq.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 44/50] arm: move arm_log_exception into .c
 file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org


Paolo Bonzini <pbonzini@redhat.com> writes:

> Avoid need for qemu/log.h inclusion, and make the function static too.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  target-arm/helper.c    | 15 +++++++++++++++
>  target-arm/internals.h | 15 ---------------
>  2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 09638b2..41abdff 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5815,6 +5815,21 @@ static void do_v7m_exception_exit(CPUARMState *env)
>         pointer.  */
>  }
>
> +static void arm_log_exception(int idx)
> +{
> +    if (qemu_loglevel_mask(CPU_LOG_INT)) {
> +        const char *exc = NULL;
> +
> +        if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> +            exc = excnames[idx];
> +        }
> +        if (!exc) {
> +            exc = "unknown";
> +        }
> +        qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
> +    }
> +}
> +
>  void arm_v7m_cpu_do_interrupt(CPUState *cs)
>  {
>      ARMCPU *cpu = ARM_CPU(cs);
> diff --git a/target-arm/internals.h b/target-arm/internals.h
> index 2e70272..c484700 100644
> --- a/target-arm/internals.h
> +++ b/target-arm/internals.h
> @@ -72,21 +72,6 @@ static const char * const excnames[] = {
>      [EXCP_SEMIHOST] = "Semihosting call",
>  };
>
> -static inline void arm_log_exception(int idx)
> -{
> -    if (qemu_loglevel_mask(CPU_LOG_INT)) {
> -        const char *exc = NULL;
> -
> -        if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> -            exc = excnames[idx];
> -        }
> -        if (!exc) {
> -            exc = "unknown";
> -        }
> -        qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
> -    }
> -}
> -
>  /* Scale factor for generic timers, ie number of ns per tick.
>   * This gives a 62.5MHz timer.
>   */


--
Alex Bennée