From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZtyM2-0006fq-DR
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 08:43:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZtyLz-0000xZ-Mx
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 08:43:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55641)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZtyLz-0000xV-Hb
	for qemu-devel@nongnu.org; Wed, 04 Nov 2015 08:43:55 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1446618049-13596-1-git-send-email-eblake@redhat.com>
	<1446618049-13596-18-git-send-email-eblake@redhat.com>
Date: Wed, 04 Nov 2015 14:43:52 +0100
In-Reply-To: <1446618049-13596-18-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Tue, 3 Nov 2015 23:20:39 -0700")
Message-ID: <87ziytnalj.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous
	commit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> From: Markus Armbruster <armbru@redhat.com>
>
> QAPISchemaObjectTypeVariants.check() parameter members is no
> longer used, drop it.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <1446559499-26984-3-git-send-email-armbru@redhat.com>
> [Variant.check(seen) is used after all, so reword and reduce scope
> of this patch; rearrange later in the series]

Don't you need to update the subject?  My "previous commit" was "qapi:
Simplify QAPISchemaObjectTypeMember.check()", while yours is "qapi:
Eliminate QAPISchemaObjectType.check() variable members".

Not sure what moving my two patches apart buys you :)

> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> ---
> v9: new patch
> ---
>  scripts/qapi.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 4019389..3af5edb 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -991,7 +991,7 @@ class QAPISchemaObjectType(QAPISchemaType):
>              assert m.name not in seen
>              seen[m.name] = m
>          if self.variants:
> -            self.variants.check(schema, [], seen)
> +            self.variants.check(schema, seen)
>          self.members = seen.values()
>
>      def is_implicit(self):
> @@ -1046,7 +1046,7 @@ class QAPISchemaObjectTypeVariants(object):
>          self.tag_member = tag_member
>          self.variants = variants
>
> -    def check(self, schema, members, seen):
> +    def check(self, schema, seen):
>          # seen is non-empty for unions, empty for alternates
>          if self.tag_name:    # flat union
>              self.tag_member = seen[self.tag_name]
> @@ -1086,7 +1086,7 @@ class QAPISchemaAlternateType(QAPISchemaType):
>
>      def check(self, schema):
>          self.variants.tag_member.check(schema)
> -        self.variants.check(schema, [], {})
> +        self.variants.check(schema, {})
>
>      def json_type(self):
>          return 'value'