From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Daniel Vetter" <daniel@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bdw: Cleanup pre prod workarounds
Date: Tue, 23 Sep 2014 14:48:47 +0300 [thread overview]
Message-ID: <87zjdq5zhc.fsf@intel.com> (raw)
In-Reply-To: <20140923082002.GU15734@phenom.ffwll.local>
On Tue, 23 Sep 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Sep 19, 2014 at 08:49:06PM +0300, Ville Syrjälä wrote:
>> On Fri, Sep 19, 2014 at 08:05:26PM +0300, Mika Kuoppala wrote:
>> > as these have been fixed in production hw and hurt performance
>> > if applied.
>> >
>> > v2: adjust requested ring space (Ville)
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83482
>> > Tested-by: zhoujian <jianx.zhou@intel.com>
>> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>>
>> Documentation agrees that these can go.
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Cc: stable@vger.kernel.org imo. Jani?
This depends on
commit 86d7f23842f1bce3ab5e8c8d0c676112bbc4c99b
Author: Arun Siluvery <arun.siluvery@linux.intel.com>
Date: Tue Aug 26 14:44:50 2014 +0100
drm/i915/bdw: Apply workarounds in render ring init function
which brought the problem to daylight to begin with. That's not in
3.17-rc6. I'm not sure if that one has additional dependencies, but
perhaps a combined backport without an intermediate broken step is
plausible.
In any case I don't think this is something we want to rush for 3.17
now, since a release is imminent, so it'll be 3.18. Adding cc: stable is
up to you, but do note the size is beyond stable rules.
BR,
Jani.
> -Daniel
>
>>
>> > ---
>> > drivers/gpu/drm/i915/intel_ringbuffer.c | 15 ++-------------
>> > 1 file changed, 2 insertions(+), 13 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> > index 681ea86..679a3c7 100644
>> > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> > @@ -707,7 +707,7 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
>> > * update the number of dwords required based on the
>> > * actual number of workarounds applied
>> > */
>> > - ret = intel_ring_begin(ring, 24);
>> > + ret = intel_ring_begin(ring, 18);
>> > if (ret)
>> > return ret;
>> >
>> > @@ -722,19 +722,8 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
>> > intel_ring_emit_wa(ring, GEN7_ROW_CHICKEN2,
>> > _MASKED_BIT_ENABLE(DOP_CLOCK_GATING_DISABLE));
>> >
>> > - /*
>> > - * This GEN8_CENTROID_PIXEL_OPT_DIS W/A is only needed for
>> > - * pre-production hardware
>> > - */
>> > intel_ring_emit_wa(ring, HALF_SLICE_CHICKEN3,
>> > - _MASKED_BIT_ENABLE(GEN8_CENTROID_PIXEL_OPT_DIS
>> > - | GEN8_SAMPLER_POWER_BYPASS_DIS));
>> > -
>> > - intel_ring_emit_wa(ring, GEN7_HALF_SLICE_CHICKEN1,
>> > - _MASKED_BIT_ENABLE(GEN7_SINGLE_SUBSCAN_DISPATCH_ENABLE));
>> > -
>> > - intel_ring_emit_wa(ring, COMMON_SLICE_CHICKEN2,
>> > - _MASKED_BIT_ENABLE(GEN8_CSC2_SBE_VUE_CACHE_CONSERVATIVE));
>> > + _MASKED_BIT_ENABLE(GEN8_SAMPLER_POWER_BYPASS_DIS));
>> >
>> > /* Use Force Non-Coherent whenever executing a 3D context. This is a
>> > * workaround for for a possible hang in the unlikely event a TLB
>> > --
>> > 1.9.1
>>
>> --
>> Ville Syrjälä
>> Intel OTC
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-09-23 11:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:05 [PATCH] drm/i915/bdw: Cleanup pre prod workarounds Mika Kuoppala
2014-09-19 13:55 ` Ville Syrjälä
2014-09-19 17:05 ` Mika Kuoppala
2014-09-19 17:49 ` Ville Syrjälä
2014-09-23 8:20 ` Daniel Vetter
2014-09-23 11:48 ` Jani Nikula [this message]
2014-09-24 8:41 ` Daniel Vetter
2014-09-24 17:46 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjdq5zhc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.