From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] vlc: explicitly disable opencv support
Date: Sun, 16 Feb 2014 09:17:10 +0100 [thread overview]
Message-ID: <87zjlrii9l.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1392502403-19701-2-git-send-email-s.martin49@gmail.com> (Samuel Martin's message of "Sat, 15 Feb 2014 23:13:22 +0100")
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:
> vlc can use opencv in video filters, but it requires a couple of
> features enabled in opencv; so, simply force disabling opencv support.
> Note that vlc does includes the legacy opencv/cv.h header, which pulls a
> number of opencv's features (core, video, imgproc, ...).
Is this meant as a short term fix for 2014.02? Presumably the user CAN
enable the needed opencv option so it could work? - E.G. we could come
up with the needed test like:
ifeq ($(BR2_PACKAGE_OPENCV_FOO)$(BR2_PACKAGE_OPENCV_BLAH)...,yyy)
VLC_CONF_OPT += --with-opencv
VLC_DEPENDENCIES += opencv
else
VLC_CONF_OPT += --without-opencv
endif
> Fixes:
> http://autobuild.buildroot.org/results/39c/39c77ffb5a5599d0b09422433c747b2bac185c4f/
> http://autobuild.buildroot.org/results/a79/a79b055da09e4d8ede263251df8461bc8a64569a/
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/vlc/vlc.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
> index f235ff8..db99a3b 100644
> --- a/package/vlc/vlc.mk
> +++ b/package/vlc/vlc.mk
> @@ -30,7 +30,8 @@ VLC_CONF_OPT += \
> --disable-goom \
> --disable-projectm \
> --disable-vsxu \
> - --disable-mtp
> + --disable-mtp \
> + --without-opencv
> # Set powerpc altivec appropriately
> ifeq ($(BR2_powerpc_7400)$(BR2_powerpc_7450)$(BR2_powerpc_970),y)
> --
> 1.8.5.4
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-02-16 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 22:13 [Buildroot] [PATCH 0/2] vlc autobuild fixes and opencv modules mess? Samuel Martin
2014-02-15 22:13 ` [Buildroot] [PATCH 1/2] vlc: explicitly disable opencv support Samuel Martin
2014-02-16 8:17 ` Peter Korsgaard [this message]
2014-02-16 9:14 ` Samuel Martin
2014-02-17 8:02 ` Peter Korsgaard
2014-02-15 22:13 ` [Buildroot] [PATCH 2/2] opencv: always enable opencv_core module when opencv is enabled Samuel Martin
2014-02-16 8:18 ` Peter Korsgaard
2014-02-16 8:14 ` [Buildroot] [PATCH 0/2] vlc autobuild fixes and opencv modules mess? Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjlrii9l.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.