From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIj7H-0001G2-Pd
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:17:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIj7G-0000c5-Jb
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:17:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31823)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIj7G-0000c1-Ba
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:17:26 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1363881940-27505-6-git-send-email-owasserm@redhat.com> (Orit
	Wasserman's message of "Thu, 21 Mar 2013 18:05:36 +0200")
References: <1363881940-27505-1-git-send-email-owasserm@redhat.com>
	<1363881940-27505-6-git-send-email-owasserm@redhat.com>
Date: Thu, 21 Mar 2013 18:17:31 +0100
Message-ID: <87zjxwpt90.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 5/9] Use writev ops if available
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: pbonzini@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, mst@redhat.com

Orit Wasserman <owasserm@redhat.com> wrote:
> Update qemu_fflush and stdio_close to use writev ops if they are available
> Use the buffers stored in the iovec.
>
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I think that qemu_fflush() should only be called for QEMUFiles opened in
write mode, but that is independent of this series.