From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miklos Szeredi Subject: Re: overlayfs patches for ovl_copy_up & ovl_rename Date: Wed, 18 May 2011 10:42:53 +0200 Message-ID: <87zkmkmmb6.fsf@tucsk.pomaz.szeredi.hu> References: <201105041659.38427.jordipujolp@gmail.com> <201105171918.03433.jordipujolp@gmail.com> <87vcx9cib2.fsf@tucsk.pomaz.szeredi.hu> <201105180944.35027.jordipujolp@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org To: Jordi Pujol Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:45368 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756059Ab1ERImt (ORCPT ); Wed, 18 May 2011 04:42:49 -0400 Received: by bwz15 with SMTP id 15so1213410bwz.19 for ; Wed, 18 May 2011 01:42:47 -0700 (PDT) In-Reply-To: <201105180944.35027.jordipujolp@gmail.com> (Jordi Pujol's message of "Wed, 18 May 2011 09:44:34 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jordi Pujol writes: > A Dimarts 17 Maig 2011 20:07:13, v=C3=A0reu escriure: >> Jordi, what about the original bug you reported: >> >>>- a few days ago we talked about an error when repetitive sed >> >>>instructions were executed, also it happens in other processes, >> >>>like mantaining list of installed files for actual packages, that >> >>>is solved in ovl_rename issuing a dget for the old-dentry and >> >>>parent dentries. (This code is inspired on rename.c from unionfs) >>=20 >> Is this still happening? Does the debug patch make any difference? > > my patch adds some dget/dput operations that minimize the problem, it > occurs less times, but it happens. I suppose that those extra > operations add an execution delay before processing the main routine; Probably timing related, yes. > a deduction is that locking dentries is required to synchronize a ren= ame to=20 > not be executed until another rename operation has finished. Already done by the VFS. The locks used actually provide stronger guarantees than your code. See Documentation/filesystems/directory-locking for all the gory details. So, is there a minimal test case that I can try to replicate the bad behavior? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html