From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 38/38] net/dpaa: add packet dump for debugging
Date: Wed, 28 Jun 2017 16:51:31 +0100
Message-ID: <880c1d09-bb6f-bca4-13c7-cde1ccd28ac7@intel.com>
References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com>
 <1497591668-3320-39-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C5DE02904
 for <dev@dpdk.org>; Wed, 28 Jun 2017 17:51:33 +0200 (CEST)
In-Reply-To: <1497591668-3320-39-git-send-email-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/16/2017 6:41 AM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Is there a driver documentation, I haven't see any in net/dpaa patches?

<...>
> +CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER_DISPLAY=n
> +CONFIG_RTE_LIBRTE_DPAA_CHECKING=n

This config option is not used at all, can be removed.

<...>
> +#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
> +		DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err);

Out of curiosity, what exactly done here. Is this a special queue, what
is does? It can be useful if documented more in commit log.

> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_RX_ERROR].dpaa_intf = dpaa_intf;
> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
> +		DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err);
> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_TX_ERROR].dpaa_intf = dpaa_intf;
> +#endif
> +
<...>