From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, eranian@google.com, ak@linux.intel.com,
kirill.shutemov@linux.intel.com, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org
Subject: Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE
Date: Thu, 17 Sep 2020 18:16:15 -0400 [thread overview]
Message-ID: <88177517-da0c-43d9-4f5c-fb610e66b9e0@linux.intel.com> (raw)
In-Reply-To: <39dd016a-b0ee-c9da-dc21-1b7175e8b5ef@intel.com>
On 9/17/2020 6:02 PM, Dave Hansen wrote:
>> The problem is that the warning from the perf tool usually includes some
>> hints regarding the cause of the warning or possible solution to
>> workaround/fix the warning. What message should we deliver to the users?
>> "Warning: Too many error page size. Address space isolation feature may
>> be enabled, please check"?
> That's not particularly actionable for an end user. Do any of the perf
> errors just tell them to submit a bug report? "Excessive number of page
> size lookup errors, please report to..."
Yes, found some perf tool warnings end with "Consider reporting to
linux-kernel@vger.kernel.org."
I will add a warning "Excessive number of page size lookup errors,
please report to linux-kernel@vger.kernel.org.", if 90% of the samples
have the page size 0.
Thanks,
Kan
next prev parent reply other threads:[~2020-09-17 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 13:52 [PATCH V7 0/4] Add the page size in the perf record (kernel) kan.liang
2020-09-17 13:52 ` [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2020-09-17 19:00 ` Dave Hansen
2020-09-17 21:16 ` Liang, Kan
[not found] ` <04f59f3b-2e53-8774-8333-63dfc5b8e6a9@intel.com>
2020-09-17 21:58 ` Liang, Kan
2020-09-17 22:02 ` Dave Hansen
2020-09-17 22:16 ` Liang, Kan [this message]
2020-09-17 13:52 ` [PATCH V7 2/4] perf/x86/intel: Support PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2020-09-17 13:52 ` [PATCH V7 3/4] powerpc/perf: " kan.liang
2020-09-17 13:52 ` [PATCH V7 4/4] perf/core: Add support for PERF_SAMPLE_CODE_PAGE_SIZE kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88177517-da0c-43d9-4f5c-fb610e66b9e0@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.