Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

From: zhoucm1 <zhoucm1-5C7GfCeVMHo@public.gmane.org>
To: "Sharma, Deepak" <Deepak.Sharma-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Zhou,
	David(ChunMing)" <David1.Zhou-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference
Date: Thu, 22 Nov 2018 15:00:40 +0800	[thread overview]
Message-ID: <881e2f9e-6c00-f3ad-a6aa-345accb6f4a5@amd.com> (raw)
In-Reply-To: <20181122065523.5510-1-Deepak.Sharma-5C7GfCeVMHo@public.gmane.org>


On 2018年11月22日 14:56, Sharma, Deepak wrote:
> when returned fence is not valid mostly due to userspace ignored
> previous error causes NULL pointer dereference.
>
> Signed-off-by: Deepak Sharma <Deepak.Sharma@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 024dfbd87f11..14166cd8a12f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -1403,6 +1403,8 @@ static struct dma_fence *amdgpu_cs_get_fence(struct amdgpu_device *adev,
>   
>   	fence = amdgpu_ctx_get_fence(ctx, entity, user->seq_no);
>   	amdgpu_ctx_put(ctx);
> +	if(!fence)
> +		return ERR_PTR(-EINVAL);
>   
>   	return fence;
>   }

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx