From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D1FC7618E for ; Mon, 20 Mar 2023 11:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbjCTLEU (ORCPT ); Mon, 20 Mar 2023 07:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbjCTLDp (ORCPT ); Mon, 20 Mar 2023 07:03:45 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF14EB54 for ; Mon, 20 Mar 2023 03:59:32 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id h9so11653466ljq.2 for ; Mon, 20 Mar 2023 03:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679309969; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VMafAQR5nWMLiGtaukSZZZu7jK92DhZD+Rx8RPl4ke8=; b=lH+dmLdqTcjbATsWhV1W/NLv7e0v/ocqBTO9RaXFMKxnufdFHRQbMAMIC3oMoU5AsE 6a2WWQIdV5nw2iyUh91/thm6Rez9Lut33AMgr4fzgMdp3DQf5l8fZQLOe7i7A+QcEyyQ ve6eU7fmYYQrzxR0i+X2+KGZmOK0bCMFwfEW61okIP6bTPyGRr3Y1YTnElCbHDowUhQw dYGpfwDx8bMKCQt/n7d6HR71sjPnWa2qAyjdrSbuLD1o8eGu4zGiq7gQsJZ0u4f6NylN WbeAOW92iwc/EIoNsVmDJKSX2NxYj1a/PxB7YVJjrD1xckuR+RHSsqsPzcJ1osmjSlqz rgtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679309969; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VMafAQR5nWMLiGtaukSZZZu7jK92DhZD+Rx8RPl4ke8=; b=Oau8BMe4B9voC1Byf+fg0W2jKuCOH9sh0/XltfrIiJhrhFfbvEoK2JvpKngiYd72hQ vHvo+1FKbCkU4e5GyLUUpTJwJyEJ9IZoFwwGeuX0m6A8V8L43HgX4IM71c9WlNeP4SDn LoUptAiqwivQa2ht77KSyXgT2ZLZidfw+4Na5Nl5pKi9IVnEG2JsFYeVpIXWjjXLkGUa BM/Bpt0XkMVc7hrp/VjjLF5GFX8cKHNZ21tzqU680xyAh1Y4S7yW2cTyAkahJ3LTHcVO WtCTcBR4uNTuvtRmTq/0Vlt/Zk9QhzAgNOEssmNMq//ctERR+ehSh6vOqYtqqARyQ1b9 dNbw== X-Gm-Message-State: AO0yUKU+SRMI6EDFNBSghb6hQCNlu4EyYMwu9nM96gnsJ9nqoA5GbFbc kH/vW0a6v1sgjCkvq/KTk6vg3w== X-Google-Smtp-Source: AK7set8ezrhHT6qL4Nfd0LuRVUpty1T62Wuj7JG8jLAAP0sf3mwvSNWExC3WXUge1EA9qtDFQ1ujRg== X-Received: by 2002:a05:651c:50a:b0:298:aa75:e7a1 with SMTP id o10-20020a05651c050a00b00298aa75e7a1mr7710114ljp.26.1679309968796; Mon, 20 Mar 2023 03:59:28 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id n12-20020a2e904c000000b00299f0194108sm1689434ljg.31.2023.03.20.03.59.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:59:28 -0700 (PDT) Message-ID: <88208739-9838-4cfe-79de-c2558f604510@linaro.org> Date: Mon, 20 Mar 2023 11:59:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: add wifi calibration variant Content-Language: en-US To: Johan Hovold Cc: Johan Hovold , Kalle Valo , Bjorn Andersson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230320104658.22186-1-johan+linaro@kernel.org> <20230320104658.22186-4-johan+linaro@kernel.org> <244a59c6-2dc0-83c7-07d2-6bae04022605@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 20.03.2023 11:55, Johan Hovold wrote: > On Mon, Mar 20, 2023 at 11:50:30AM +0100, Konrad Dybcio wrote: >> >> >> On 20.03.2023 11:46, Johan Hovold wrote: >>> Describe the bus topology for PCIe domain 6 and add the ath11k >>> calibration variant so that the board file (calibration data) can be >>> loaded. >>> >>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216036 >>> Signed-off-by: Johan Hovold >>> --- >>> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts >>> index 90a5df9c7a24..5dfda12f669b 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts >> >> >> Was mixing >>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts >> >> this /\ >> >> [...] >> >> and this \/ >>> + qcom,ath11k-calibration-variant = "LE_X13S"; >> Intentional? Especially given Kalle's comment on bugzilla? > > Yes, it is intentional. The corresponding calibration data allows the > wifi to be used on the CRD. I measure 150 MBits/s which may a bit lower > than expected, but it's better than having no wifi at all. OK, sounds great! Reviewed-by: Konrad Dybcio Konrad > > Johan