From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sander Eikelenboom Subject: Re: BUG_ON() vs ASSERT() Date: Wed, 14 Sep 2016 11:26:32 +0200 Message-ID: <883585764.20160914112632@eikelenboom.it> References: <57D6E49D020000780010E24F@prv-mh.provo.novell.com> <3d4d7b6e-f5ac-2d13-8c02-508f2b88dfa9@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bk6Si-0008Pm-8X for xen-devel@lists.xenproject.org; Wed, 14 Sep 2016 09:26:36 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Andrew Cooper , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org CldlZG5lc2RheSwgU2VwdGVtYmVyIDE0LCAyMDE2LCAxMDozNTozMCBBTSwgeW91IHdyb3RlOgoK PiBPbiBUdWUsIFNlcCAxMywgMjAxNiBhdCA3OjE2IFBNLCBBbmRyZXcgQ29vcGVyCj4gPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOgo+PiBPbiAxMi8wOS8xNiAxNjoyMywgSmFuIEJl dWxpY2ggd3JvdGU6Cj4+PiBBbGwsCj4+Pgo+Pj4gaW4KPj4+IGh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAxNi0wOS9tc2cwMTIwMS5odG1sCj4+ PiBhbmQKPj4+IGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4t ZGV2ZWwvMjAxNi0wOS9tc2cwMTIxMC5odG1sCj4+PiBBbmRyZXcgYmFzaWNhbGx5IHN1Z2dlc3Rz IHRoYXQgd2Ugc2hvdWxkIHN3aXRjaCBhd2F5IGZyb20gdXNpbmcKPj4+IEFTU0VSVCgpIGFuZCBv dmVyIHRvIEJVR19PTigpIGluIHBlcmhhcHMgcXVpdGUgYnJvYWQgYSBzZXQgb2YKPj4+IGNhc2Vz LiBBbmQgaG9uZXN0bHkgSSdtIG5vdCBjb252aW5jZWQgb2YgdGhpczogV2UndmUgYmVlbiBhZGRp bmcKPj4+IHF1aXRlIGEgZmV3IEFTU0VSVCgpcyBvdmVyIHRoZSBsYXN0IHllYXJzIHdpdGggdGhl IGFpbSBvZiBkb2luZwo+Pj4gc2FuaXR5IGNoZWNraW5nIGluIGRlYnVnIGJ1aWxkcywgd2l0aG91 dCBhZGRpbmcgb3ZlcmhlYWQgdG8gbm9uLQo+Pj4gZGVidWcgYnVpbGRzLiBJIGNhbiBjZXJ0YWlu bHkgc2VlIHBvc3NpYmxlIGNhc2VzIHdoZXJlIHVzaW5nCj4+PiBCVUdfT04oKSB0byBwcmV2ZW50 IGZ1cnRoZXIgcG9zc2libGUgZGFtYWdlIGlzIGFwcHJvcHJpYXRlLCBidXQKPj4+IEkgZG9uJ3Qg dGhpbmsgd2Ugc2hvdWxkIG92ZXJkbyBoZXJlLgo+Pgo+PiBJIGFtIG5vdCBhZHZvY2F0aW5nIHN3 aXRjaGluZyBhbGwgQVNTRVJUKClzIHRvIEJVR19PTigpcy4gIFRoYXQgd291bGQgYmUKPj4gc2ls bHkuCj4+Cj4+IEhvd2V2ZXIsIEFTU0VSVCgpJ3MgYXMgYSBib3VuZHMgY2hlY2sgdmVyeSBkZWZp bml0ZWx5IGFyZSBkYW5nZXJvdXMuICBJZgo+PiB0aGVyZSBpcyBhbnkgdW5jZXJ0YWludHkgYWJv dXQgdGhlIGJvdW5kcywgdGhlIGNoZWNrIG11c3Qgbm90IGRpc2FwcGVhcgo+PiBpbiBhIHJlbGVh c2UgYnVpbGQuICAoQmV0dGVyIHlldCwgY29kZSB3aGljaCBjb3BlcyBjbGVhbmx5IHdpdGgKPj4g aW5zdWZmaWNpZW50IGJvdW5kcykuCj4+Cj4+Cj4+IEZvciBhbnlvbmUgcmVhZGluZyB0aGlzIGVt YWlsIHdobyBoYXNuJ3QgYWxyZWFkeSB3b3JrZWQgb3V0IHRoZSBkZXRhaWxzCj4+IG9mIFhTQS0x ODYsIHRoZSBkYXRhIGNvcnJ1cHRpb24gaXNzdWUgaXMgaGVyZToKPj4KPj4gc3RhdGljIGludCBo dm1lbXVsX2luc25fZmV0Y2goLi4uKQo+PiB7Cj4+ICAgICB1bnNpZ25lZCBpbnQgaW5zbl9vZmYg PSBvZmZzZXQgLSBodm1lbXVsX2N0eHQtPmluc25fYnVmX2VpcDsKPj4gICAgIC4uLgo+PiAgICAg QVNTRVJUKGluc25fb2ZmICsgYnl0ZXMgPD0gc2l6ZW9mKGh2bWVtdWxfY3R4dC0+aW5zbl9idWYp KTsKPj4gICAgIG1lbWNweSgmaHZtZW11bF9jdHh0LT5pbnNuX2J1ZltpbnNuX29mZl0sIHBfZGF0 YSwgYnl0ZXMpOwo+PiAgICAgLi4uCj4+Cj4+IEl0IGlzIGxlZnQgYXMgYW4gZXhlcmNpc2UgdG8g dGhlIHJlYWRlciB0byB3b3JrIG91dCBob3cgdG8gZXhwbG9pdCB0aGlzCj4+IG9uIGEgcmVsZWFz ZSBidWlsZCBvZiBYZW4sIGJ1dCBpdCBpcyBob3BlZnVsbHkgb2J2aW91cyB0aGF0IHRoZSBBU1NF UlQoKQo+PiBpc24ndCBoZWxwZnVsLiAgQSBCVUdfT04oKSBpbiB0aGlzIGNhc2Ugd291bGQgaGF2 ZSBiZWVuIGEgaG9zdCBEb1MsCj4+IHdoaWNoIGlzIHN1YnN0YW50aWFsbHkgYmV0dGVyIHRoYW4g YSBndWVzdCBlc2NhcGUuCgo+IFRoaXMgc2VlbXMgcXVpdGUgc2Vuc2libGUsIGFuZCBJJ20gZ2xh ZCBBbmR5IGNsYXJpZmllZC4gIChBbHRob3VnaCBpbgo+IGEgbG90IG9mIHRoZXNlIGNhc2VzLCBh IGRvbWFpbl9jcmFzaCgpIHdvdWxkIGJlIHByZWZlcmFibGUgdG8gYQo+IEJVR19PTigpICBpZiBw b3NzaWJsZS4pCgo+ICAtR2VvcmdlCgpKdXN0IG15IHR3byBjZW50cywgYnV0IHBsZWFzZSB0cnkg dG8gbGltaXQgQlVHX09OKCkncyB0byBvbmx5IHJlYWxseSAKdW5yZWNvdmVyYWJsZSBjYXNlcy4g QmVjYXVzZSBpdCBpcyBxdWl0ZSBhIGRpc2FzdGVyIGVzcGVjaWFsbHkgb24KcmVtb3RlIGFkbWlu aXN0cmF0ZWQgbWFjaGluZXMgdG8gaGF2ZSB0aGUgaG9zdCBjcmFzaCBvbiBhIEJVR19PTigpIAoo d2l0aCBvciB3aXRob3V0IGF1dG8gcmVzdGFydCkuCiAKVHJ5IHRvIHJlY292ZXIgKGZvciBpbnN0 YW5jZSBpZiBuZWNlc3NhcnkgYnkgY3Jhc2hpbmcgdGhlIGd1ZXN0IAppbnN0ZWFkIG9mIHRoZSBo b3N0KSBhcyBtdWNoIGFzIHlvdSBjYW4gdG8gbWFrZSBhdCBsZWFzdCB0aGUgaHlwZXJ2aXNvciBh bmQgZG9tMCAKc3Vydml2ZS4gUHV0IGEgYmlnIGZhdCB3YXJuaW5nIGluIHhsIGRtZXNnIGFuZCB0 YWludCB0aGUgaHlwZXJ2aXNvciAKKHByZWZlcmFibHkgaW4gYSB3YXkgeW91IGNvdWxkIGVhc2ls eSByZWFkIG91dCB3aXRoIG1vbml0b3JpbmcgdG9vbHMpLApzbyB5b3UgY291bGQgcHJvcGFnYXRl IHRoYXQgdG8gdGhlIHN5c2FkbWluIHRoYXQgdGhlIHN5c3RlbSBpcwpub3cgZGVlbWVkIGluc3Rh YmxlLCBzbyBoZSBjYW4gaW52ZXN0aWdhdGUgKGFuZCByZXBvcnQgdGhlIGJ1ZyksCnRyaWFnZSBh bmQgc2NoZWR1bGUgYSByZWJvb3QuIEluc3RlYWQgb2Ygb25seSBoYXZpbmcgYSBoYXJkIHRvIGRl YnVnIGNyYXNoaW5nIAptYWNoaW5lIHdpdGggcHJvYmFibHkgbm8gb3IgbGltaXRlZCBsb2dzIHRv IGdvIGJ5LiAKCkluIHRoZSBMaW51eCBrZXJuZWwgdGhlIHByb2JsZW0gbm93IGlzIHRvIGdldCBh IGxvdCBvZiB0aGVtIGNvbnZlcnRlZCBiYWNrIHRvCnJhdGVsaW1pdGVkIHdhcm5pbmdzIGluc3Rl YWQgb2YgQlVHX09OKCkncy4KCi0tClNhbmRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=