From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
alistair.francis@xilinx.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive
Date: Tue, 15 Aug 2017 09:32:29 -0700 [thread overview]
Message-ID: <8846d546-5dc3-4d71-ff57-f1978ae91528@linaro.org> (raw)
In-Reply-To: <c30ad9c1-bd1c-0fdf-085e-2449d9034dd6@amsat.org>
On 08/15/2017 08:56 AM, Philippe Mathieu-Daudé wrote:
>> @@ -1885,7 +1886,7 @@ static void gen_load_exclusive(DisasContext *s, int rt,
>> int rt2,
>> tcg_gen_mov_i64(cpu_reg(s, rt2), cpu_exclusive_high);
>> }
>> } else {
>> - memop |= size;
>> + memop |= size | MO_ALIGN;
>
> MO_ALIGN_8 here too?
>
>> tcg_gen_qemu_ld_i64(cpu_exclusive_val, addr, idx, memop);
>> tcg_gen_mov_i64(cpu_reg(s, rt), cpu_exclusive_val);
Peter already pointed out that MO_ALIGN_N should be reserved for those cases
where an explicit size really needed. You should note that using MO_ALIGN_8
would be actively wrong here -- it would incorrectly require 8 byte alignment
for the single byte access of LDXRB.
r~
next prev parent reply other threads:[~2017-08-15 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:57 [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair Richard Henderson
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask Richard Henderson
2017-08-15 15:41 ` Philippe Mathieu-Daudé
2017-08-15 16:21 ` Alistair Francis
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 2/3] target/arm: Correct load exclusive pair atomicity Richard Henderson
2017-08-15 14:57 ` [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive Richard Henderson
2017-08-15 15:27 ` Eric Blake
2017-08-15 15:56 ` Philippe Mathieu-Daudé
2017-08-15 16:14 ` Peter Maydell
2017-08-15 17:48 ` Philippe Mathieu-Daudé
2017-08-15 16:32 ` Richard Henderson [this message]
2017-08-15 17:49 ` Philippe Mathieu-Daudé
2017-08-15 17:16 ` [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8846d546-5dc3-4d71-ff57-f1978ae91528@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=edgar.iglesias@xilinx.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.