From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsbUI-0001Kx-WF for qemu-devel@nongnu.org; Fri, 07 Oct 2016 16:11:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsbUG-0007rc-Ve for qemu-devel@nongnu.org; Fri, 07 Oct 2016 16:11:21 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-16-git-send-email-vsementsov@virtuozzo.com> From: Max Reitz Message-ID: <884b6473-718f-ccd7-ca54-850c6d55c08e@redhat.com> Date: Fri, 7 Oct 2016 22:11:06 +0200 MIME-Version: 1.0 In-Reply-To: <1475232808-4852-16-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TPxJojH4bEt6SnAh1wHs6J2SKN7THrsqx" Subject: Re: [Qemu-devel] [PATCH 15/22] qcow2-bitmap: add autoclear bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TPxJojH4bEt6SnAh1wHs6J2SKN7THrsqx From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: <884b6473-718f-ccd7-ca54-850c6d55c08e@redhat.com> Subject: Re: [PATCH 15/22] qcow2-bitmap: add autoclear bit References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-16-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1475232808-4852-16-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Add autoclear bit for handling rewriting image by old qemu version. "Add support for the autoclear bit [...]"? >=20 > If autoclear bit is not set, but bitmaps extension is found it > would not be loaded and warning will be generated. "If the autoclear bit is not set, but the bitmaps extension is found, the bitmaps will not be loaded and a warning will be generated." >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 4 ++++ > block/qcow2.c | 12 ++++++++++-- > block/qcow2.h | 9 +++++++++ > 3 files changed, 23 insertions(+), 2 deletions(-) Apart from the above, the patch looks good, but why does it come so late in the series? So with the commit message fixed: Reviewed-by: Max Reitz --TPxJojH4bEt6SnAh1wHs6J2SKN7THrsqx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX+AFaEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQCvF B/9tuLae8+/GYGfbc6FpNSaiMgC+oCXqaKR89UsnSCLKB/cyyIKZnCsS1BG6Sm25 107KsSGvTHrS4LnG14Tvt6IzsxaiVTzXjcJjvT5l1f4ntbfh6KQlZtRA0vyqsBNh zOmqfW/+6aHd1y9gWjuZeNo84MLoSLqH16jogpogjgmUEyba2BOoPtVtHAvumb9B 5eGyKGAqIHgEfympqRqKmlk95p91pqI5f0z6RMUjXb2DV46joVK3LtquSZ5w+8XT fTN3fkXorfK4UCuSzG20L4/5cYdMrLKYJTI7GSnVc0mKZ+ELFGyJxA/bZluCpoTE Dn1B04Xob24GuGcpadTabZ9z =7crP -----END PGP SIGNATURE----- --TPxJojH4bEt6SnAh1wHs6J2SKN7THrsqx--