From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback Date: Tue, 10 Jul 2018 15:09:08 +0300 Message-ID: <8854529.ItWJiFrqSO@avalon> References: <20180702110729.8171-1-mahesh1.kumar@intel.com> <16830133.3PzqpUzUj4@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Kumar, Mahesh" Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFoZXNoLAoKT24gVHVlc2RheSwgMTAgSnVseSAyMDE4IDE1OjAxOjM4IEVFU1QgS3VtYXIs IE1haGVzaCB3cm90ZToKPiBPbiA3LzEwLzIwMTggNDo1MiBQTSwgTGF1cmVudCBQaW5jaGFydCB3 cm90ZToKPiA+IEhpIE1haGVzaCwKPiA+IE9uIE1vbmRheSwgMiBKdWx5IDIwMTggMTQ6MDc6MjEg RUVTVCBNYWhlc2ggS3VtYXIgd3JvdGU6Cj4gPj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2UgYSBjYWxs YmFjayBmdW5jdGlvbiAiZ2V0X2NyY19zb3VyY2VzIiB3aGljaAo+ID4+IHdpbGwgYmUgY2FsbGVk IGR1cmluZyByZWFkIG9mIGNvbnRyb2wgbm9kZS4gSXQgaXMgYW4gb3B0aW9uYWwKPiA+PiBjYWxs YmFjayBmdW5jdGlvbiBhbmQgaWYgZHJpdmVyIGltcGxlbWVudHMgdGhpcyBjYWxsYmFjaywgZHJp dmVyCj4gPj4gc2hvdWxkIHByaW50IGxpc3Qgb2YgYXZhaWxhYmxlIENSQyBzb3VyY2VzIGluIHNl cV9maWxlIHByaXZpZGVkCj4gPj4gYXMgYW4gaW5wdXQgdG8gdGhlIGNhbGxiYWNrLgo+ID4gCj4g PiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2VlbXMgdG8gYmUgb3V0ZGF0ZWQsIHRoZSBjYWxsYmFjayBk b2Vzbid0IHRha2UgYQo+ID4gc2VxX2ZpbGUgYW55bW9yZS4KPiAKPiBvcHMsIHdpbGwgdXBkYXRl Lgo+IAo+ID4+IENoYW5nZXMgU2luY2UgVjE6IChEYW5pZWwpCj4gPj4gCj4gPj4gICAtIHJldHVy biBjb25zdCBwb2ludGVyIHRvIGFuIGFycmF5IG9mIGNyYyBzb3VyY2VzIGxpc3QKPiA+PiAgIC0g ZG8gdmFsaWRhdGlvbiBvZiBzb3VyY2VzIGluIENSQy1jb3JlCj4gPj4gCj4gPj4gU2lnbmVkLW9m Zi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiA+PiBDYzogZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4+IFJldmlld2VkLWJ5OiBNYWFydGVuIExh bmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ IAo+ID4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jIHwgMjAgKysrKysrKysr KysrKysrKysrKy0KPiA+PiAgIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAgICB8IDE2 ICsrKysrKysrKysrKysrKysKPiA+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQo+ID4+IAo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2RlYnVnZnNfY3JjLmMKPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMu YyBpbmRleCBjNmE3MjViNzlhYzYuLmY0ZDc2NTI4ZDI0Ywo+ID4+IDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZGVidWdmc19jcmMuYwo+ID4+IEBAIC02Nyw5ICs2NywyNyBAQAo+ID4+IAo+ID4+ ICAgc3RhdGljIGludCBjcmNfY29udHJvbF9zaG93KHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAq ZGF0YSkKPiA+PiAgIHsKPiA+PiAgIAo+ID4+ICAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IG0t PnByaXZhdGU7Cj4gPj4gCj4gPj4gKwlzaXplX3QgY291bnQ7Cj4gPiAKPiA+IENvdW50IGl0IG9u bHkgdXNlZCB3aXRoaW4gdGhlIGlmICgpIHt9IGJsb2NrLCB5b3UgY2FuIGRlY2xhcmUgaXQgdGhl cmUuCj4gCj4gYWdyZWUuCj4gCj4gPj4gKwo+ID4+ICsJaWYgKGNydGMtPmZ1bmNzLT5nZXRfY3Jj X3NvdXJjZXMpIHsKPiA+PiArCQljb25zdCBjaGFyICpjb25zdCAqc291cmNlcyA9IGNydGMtPmZ1 bmNzLT5nZXRfY3JjX3NvdXJjZXMoY3J0YywKPiA+PiArCQkJCQkJCQkJJmNvdW50KTsKPiA+PiAr CQlzaXplX3QgdmFsdWVzX2NudDsKPiA+PiArCQlpbnQgaTsKPiA+IAo+ID4gSSBvbmx5IHRha2Vz IHBvc2l0aXZlIHZhbHVlcywgaXQgY2FuIGJlIGFuIHVuc2lnbmVkIGludC4KPiAKPiBvawo+IAo+ ID4+ICsKPiA+PiArCQlpZiAoY291bnQgPD0gMCB8fCAhc291cmNlcykKPiA+IAo+ID4gY291bnQg aXMgYSBzaXplX3QsIGl0IGNhbid0IGJlIG5lZ2F0aXZlLgo+ID4gCj4gPiBUaGUgLmdldF9jcmNf c291cmNlcygpIGRvY3VtZW50YXRpb24gZG9lc24ndCBjbGVhcmx5IHNwZWNpZnkgd2hldGhlcgo+ ID4gc291cmNlcyBzaG91bGQgYWx3YXlzIGJlIE5VTEwgd2hlbiBjb3VudCBpcyB6ZXJvLiBJIGFk dmlzZSB1cGRhdGluZyB0aGUKPiA+IGRvY3VtZW50YXRpb24sIGFuZCBwb3NzaWJseSB1cGRhdGlu ZyB0aGlzIGNoZWNrIGFjY29yZGluZ2x5Lgo+IAo+IG9rIHdpbGwgdXBkYXRlLgo+IAo+ID4+ICsJ CQlnb3RvIG91dDsKPiA+PiArCj4gPj4gKwkJc2VxX3B1dHMobSwgIlsiKTsKPiA+PiArCQlmb3Ig KGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPiA+PiArCQkJaWYgKCFjcnRjLT5mdW5jcy0+dmVyaWZ5 X2NyY19zb3VyY2UoY3J0Yywgc291cmNlc1tpXSwKPiA+PiArCQkJCQkJCSAgICAmdmFsdWVzX2Nu dCkpCj4gPiAKPiA+IEkgYXNzdW1lIHRoYXQgeW91IHZlcmlmeSBzb3VyY2VzIG9uZSBieSBvbmUg aGVyZSB0byBhdm9pZCBoYXZpbmcgdG8gY3JlYXRlCj4gPiBhIGxpc3Qgb2Ygc291cmNlcyBkeW5h bWljYWxseSBpbiB0aGUgLmdldF9jcmNfc291cmNlcygpIGNhbGxiYWNrID8gSWYgc28sCj4gPiBJ IHRoaW5rIHRoZSAuZ2V0X2NyY19zb3VyY2VzKCkgY2FsbGJhY2sgc2hvdWxkIGRvY3VtZW50IHRo YXQuCj4gPiAKPiA+IFlvdSBzaG91bGQgYWxzbyBkb2N1bWVudCB0aGF0IC52ZXJpZnlfY3JjX3Nv dXJjZSgpIGlzIHJlcXVpcmVkIHdoZW4KPiA+IGdldF9jcmNfc291cmNlcygpIGlzIHByb3ZpZGVk Lgo+IAo+IG9rIHN1cmUuCj4gCj4gPj4gKwkJCQlzZXFfcHJpbnRmKG0sICIlcyAiLCBzb3VyY2Vz W2ldKTsKPiA+PiArCQlzZXFfcHV0cyhtLCAiXSAiKTsKPiA+IAo+ID4gVGhpcyBhc3N1bWVzIHRo YXQgc291cmNlIG5hbWVzIGNhbid0IGluY2x1ZGUgYSBzcGFjZS4gSXNuJ3QgdGhhdCB0b28KPiA+ IHJlc3RyaWN0aXZlID8gU2hvdWxkbid0IGEgZGlmZmVyZW50IHNlcGFyYXRvciBiZSB1c2VkID8g SG93IGFib3V0IG9uZQo+ID4gc291cmNlIG5hbWUgcGVyIGxpbmUgPwo+IAo+IHdoYXQgYWJvdXQg Y29tbWEgc2VwYXJhdGVkIGFzIEknbSBwdXR0aW5nIG5hbWVzIGluc2lkZSBzcXVhcmUtYnJhY2tl dHM/Cj4gCj4gPiBBZGRpdGlvbmFsbHksIHNob3VsZG4ndCB0aGUgYWN0aXZlIHNvdXJjZSBiZSBt YXJrZWQgPwo+IAo+IGFjdGl2ZSBzb3VyY2UgaXMgYWdhaW4gcHJpbnRlZCBieSB0aGUgY29kZSBp biBuZXh0IGZldyBsaW5lcy4gb3V0cHV0Cj4gd2lsbCBiZSBvZiBmb2xsb3dpbmcgZm9ybWF0Lgo+ IFtzcGFjZSBzZXBhcmF0ZWQgbGlzdCBvZiB2YWxpZCBzb3VyY2VzXSBhY3RpdmVfc291cmNlCgpJ IGhhZCBtaXNzZWQgdGhhdCwgbXkgYmFkLgoKVGhlIHByb3Bvc2VkIGZvcm1hdCBzZWVtcyBhIGJp dCBoYWNraXNoIHRvIG1lLCBpbiB0aGUgc2Vuc2UgdGhhdCBpdCBmb3JiaWRzIApib3RoIHNwYWNl cyBhbmQgYnJhY2tldHMgaW4gc291cmNlIG5hbWVzLiBPbmUgc291cmNlIHBlciBsaW5lIHdvdWxk IGZpeCBib3RoIAphbmQgYmUgZWFzeSB0byBwYXJzZS4gV2Ugd291bGQgdGhlbiBuZWVkIHRvIG1h cmsgdGhlIGFjdGl2ZSBzb3VyY2UsIHdoaWNoIApjb3VsZCBiZSBkb25lIGJ5IGFkZGluZyBhIG1h cmtlciB0byB0aGUgY29ycmVzcG9uZGluZyBsaW5lIChtYXliZSBhICogYXQgdGhlIAplbmQgb2Yg dGhlIGxpbmUgPykuCgo+ID4+ICsJfQo+ID4+IAo+ID4+ICtvdXQ6Cj4gPj4gICAJc2VxX3ByaW50 ZihtLCAiJXNcbiIsIGNydGMtPmNyYy5zb3VyY2UpOwo+ID4+IC0KPiA+PiAgIAlyZXR1cm4gMDsK PiA+PiAgIH0KCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=