From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4906BC07E96 for ; Thu, 8 Jul 2021 16:44:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B760A6145A for ; Thu, 8 Jul 2021 16:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B760A6145A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1X8J-0000Jw-Nt for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 12:44:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1WWD-0007z7-TT for qemu-devel@nongnu.org; Thu, 08 Jul 2021 12:04:54 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:37454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1WWA-0005zO-H9 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 12:04:53 -0400 Received: by mail-pl1-x629.google.com with SMTP id a14so3234638pls.4 for ; Thu, 08 Jul 2021 09:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fygWJfwDNSSDF4VUyI0K1AU2fBwaAUpGuNPoR+oaYGg=; b=N5XzCFjTcDZVc0ZlzsZvPq2g3ZQAl1iUVwcytOZALG11Z6YfQRNzrmE7AGuUjtxG4A u4BaawU0dAOPgSUlAkoGk13+rM/nqKhizKE3KX91DYQLAsb/y5VVBqCccDAg5KmXe+/V 5FWPXUrAhLNYrxV11KTdsv3zts0Yc9xMM1MKhoFz8jywUUY1fd74Q8AW9D+DrM3AVC40 jEI7fH9atIjdGM9IssiNs8DTTQQYeZsnPNqSODevSsERHazWfXw47WhxCkqhfM7R1gwT KBwoqP1IWBumSdmbwOSfoqJw6MtTBTK34vwBi4EoaSgdDJFe0iPceh1ugGnXcVX4aOID ywwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fygWJfwDNSSDF4VUyI0K1AU2fBwaAUpGuNPoR+oaYGg=; b=p5dXYAcpwb8t8LirSZ+dOfmhPzfDgNYuq05N6j0ATTiSjidGhmCQAkWFy0knNfOTbj i0s/vSmFw//UZyvPl+b3ayq9Li3aKgOrHvpIppvCkFWxD+5gQVWeA20fN0D2VX/tAxvj XBzqU0jTNcIr9Xi4aVyxznrm47dlGZVWyVIEm9rcjK9PbqiSEwVmMjCKod6eteHIvudH Z7SroHidZ4yDBWFEQOf1vYDFI6WP15pZ+sA0urcxjHpno3dSbOkozjhYqVGBQLibEvPY 7Ljhdz2lGiB0hu3mxd7+t6xmutMWymvMZdiN9bw9XKTqwC+svNAQHWntsUfIyG6DCIqQ 0DRg== X-Gm-Message-State: AOAM533QpW3Q0LL19WGihAldfYId0+oqGT8D+VnSCv2r2utO2STYhTit VKn8BXKKcNVOYju5ZjQpnaEI8A== X-Google-Smtp-Source: ABdhPJzL8EbmM2DMjIxB5qHqPH7QWf8KiylaFhN5v60IdU+O4Mwi+9RuWSCgZTNaLO7morzoZrcRkQ== X-Received: by 2002:a17:90a:eac3:: with SMTP id ev3mr5759075pjb.161.1625760288847; Thu, 08 Jul 2021 09:04:48 -0700 (PDT) Received: from [192.168.1.11] ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id b62sm3468329pfb.149.2021.07.08.09.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 09:04:48 -0700 (PDT) Subject: Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB To: Peter Maydell References: <20210630183226.3290849-1-richard.henderson@linaro.org> <20210630183226.3290849-6-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <88562e08-3d6c-3224-5d84-67e3ffd3774b@linaro.org> Date: Thu, 8 Jul 2021 09:04:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/8/21 5:05 AM, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 19:47, Richard Henderson > wrote: >> >> Using gen_goto_tb directly misses the single-step check. >> >> Cc: qemu-arm@nongnu.org >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/target/arm/translate.c b/target/arm/translate.c >> index a0c6cfa902..8cd31feeaa 100644 >> --- a/target/arm/translate.c >> +++ b/target/arm/translate.c >> @@ -8582,7 +8582,7 @@ static bool trans_ISB(DisasContext *s, arg_ISB *a) >> * self-modifying code correctly and also to take >> * any pending interrupts immediately. >> */ >> - gen_goto_tb(s, 0, s->base.pc_next); >> + gen_jmp(s, s->base.pc_next); >> return true; >> } >> >> @@ -8596,7 +8596,7 @@ static bool trans_SB(DisasContext *s, arg_SB *a) >> * for TCG; MB and end the TB instead. >> */ >> tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC); >> - gen_goto_tb(s, 0, s->base.pc_next); >> + gen_jmp(s, s->base.pc_next); >> return true; > > Why isn't it enough here just to set is_jmp to DISAS_NEXT ? You mean DISAS_TOO_MANY? That would work, yes. At the time I was just thinking of replacing one jump with another. r~