All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sinan Kaya" <okaya@kernel.org>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
Date: Tue, 15 Dec 2020 14:54:06 -0500	[thread overview]
Message-ID: <8861f46e-fc85-2af4-fb2a-0aed9cb89791@kernel.org> (raw)
In-Reply-To: <CADkTA4OWM5PJXSgp7SMu+n0071YE-3wkaoV2JUPCuf5u=XdAnQ@mail.gmail.com>

On 12/15/2020 2:44 PM, Bruce Ashfield wrote:
>> -FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
> I don't see this maintained in the split of changes below, why was it dropped ?
> 

I'll fix that. I thought ${libdir} would cover it but apparently it does
not.

>>  FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
>>                      ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
>> +
>> +PACKAGES += "${PN}-cvtsudoers"
>> +PACKAGES += "${PN}-sudoreplay"
>> +PACKAGES += "${PN}-visudo"
>> +PACKAGES += "${PN}-sudo"
>> +PACKAGES += "${PN}-lib"
>> +
>> +RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
>> +RDEPENDS_${PN}-sudo = "${PN}-lib"
>> +RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
>> +RDEPENDS_${PN}-visudo = "${PN}-lib"
>> +
>> +PROVIDES += "${PACKAGES}"
>> +RRECOMMENDS_${PN} += "${PACKAGES}"

> This isn't a direct replacement of the existing packaging. If we are
> going to get a series of patches that keep splitting on binaries, they
> shouldn't be like this.
>> For an image or configuration that turns off rrecommends (which is the
> policy for a distro that I have), this is not backwards compatible and
> we are going to get all sorts of runtime issues .. and then be forced
> to update packages lists with this explosion of new splits.

Interesting, I didn't know that RRECOMMENDS can be turned off.
I was hoping to do a non-invasive change for existing users.

> 
> If we do splits like this, something stronger than rrcommends is
> needed, or they simply belong in a layer besides core.

Would RDEPENDS work?

Sinan

  reply	other threads:[~2020-12-15 19:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 19:35 [meta-oe][PATCH v3] sudo: split into smaller tools package Sinan Kaya
2020-12-15 19:44 ` [OE-core] " Bruce Ashfield
2020-12-15 19:54   ` Sinan Kaya [this message]
2020-12-15 19:57     ` Bruce Ashfield
2020-12-15 20:09       ` Sinan Kaya
2020-12-15 21:07         ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8861f46e-fc85-2af4-fb2a-0aed9cb89791@kernel.org \
    --to=okaya@kernel.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.