From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: mmc: fix build without CONFIG_SPL_LIBCOMMON_SUPPORT
Date: Thu, 17 Nov 2016 17:09:09 +0900 [thread overview]
Message-ID: <88750dae-ca01-0492-cd1d-fa1d4bb3f8e7@samsung.com> (raw)
In-Reply-To: <1479073579-30771-1-git-send-email-yann.morin.1998@free.fr>
Hi,
On 11/14/2016 06:46 AM, Yann E. MORIN wrote:
> When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement
> is missing a proper statement, which makes the compiler whine.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> common/spl/spl_mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index c674e61..cc81d19 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
>
> break;
> case MMCSD_MODE_UNDEFINED:
> + ;
> #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> default:
> puts("spl: mmc: wrong boot mode\n");
case MMCSD_MODE_UNDEFINED:
...
#ifdef CONFIG_....
default:
put()
#endif
break;
How about adding "break"?
Best Regards,
Jaehoon Chung
>
next prev parent reply other threads:[~2016-11-17 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161113214655epcas4p3a2ea71ae6e8470cac1996ee59d73563a@epcas4p3.samsung.com>
2016-11-13 21:46 ` [U-Boot] [PATCH] spl: mmc: fix build without CONFIG_SPL_LIBCOMMON_SUPPORT Yann E. MORIN
2016-11-13 22:59 ` Tom Rini
2016-11-17 8:09 ` Jaehoon Chung [this message]
2016-11-17 17:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88750dae-ca01-0492-cd1d-fa1d4bb3f8e7@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.