From: Jonah Palmer <jonah.palmer@oracle.com>
To: Eric Blake <eblake@redhat.com>
Cc: fam@euphon.net, kwolf@redhat.com, thuth@redhat.com,
qemu-block@nongnu.org, mst@redhat.com, michael.roth@amd.com,
david@redhat.com, qemu-devel@nongnu.org, amit@kernel.org,
armbru@redhat.com, eric.auger@redhat.com, kraxel@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com, si-wei.liu@oracle.com,
marcandre.lureau@redhat.com, joao.m.martins@oracle.com,
mreitz@redhat.com, boris.ostrovsky@oracle.com,
dgilbert@redhat.com, laurent@vivier.eu
Subject: Re: [PATCH v7 7/8] qmp: add QMP command x-debug-virtio-queue-element
Date: Tue, 12 Oct 2021 03:47:12 -0400 [thread overview]
Message-ID: <887adbf9-eda6-e8b1-8c88-e8067c8354c0@oracle.com> (raw)
In-Reply-To: <20211007132507.ldq27vwqmpym2sgs@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On 10/7/21 9:27 AM, Eric Blake wrote:
> On Tue, Oct 05, 2021 at 12:45:52PM -0400, Jonah Palmer wrote:
>> From: Laurent Vivier <lvivier@redhat.com>
>>
>> This new command shows the information of a VirtQueue element.
>>
>> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
>> ---
>> +++ b/qapi/virtio.json
>> +##
>> +# @VirtioRingAvail:
>> +#
>> +# @flags: VRingAvail flags
>> +#
>> +# @idx: VRingAvail idx
> Is it worth being consistent...
>
>> +##
>> +# @VirtioQueueElement:
>> +#
>> +# @device-name: VirtIODevice name (for reference)
>> +#
>> +# @index: index of the element in the queue
> ...and spelling things 'index' everywhere instead of sometimes
> abbreviating?
>
> But overall, it looks like you did a nice job of making the command
> machine-parseable, while still leaving the flexibility to alter it as
> needed since it is only for developers under the x-debug- namespace.
I think I'll elaborate a bit more with these definitions (for all patches).
After attending the QAPI sync last Thursday, I realized developers would
like to see more thorough documentation in these files. For something like
virtio, this is probably worth expanding on.
Jonah
>
[-- Attachment #2: Type: text/html, Size: 2055 bytes --]
next prev parent reply other threads:[~2021-10-12 8:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 16:45 [PATCH v7 0/8] hmp,qmp: Add commands to introspect virtio devices Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 1/8] virtio: drop name parameter for virtio_init() Jonah Palmer
2021-10-05 21:18 ` Eric Blake
2021-10-12 7:49 ` Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 2/8] virtio: add vhost support for virtio devices Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 3/8] qmp: add QMP command x-debug-query-virtio Jonah Palmer
2021-10-05 21:24 ` Eric Blake
2021-10-07 8:43 ` Daniel P. Berrangé
2021-10-05 16:45 ` [PATCH v7 4/8] qmp: add QMP command x-debug-virtio-status Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 5/8] qmp: decode feature & status bits in virtio-status Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 6/8] qmp: add QMP commands for virtio/vhost queue-status Jonah Palmer
2021-10-05 16:45 ` [PATCH v7 7/8] qmp: add QMP command x-debug-virtio-queue-element Jonah Palmer
2021-10-07 13:27 ` Eric Blake
2021-10-12 7:47 ` Jonah Palmer [this message]
2021-10-05 16:45 ` [PATCH v7 8/8] hmp: add virtio commands Jonah Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887adbf9-eda6-e8b1-8c88-e8067c8354c0@oracle.com \
--to=jonah.palmer@oracle.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=joao.m.martins@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.