All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Kurth <lars.kurth@citrix.com>
To: Lars Kurth <lars.kurth@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "jgross@suse.com" <jgross@suse.com>,
	Ian Jackson <Ian.Jackson@citrix.com>,
	"committers@xenproject.org" <committers@xenproject.org>,
	Julien Grall <julien@xen.org>
Subject: Re: [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name
Date: Wed, 15 Jan 2020 18:11:11 +0000	[thread overview]
Message-ID: <8885FB4A-0DDA-4B72-93D3-E64FBC836458@citrix.com> (raw)
In-Reply-To: <89248aebf252aaabf5fce44ef4cffc7e3da38212.1578691030.git.lars.kurth@citrix.com>

I should have added more people to this change. The issue without this fix is that entries such as

L: xen-devel <xen-devel@lists.xenproject.org>

break get_maintainer.pl and thus add_maintainers.pl

Lars

On 10/01/2020, 21:19, "Lars Kurth" <lars.kurth@xenproject.org> wrote:

    From: Lars Kurth <lars.kurth@citrix.com>
    
    Prior to this change e-mail addresses of the form "display name
    <email>" would result into empty output. Also see
    https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html
    
    Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
    ---
    CC: jgross@suse.com
    ---
     scripts/get_maintainer.pl | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
    index 2e661f47d8..48e07370e8 100755
    --- a/scripts/get_maintainer.pl
    +++ b/scripts/get_maintainer.pl
    @@ -1073,7 +1073,7 @@ sub add_categories {
     	    my $ptype = $1;
     	    my $pvalue = $2;
     	    if ($ptype eq "L") {
    -		my $list_address = $pvalue;
    +		my ($list_name, $list_address) = parse_email($pvalue);            
     		my $list_additional = "";
     		my $list_role = get_list_role($i);
     
    -- 
    2.13.0
    
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-01-15 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 21:18 [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name Lars Kurth
2020-01-15 18:11 ` Lars Kurth [this message]
2020-01-16 16:04   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8885FB4A-0DDA-4B72-93D3-E64FBC836458@citrix.com \
    --to=lars.kurth@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=committers@xenproject.org \
    --cc=jgross@suse.com \
    --cc=julien@xen.org \
    --cc=lars.kurth@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.