From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6746720218426376192 X-Received: by 2002:a9d:12f1:: with SMTP id g104mr14741453otg.358.1570846032467; Fri, 11 Oct 2019 19:07:12 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:aca:2101:: with SMTP id 1ls1794312oiz.9.gmail; Fri, 11 Oct 2019 19:07:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZnBshflHY2PtjVcENJ+gOM8ssIX79cPQr/L4DNuren3xbyDhPeeFueRTflTURCGVims6p X-Received: by 2002:aca:620a:: with SMTP id w10mr15354422oib.0.1570846031487; Fri, 11 Oct 2019 19:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570846031; cv=none; d=google.com; s=arc-20160816; b=NxRkjsZUJ0UPKyBtIbCCk01lgl1E2pH/B4wYBfCHuh6cj5juhq/GBmmClCv+/TbZRw lHk5DolSCBqENMxOWyl8Snd4pXW30IdsB91EYNpzXH5ro8DHIEvSTM9jDeSx6Nw/N/Pr ltDq3+JED63Gz7QW0YkAL8hAHtSv0IchlDHUuK4sqgA2bHlXkCEGzcz4lePjvcfnIt5p V5nKpnB58/snwZC1YOA9CtxSH1OeQM3fy5My6Ml041HvqHjwwMZAba/4ULWg8uQPqEOL u/FJif0Fj3LEtH2LNDJz5VZZxp1gD4mQWydHUKv3bUsPewnZ30PeXMxRL2hlcCvuEEVD t0gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id; bh=Omn1sK629wOewURzdauokW0nAh8sEHW7KjETfEe3W6A=; b=x5WfC9lB/tTvdIRBw4DmXSVo00ufpNP3sWDO3b7TUvTUff3LD6bqimAOXtXmLTxgAE bs+lNVt8uYrMpgSs/uwGvDr6kJisYPxag0d33D1oGWCaeFA456H2YrFfzbMzY02YELcI v731SmWFglEoIdbP0cf+j52JLGFLP85Ypu5cAJR57MOrjDUxBHR8T9F6pE9p6EkH26if QaZua+y8RgjxVEW5SlXCtUq89MyaWKP12jVlm7UbJmdImxIusdi5LJhsHjFT22E9bsrm Cwq1/lqH9e0LmRz7PHcqNUrb8fkx/ABa3+REu54QL2tInT2WDFUsMULAU7DT0LylxlPL af3A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 216.40.44.105 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0105.hostedemail.com. [216.40.44.105]) by gmr-mx.google.com with ESMTPS id i19si120311otk.0.2019.10.11.19.07.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 19:07:11 -0700 (PDT) Received-SPF: neutral (google.com: 216.40.44.105 is neither permitted nor denied by best guess record for domain of joe@perches.com) client-ip=216.40.44.105; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 216.40.44.105 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 8DE79182CED2A; Sat, 12 Oct 2019 02:07:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 80,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:599:988:989:1260:1277:1311:1313:1314:1345:1359:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:4605:5007:8957:10004:10400:11232:11658:11914:12043:12048:12296:12297:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:14721:21080:21451:21627:30003:30054:30091,0,RBL:23.242.70.174:@perches.com:.lbl8.mailshell.net-62.8.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:28,LUA_SUMMARY:none X-HE-Tag: bite17_4300371d6934 X-Filterd-Recvd-Size: 2049 Received: from XPS-9350 (cpe-23-242-70-174.socal.res.rr.com [23.242.70.174]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sat, 12 Oct 2019 02:07:08 +0000 (UTC) Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis From: Joe Perches To: Gabriela Bittencourt , outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, trivial@kernel.org Date: Fri, 11 Oct 2019 19:07:06 -0700 In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> References: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ checkpatch only warns on the first unaligned argument, but all statement lines are meant to align to the open parenthesis. > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 12 Oct 2019 02:07:06 +0000 Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis Message-Id: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> List-Id: References: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gabriela Bittencourt , outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, trivial@kernel.org On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ checkpatch only warns on the first unaligned argument, but all statement lines are meant to align to the open parenthesis. > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C47C47404 for ; Sat, 12 Oct 2019 03:23:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85A892084C for ; Sat, 12 Oct 2019 03:23:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85A892084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 891FC20505; Sat, 12 Oct 2019 03:23:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZtJ7WVI05t5o; Sat, 12 Oct 2019 03:23:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id B8EC820518; Sat, 12 Oct 2019 03:23:09 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 071FB1BF9B5 for ; Sat, 12 Oct 2019 03:23:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 016018701F for ; Sat, 12 Oct 2019 03:23:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1S_9Z6pv4lpf for ; Sat, 12 Oct 2019 03:23:07 +0000 (UTC) X-Greylist: delayed 04:41:14 by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1404986FB4 for ; Sat, 12 Oct 2019 03:23:06 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave07.hostedemail.com (Postfix) with ESMTP id 2700E18014D18 for ; Sat, 12 Oct 2019 02:07:13 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 8DE79182CED2A; Sat, 12 Oct 2019 02:07:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bite17_4300371d6934 X-Filterd-Recvd-Size: 2049 Received: from XPS-9350 (cpe-23-242-70-174.socal.res.rr.com [23.242.70.174]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sat, 12 Oct 2019 02:07:08 +0000 (UTC) Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis From: Joe Perches To: Gabriela Bittencourt , outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, trivial@kernel.org Date: Fri, 11 Oct 2019 19:07:06 -0700 In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> References: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ checkpatch only warns on the first unaligned argument, but all statement lines are meant to align to the open parenthesis. > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */ _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel