From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 220A1C2D0A3 for ; Sat, 24 Oct 2020 06:04:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92B072225F for ; Sat, 24 Oct 2020 06:04:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MgUrBdA6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92B072225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWCfK-0002vQ-Ni for qemu-devel@archiver.kernel.org; Sat, 24 Oct 2020 02:04:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWCcu-0001ks-Ph for qemu-devel@nongnu.org; Sat, 24 Oct 2020 02:02:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kWCcs-0001iq-VZ for qemu-devel@nongnu.org; Sat, 24 Oct 2020 02:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603519321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPWzKZEOWikoTRJAQNTiEQwX+evqzjb1I3Ri9wF59nI=; b=MgUrBdA6AlcgbXE43ETe/TMF4i5YpidZ3B1uCdacjPJNdzyhir6O/8qDrbxNcMDrx/EEPS /QMSaNgWejaQ+JVywVt2AT19NKPdcg9GVjbTLbsUPX6Sk+2qUhjduBmvntO9acDsIypRhY wBp2FjPluddPm1OjKCaos+N9SBRCQ4I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-FugoMN_MMryH9jsSvHfHMA-1; Sat, 24 Oct 2020 02:01:59 -0400 X-MC-Unique: FugoMN_MMryH9jsSvHfHMA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DCD7803F78; Sat, 24 Oct 2020 06:01:58 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E9E060BFA; Sat, 24 Oct 2020 06:01:56 +0000 (UTC) Subject: Re: [PATCH v4 05/12] tests/qtest/qos-test: dump qos graph if verbose To: Christian Schoenebeck , qemu-devel@nongnu.org References: From: Thomas Huth Message-ID: <88899a4e-6d02-673c-fce8-41f8bf9f5224@redhat.com> Date: Sat, 24 Oct 2020 08:01:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/24 01:26:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.108, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Emanuele Giuseppe Esposito , Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/10/2020 20.34, Christian Schoenebeck wrote: > If qtests were run in verbose mode (i.e. if --verbose CL argument was > provided) then dump the generated qos graph (all nodes and edges, > along with their current individual availability status) to stdout. > > See API doc comment on function qos_dump_graph() for details. > > Signed-off-by: Christian Schoenebeck > --- > tests/qtest/qos-test.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c > index 8fdf87b183..d98ef78613 100644 > --- a/tests/qtest/qos-test.c > +++ b/tests/qtest/qos-test.c > @@ -322,6 +322,9 @@ int main(int argc, char **argv) > qos_set_machines_devices_available(); > > qos_graph_foreach_test_path(walk_path); > + if (g_test_verbose()) { > + qos_dump_graph(); > + } > g_test_run(); > qtest_end(); > qos_graph_destroy(); > I'd squash this into the previous patch, so that it is clear there where the function gets used. Thomas