From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 25/41] net/dpaa: add support for Tx and Rx
	queue setup
Date: Thu, 21 Sep 2017 18:30:51 +0530
Message-ID: <888dc27f-8240-42e1-5e29-59a9100ee379@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-26-shreyansh.jain@nxp.com>
 <065975c7-b471-2994-b0fe-f17c9fa76ab5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0046.outbound.protection.outlook.com [104.47.40.46])
 by dpdk.org (Postfix) with ESMTP id 3C70A107A
 for <dev@dpdk.org>; Thu, 21 Sep 2017 14:49:58 +0200 (CEST)
In-Reply-To: <065975c7-b471-2994-b0fe-f17c9fa76ab5@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
>> +
>> +/* Handle all mbufs on an external pool (non-dpaa2) */
> 
> minor typo, but is intention dpaa ?

Yes, this is 'dpaa'.

> 
>> +static inline uint16_t
>> +tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf,
>> +		    struct qm_fd *fd_arr)
>> +{
> 
> <...>
> 
>> @@ -185,6 +185,7 @@ endif # CONFIG_RTE_LIBRTE_DPAA2_PMD
>>   
>>   ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y)
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_bus_dpaa
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_mempool_dpaa
> 
> This should go to patch that introduces mempool.

My patch splits are not effective it seems. Third issue of incorrect 
introduction of patch that you have pointed out. I will fix this.

> 
>>   endif
>>   
>>   endif # !CONFIG_RTE_BUILD_SHARED_LIBS
>>
> 
>