All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base
Date: Mon, 4 Nov 2019 10:34:20 -0700	[thread overview]
Message-ID: <888f3cb3-6945-bc5b-6dde-95866872c6ba@wwwdotorg.org> (raw)
In-Reply-To: <9c328a11-3f37-d320-d6b3-008b759b5ac8@wwwdotorg.org>

On 10/15/19 10:09 AM, Stephen Warren wrote:
> On 10/15/19 8:07 AM, Simon Glass wrote:
>> Hi Stephen,
>>
>> On Mon, 14 Oct 2019 at 09:49, Stephen Warren <swarren@wwwdotorg.org> 
>> wrote:
>>>
>>> On 9/26/19 6:38 PM, sjg at google.com wrote:
>>>> At present binman adds the image base address to the symbol value 
>>>> before
>>>> it writes it to the binary. This is not correct since the symbol value
>>>> itself (e.g. image position) has no relationship to the image base.
>>>>
>>>> Fix this and update the tests to cover this case.
>>>>
>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>>> ---
>>>>
>>>>    tools/binman/elf.py                      | 4 +---
>>>>    tools/binman/test/u_boot_binman_syms.lds | 2 +-
>>>>    2 files changed, 2 insertions(+), 4 deletions(-)
>>>>
>>>> Applied to u-boot-dm, thanks!
>>>
>>> This seems to have only just been pushed. This patch breaks boot on
>>> Jetson TK1; u-boot-dm.git master hangs in SPL or before the main U-Boot
>>> prints anything, whereas after reverting this patch solves the issue.
>>>
>>> With this patch applied, all I get is:
>>>
>>> U-Boot SPL 2019.10-00490-g4f035abcde98 (Oct 14 2019 - 09:48:30 -0600)
>>> Trying to boot from RAM
>>
>> Yes, just pushed as I had to wait for u-boot-dm/testing to pass, and
>> it has some flaky runs and then I went on holiday.
>>
>> This is unfortunate. It looks like we were missing test coverage. I'll
>> see if I can look at it later in the week, but for now I think I might
>> drop this patch.
> 
> Thanks. The latest push to u-boot-dm/master solves/removes this issue.

This patch has now shown in in u-boot/master and u-boot-video/master, so 
Jetson TK1 testing is broken there now. Reverting this patch fixes the 
issue (I only tested that in u-boot/master).

  reply	other threads:[~2019-11-04 17:34 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-24 13:22 [U-Boot] [PATCH 00/34] binman: Various improvements and tidy-ups Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 01/34] patman: Drop binary parameter Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 02/34] patman: Update command.Run() to handle failure better Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 03/34] binman: Use cls instead of self for class methods Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 04/34] binman: Allow use of help and entry-docs without libfdt Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 05/34] binman: Drop .note section from ELF Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 06/34] binman: Handle hidden symbols in ELF files Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 07/34] binman: Correct use of 'replace' in IFWI tests Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 08/34] binman: Add support for an x86 'reset' section Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 09/34] binman: x86: Separate out 16-bit reset and init code Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 10/34] binman: Add support for Intel FIT Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 11/34] binman: Fix IFWI output when using an Intel FIT image Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 12/34] binman: Use tools.Run() to run objdump Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 13/34] binman: Use the Makefile to build ELF test files Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 14/34] binman: Use the Makefile for u_boot_ucode_ptr Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 15/34] binman: Use the Makefile for u_boot_no_ucode_ptr Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 16/34] binman: Use the Makefile for u_boot_binman_syms Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 17/34] binman: Use the Makefile for u_boot_binman_syms_size Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 18/34] binman: Use the Makefile for u_boot_binman_syms_bad Simon Glass
2019-08-24 13:22 ` [U-Boot] [PATCH 19/34] binman: Clean up unnecessary code related to ELF test files Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 20/34] binman: Allow symbols to be resolved inside sections Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 21/34] binman: Use underscore in test filenames Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 22/34] binman: Rename some two-digit test files Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 23/34] binman: Avoid needing the section size in advance Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 24/34] binman: Increase size of TPL and SPL test data Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 25/34] binman: Allow support for writing a size symbol to binaries Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 27/34] binman: Add support for Intel FSP meminit Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 28/34] binman: Fix entry comment for Intel descriptor Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 29/34] binman: Update IFWI entry to read entries outside constructor Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 30/34] binman: Update IFWI entry to support updates Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 31/34] binman: Support writing symbols into entries within an IFWI Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 32/34] binman: Write symbol info before image inclusion Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 33/34] binman: Add logging for the number of pack passes Simon Glass
2019-08-24 13:23 ` [U-Boot] [PATCH 34/34] binman: Drop comment-out code in testUpdateFdtOutput() Simon Glass
2019-09-27  0:38 ` [U-Boot] [PATCH 33/34] binman: Add logging for the number of pack passes sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 34/34] binman: Drop comment-out code in testUpdateFdtOutput() sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 32/34] binman: Write symbol info before image inclusion sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 31/34] binman: Support writing symbols into entries within an IFWI sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 30/34] binman: Update IFWI entry to support updates sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 29/34] binman: Update IFWI entry to read entries outside constructor sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 28/34] binman: Fix entry comment for Intel descriptor sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 27/34] binman: Add support for Intel FSP meminit sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base sjg at google.com
2019-10-14 15:49   ` Stephen Warren
2019-10-15 14:07     ` Simon Glass
2019-10-15 16:09       ` Stephen Warren
2019-11-04 17:34         ` Stephen Warren [this message]
2019-11-05 16:33           ` Simon Glass
2019-09-27  0:38 ` [U-Boot] [PATCH 25/34] binman: Allow support for writing a size symbol to binaries sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 24/34] binman: Increase size of TPL and SPL test data sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 23/34] binman: Avoid needing the section size in advance sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 22/34] binman: Rename some two-digit test files sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 20/34] binman: Allow symbols to be resolved inside sections sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 21/34] binman: Use underscore in test filenames sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 19/34] binman: Clean up unnecessary code related to ELF test files sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 18/34] binman: Use the Makefile for u_boot_binman_syms_bad sjg at google.com
2019-09-27  0:38 ` [U-Boot] [PATCH 17/34] binman: Use the Makefile for u_boot_binman_syms_size sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 16/34] binman: Use the Makefile for u_boot_binman_syms sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 15/34] binman: Use the Makefile for u_boot_no_ucode_ptr sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 14/34] binman: Use the Makefile for u_boot_ucode_ptr sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 12/34] binman: Use tools.Run() to run objdump sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 13/34] binman: Use the Makefile to build ELF test files sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 11/34] binman: Fix IFWI output when using an Intel FIT image sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 09/34] binman: x86: Separate out 16-bit reset and init code sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 10/34] binman: Add support for Intel FIT sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 08/34] binman: Add support for an x86 'reset' section sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 07/34] binman: Correct use of 'replace' in IFWI tests sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 06/34] binman: Handle hidden symbols in ELF files sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 04/34] binman: Allow use of help and entry-docs without libfdt sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 05/34] binman: Drop .note section from ELF sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 03/34] binman: Use cls instead of self for class methods sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 02/34] patman: Update command.Run() to handle failure better sjg at google.com
2019-09-27  0:39 ` [U-Boot] [PATCH 01/34] patman: Drop binary parameter sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=888f3cb3-6945-bc5b-6dde-95866872c6ba@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.