From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Chapman <jchapman@katalix.com>
Subject: Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel
 destroy
Date: Mon, 12 Feb 2018 17:23:44 +0000
Message-ID: <889ee2f7-d43a-ec75-1bf5-919da524e766@katalix.com>
References: <1518430280-16671-1-git-send-email-jchapman@katalix.com>
 <1518430280-16671-4-git-send-email-jchapman@katalix.com>
 <20180212.112242.726213353784992033.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.katalix.com ([82.103.140.233]:38742 "EHLO mail.katalix.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751138AbeBLRXr (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 12 Feb 2018 12:23:47 -0500
In-Reply-To: <20180212.112242.726213353784992033.davem@davemloft.net>
Content-Language: en-GB
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 12/02/18 16:22, David Miller wrote:
> From: James Chapman <jchapman@katalix.com>
> Date: Mon, 12 Feb 2018 10:11:07 +0000
>
>> Previously, if a tunnel was closed, we called inet_shutdown to mark
>> the socket as unconnected such that userspace would get errors and
>> then close the socket. This could race with userspace closing the
>> socket. Instead, leave userspace to close the socket in its own time
>> (our tunnel will be detached anyway).
>>
>> Fixes: 309795f4be ("l2tp: Add netlink control API for L2TP")
>  ...
>>  BUG: unable to handle kernel NULL pointer dereference at 00000000000000a0
>>  IP: __lock_acquire+0x263/0x1630
> Ok, all of these are like this.
>
> Please fix this up, put the kernel log message into the message body
> and add an appropriate signoff.
>
> Thank you.

Oh stupid me. I'll do so straight away. Sorry!