* [PATCH v2] mt76: mt7921: enable VO tx aggregation
@ 2021-08-04 10:31 YN Chen
2021-08-04 16:21 ` Lorenzo Bianconi
0 siblings, 1 reply; 3+ messages in thread
From: YN Chen @ 2021-08-04 10:31 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi
Cc: Sean Wang, Soul Huang, YN Chen, Leon Yen, Eric-SY Chang,
Deren Wu, KM Lin, Robin Chiu, CH Yeh, Posh Sun, Eric Liang,
Stella Chang, jemele, yenlinlai, linux-wireless, linux-mediatek,
Deren Wu
From: Deren Wu <deren.wu@mediatek.com>
Avoid throughput drop in VO streaming, enable TX BA by default.
Signed-off-by: Deren Wu <deren.wu@mediatek.com>
Signed-off-by: YN Chen <YN.Chen@mediatek.com>
---
v1 -> v2 : commit format adjustment
---
drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
index 296e0f7a1d14..1be1e07ae786 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
@@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi)
return;
tid = FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1]));
- if (tid >= 6) /* skip VO queue */
- return;
val = le32_to_cpu(txwi[2]);
fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 |
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mt76: mt7921: enable VO tx aggregation
2021-08-04 10:31 [PATCH v2] mt76: mt7921: enable VO tx aggregation YN Chen
@ 2021-08-04 16:21 ` Lorenzo Bianconi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2021-08-04 16:21 UTC (permalink / raw)
To: YN Chen
Cc: Felix Fietkau, Lorenzo Bianconi, Sean Wang, Soul Huang, Leon Yen,
Eric-SY Chang, Deren Wu, KM Lin, Robin Chiu, CH Yeh, Posh Sun,
Eric Liang, Stella Chang, jemele, yenlinlai, linux-wireless,
linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
> From: Deren Wu <deren.wu@mediatek.com>
>
> Avoid throughput drop in VO streaming, enable TX BA by default.
802.11 ampdu is disabled for VO traffic in order to avoid introducing delay I guess.
Regards,
Lorenzo
>
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> Signed-off-by: YN Chen <YN.Chen@mediatek.com>
> ---
> v1 -> v2 : commit format adjustment
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> index 296e0f7a1d14..1be1e07ae786 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> @@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi)
> return;
>
> tid = FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1]));
> - if (tid >= 6) /* skip VO queue */
> - return;
>
> val = le32_to_cpu(txwi[2]);
> fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 |
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mt76: mt7921: enable VO tx aggregation
@ 2021-08-04 16:21 ` Lorenzo Bianconi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2021-08-04 16:21 UTC (permalink / raw)
To: YN Chen
Cc: Felix Fietkau, Lorenzo Bianconi, Sean Wang, Soul Huang, Leon Yen,
Eric-SY Chang, Deren Wu, KM Lin, Robin Chiu, CH Yeh, Posh Sun,
Eric Liang, Stella Chang, jemele, yenlinlai, linux-wireless,
linux-mediatek
[-- Attachment #1.1: Type: text/plain, Size: 1075 bytes --]
> From: Deren Wu <deren.wu@mediatek.com>
>
> Avoid throughput drop in VO streaming, enable TX BA by default.
802.11 ampdu is disabled for VO traffic in order to avoid introducing delay I guess.
Regards,
Lorenzo
>
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> Signed-off-by: YN Chen <YN.Chen@mediatek.com>
> ---
> v1 -> v2 : commit format adjustment
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> index 296e0f7a1d14..1be1e07ae786 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> @@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi)
> return;
>
> tid = FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1]));
> - if (tid >= 6) /* skip VO queue */
> - return;
>
> val = le32_to_cpu(txwi[2]);
> fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 |
> --
> 2.25.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-04 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 10:31 [PATCH v2] mt76: mt7921: enable VO tx aggregation YN Chen
2021-08-04 16:21 ` Lorenzo Bianconi
2021-08-04 16:21 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.