* [linux-next:master 5414/6649] lib/zstd/common/debug.h: zstd_deps.h is included more than once.
@ 2021-10-07 23:27 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-10-07 23:27 UTC (permalink / raw)
To: Nick Terrell; +Cc: kbuild-all, Linux Memory Management List, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f8dc23b3dc0cc5b32dfd0c446e59377736d073a7
commit: c684b4e9a3013dd0ee02b2e82d8035c2e5486197 [5414/6649] lib: zstd: Upgrade to latest upstream zstd version 1.4.10
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
includecheck warnings: (new ones prefixed by >>)
>> lib/zstd/common/debug.h: zstd_deps.h is included more than once.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-next:master 5414/6649] lib/zstd/common/debug.h: zstd_deps.h is included more than once.
@ 2021-10-07 23:27 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-10-07 23:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f8dc23b3dc0cc5b32dfd0c446e59377736d073a7
commit: c684b4e9a3013dd0ee02b2e82d8035c2e5486197 [5414/6649] lib: zstd: Upgrade to latest upstream zstd version 1.4.10
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
includecheck warnings: (new ones prefixed by >>)
>> lib/zstd/common/debug.h: zstd_deps.h is included more than once.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion
2021-10-07 23:27 ` kernel test robot
@ 2021-10-07 23:27 ` kernel test robot
-1 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-10-07 23:27 UTC (permalink / raw)
To: Nick Terrell; +Cc: kbuild-all, Linux Memory Management List, linux-kernel
Generated by: scripts/checkincludes.pl
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
debug.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
index 6dd88d1fbd02c..c8dc0b1890369 100644
--- a/lib/zstd/common/debug.h
+++ b/lib/zstd/common/debug.h
@@ -65,7 +65,6 @@
#if (DEBUGLEVEL>=1)
# define ZSTD_DEPS_NEED_ASSERT
-# include "zstd_deps.h"
#else
# ifndef assert /* assert may be already defined, due to prior #include <assert.h> */
# define assert(condition) ((void)0) /* disable assert (default) */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion
@ 2021-10-07 23:27 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-10-07 23:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
Generated by: scripts/checkincludes.pl
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
debug.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
index 6dd88d1fbd02c..c8dc0b1890369 100644
--- a/lib/zstd/common/debug.h
+++ b/lib/zstd/common/debug.h
@@ -65,7 +65,6 @@
#if (DEBUGLEVEL>=1)
# define ZSTD_DEPS_NEED_ASSERT
-# include "zstd_deps.h"
#else
# ifndef assert /* assert may be already defined, due to prior #include <assert.h> */
# define assert(condition) ((void)0) /* disable assert (default) */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion
2021-10-07 23:27 ` kernel test robot
@ 2021-10-08 0:09 ` Nick Terrell
-1 siblings, 0 replies; 6+ messages in thread
From: Nick Terrell @ 2021-10-08 0:09 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, Linux Memory Management List, linux-kernel
> On Oct 7, 2021, at 4:27 PM, kernel test robot <lkp@intel.com> wrote:
>
> Generated by: scripts/checkincludes.pl
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> debug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
> index 6dd88d1fbd02c..c8dc0b1890369 100644
> --- a/lib/zstd/common/debug.h
> +++ b/lib/zstd/common/debug.h
> @@ -65,7 +65,6 @@
>
> #if (DEBUGLEVEL>=1)
> # define ZSTD_DEPS_NEED_ASSERT
> -# include "zstd_deps.h"
> #else
> # ifndef assert /* assert may be already defined, due to prior #include <assert.h> */
> # define assert(condition) ((void)0) /* disable assert (default) */
This is an intentional design choice of upstream zstd, and is correct.
Defining ZSTD_DEPS_NEED_ASSERT will cause “zstd_deps.h” to
provide a definition of assert(), even if it has already been included.
-Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion
@ 2021-10-08 0:09 ` Nick Terrell
0 siblings, 0 replies; 6+ messages in thread
From: Nick Terrell @ 2021-10-08 0:09 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
> On Oct 7, 2021, at 4:27 PM, kernel test robot <lkp@intel.com> wrote:
>
> Generated by: scripts/checkincludes.pl
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> debug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
> index 6dd88d1fbd02c..c8dc0b1890369 100644
> --- a/lib/zstd/common/debug.h
> +++ b/lib/zstd/common/debug.h
> @@ -65,7 +65,6 @@
>
> #if (DEBUGLEVEL>=1)
> # define ZSTD_DEPS_NEED_ASSERT
> -# include "zstd_deps.h"
> #else
> # ifndef assert /* assert may be already defined, due to prior #include <assert.h> */
> # define assert(condition) ((void)0) /* disable assert (default) */
This is an intentional design choice of upstream zstd, and is correct.
Defining ZSTD_DEPS_NEED_ASSERT will cause “zstd_deps.h” to
provide a definition of assert(), even if it has already been included.
-Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-08 0:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 23:27 [linux-next:master 5414/6649] lib/zstd/common/debug.h: zstd_deps.h is included more than once kernel test robot
2021-10-07 23:27 ` kernel test robot
2021-10-07 23:27 ` [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion kernel test robot
2021-10-07 23:27 ` kernel test robot
2021-10-08 0:09 ` Nick Terrell
2021-10-08 0:09 ` Nick Terrell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.