From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byiA0-00064K-2Z for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:31:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byi9z-0005Q5-9t for qemu-devel@nongnu.org; Mon, 24 Oct 2016 12:31:40 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-18-git-send-email-vsementsov@virtuozzo.com> From: Vladimir Sementsov-Ogievskiy Message-ID: <88aa5571-45d9-54a1-208b-6d958046873a@virtuozzo.com> Date: Mon, 24 Oct 2016 18:55:52 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/22] qmp: add autoload parameter to block-dirty-bitmap-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com 10.10.2016 19:25, Max Reitz wrote: > On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >> Optional. Default is false. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: Denis V. Lunev >> --- >> blockdev.c | 22 ++++++++++++++++++++-- >> qapi/block-core.json | 7 ++++++- >> qmp-commands.hx | 5 ++++- >> 3 files changed, 30 insertions(+), 4 deletions(-) > Design question: I see that being able to specify these flags when > creating bitmaps is useful. However, would about a way for the user to > change these flags on an existing dirty bitmap? Would you consider that > useful? > > (Of course, if so, it can always be added later, we don't need it now.) I vote for adding later, if needed. For now we don't have such scenarios. -- Best regards, Vladimir