From: Max Staudt <mstaudt@suse.de>
To: Oliver Neukum <ONeukum@suse.com>, Hans de Goede <hdegoede@redhat.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: entering the error case of i2c-designware with a timeout at probe
Date: Tue, 21 Mar 2017 13:57:16 +0100 [thread overview]
Message-ID: <88af9925-fea6-83af-a8ee-67feb87d59e6@suse.de> (raw)
In-Reply-To: <1490100731.8154.13.camel@suse.com>
On 03/21/2017 01:52 PM, Oliver Neukum wrote:
> Hi Hans,
>
> we found on our test systems with a bit of experimentation,
> that actually running into the timeout is bound to hang the whole
> system within only a few seconds.
> I was wondering whether the error handling needs to be changed.
In other words, whether we should rather wait for lock acquisition,
unconditionally. No timeout, just wait. That's what our hardware
seems to need.
It feels like once the lock has been requested by the Linux driver,
we can't cancel that request and have to actually follow through
with accepting the lock and only giving it back after that.
Resetting the "request" bit to 0 as it is done now doesn't work as
it leads to the hung system sometime soon after that.
Max
next prev parent reply other threads:[~2017-03-21 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 12:52 entering the error case of i2c-designware with a timeout at probe Oliver Neukum
2017-03-21 12:57 ` Max Staudt [this message]
2017-03-21 13:01 ` Hans de Goede
2017-03-21 13:36 ` Oliver Neukum
2017-03-21 13:55 ` Hans de Goede
2017-03-21 14:05 ` Oliver Neukum
2017-03-21 14:48 ` Hans de Goede
2017-03-21 15:37 ` Oliver Neukum
2017-03-21 15:40 ` Hans de Goede
2017-03-21 13:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88af9925-fea6-83af-a8ee-67feb87d59e6@suse.de \
--to=mstaudt@suse.de \
--cc=ONeukum@suse.com \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.