From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf Date: Wed, 23 Nov 2016 16:34:23 +0530 Message-ID: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com> References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-3-git-send-email-david@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1479871767-20160-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Lechner , Linus Walleij , Rob Herring , Mark Rutland , Kevin Hilman Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Axel Haslam , Alexandre Bailon , =?UTF-8?Q?Bartosz_Go=c5=82aszewski?= List-Id: linux-gpio@vger.kernel.org On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These s/DA8XX/DA850/ > SoCs have a separate controller for controlling pullup/pulldown groups. > > Signed-off-by: David Lechner > +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev, > + unsigned int selector) > +{ > + return da850_pupd_group_names[selector]; > +} > + > +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev, > + unsigned int selector, > + const unsigned int **pins, > + unsigned int *num_pins) > +{ > + *num_pins = 0; > + > + return 0; > +} usage of get_get_ in the function names above is odd. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935632AbcKWLFs (ORCPT ); Wed, 23 Nov 2016 06:05:48 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:52932 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933864AbcKWLFp (ORCPT ); Wed, 23 Nov 2016 06:05:45 -0500 Subject: Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf To: David Lechner , Linus Walleij , Rob Herring , Mark Rutland , Kevin Hilman References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-3-git-send-email-david@lechnology.com> CC: , , , , Axel Haslam , Alexandre Bailon , =?UTF-8?Q?Bartosz_Go=c5=82aszewski?= From: Sekhar Nori Message-ID: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com> Date: Wed, 23 Nov 2016 16:34:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479871767-20160-3-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These s/DA8XX/DA850/ > SoCs have a separate controller for controlling pullup/pulldown groups. > > Signed-off-by: David Lechner > +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev, > + unsigned int selector) > +{ > + return da850_pupd_group_names[selector]; > +} > + > +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev, > + unsigned int selector, > + const unsigned int **pins, > + unsigned int *num_pins) > +{ > + *num_pins = 0; > + > + return 0; > +} usage of get_get_ in the function names above is odd. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Wed, 23 Nov 2016 16:34:23 +0530 Subject: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf In-Reply-To: <1479871767-20160-3-git-send-email-david@lechnology.com> References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-3-git-send-email-david@lechnology.com> Message-ID: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These s/DA8XX/DA850/ > SoCs have a separate controller for controlling pullup/pulldown groups. > > Signed-off-by: David Lechner > +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev, > + unsigned int selector) > +{ > + return da850_pupd_group_names[selector]; > +} > + > +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev, > + unsigned int selector, > + const unsigned int **pins, > + unsigned int *num_pins) > +{ > + *num_pins = 0; > + > + return 0; > +} usage of get_get_ in the function names above is odd. Thanks, Sekhar