All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kimberly Brown <kimbrownkd@gmail.com>
To: outreachy-kernel@googlegroups.com,
	Arnaud Patard <arnaud.patard@rtp-net.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 1/2] staging: xgifb: vb_setmode: fix multiple line dereference
Date: Sun, 28 Oct 2018 14:11:52 -0400	[thread overview]
Message-ID: <88c24ad8bb609b93e22c6b1884252517750d2ecc.1540749179.git.kimbrownkd@gmail.com> (raw)
In-Reply-To: <cover.1540749179.git.kimbrownkd@gmail.com>

Fix multiple line dereference by adding a new line and adjusting
indentations. This change improves code readability. Issue found by
checkpatch.

Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
 drivers/staging/xgifb/vb_setmode.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 1fa0dc66406e..62b45a30e0f1 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -656,8 +656,9 @@ static void XGI_UpdateXG21CRTC(unsigned short ModeNo,
 	    (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
 						      RES640x480x60))
 		index = 12;
-	else if (ModeNo == 0x2E && (XGI330_RefIndex[RefreshRateTableIndex].
-				Ext_CRT1CRTC == RES640x480x72))
+	else if (ModeNo == 0x2E &&
+		 (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
+								RES640x480x72))
 		index = 13;
 	else if (ModeNo == 0x2F)
 		index = 14;
-- 
2.17.1



  reply	other threads:[~2018-10-28 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-28 18:09 [PATCH 0/2] staging: xgifb: vb_setmode: fix multiple line dereference and indentations Kimberly Brown
2018-10-28 18:11 ` Kimberly Brown [this message]
2018-10-28 18:12 ` [PATCH 2/2] staging: xgifb: vb_setmode: adjust descendant indentation to right Kimberly Brown
2018-10-28 18:34   ` [Outreachy kernel] " Julia Lawall
2018-10-29  2:26     ` Kimberly Brown
2018-10-29  5:52       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88c24ad8bb609b93e22c6b1884252517750d2ecc.1540749179.git.kimbrownkd@gmail.com \
    --to=kimbrownkd@gmail.com \
    --cc=arnaud.patard@rtp-net.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.