From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matej Vido <vido@cesnet.cz>
Subject: Re: [PATCH 5/5] net/szedata2: add more supported
	firmwares
Date: Wed, 31 May 2017 10:34:50 +0200
Message-ID: <88d126a8-1575-c478-2810-d5dec0f9a96f@cesnet.cz>
References: <1495821956-5050-1-git-send-email-vido@cesnet.cz>
 <1495821956-5050-5-git-send-email-vido@cesnet.cz>
 <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by dpdk.org (Postfix) with ESMTP id 8E1347D5B
 for <dev@dpdk.org>; Wed, 31 May 2017 10:34:50 +0200 (CEST)
In-Reply-To: <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 29.05.2017 14:42, Ferruh Yigit wrote:
> On 5/26/2017 7:05 PM, Matej Vido wrote:
>> Add IBUF and OBUF offsets definitions for new firmwares.
> just to double check, is it required to add new pci device ids to
> support these new cards?
>
> Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated?
>
> Can you please update release notes to announce new cards support?
Hi Ferruh,

This patch set adds mainly the support of new firmwares for the cards 
that are already supported.
But you are right, there is also one new card which would need to add 
new pci device id. We have to check if we want to add the card in this 
patch set and I will update v2 accordingly.

>
>> Signed-off-by: Matej Vido <vido@cesnet.cz>
> <...>
>
>> +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5
>> +
>> +const uint32_t szedata2_ibuf_base_table[] = {
>> +	0x8000,
>> +	0x8200,
>> +	0x8400,
>> +	0x8600,
>> +	0x8800
>> +};
>> +const uint32_t szedata2_obuf_base_table[] = {
>> +	0x9000,
>> +	0x9200,
>> +	0x9400,
>> +	0x9600,
>> +	0x9800
>> +};
> AS = 5 is not documented in both documentation and source code comment,
> can you please add this one too?
5 is for future use and experimental firmwares. Would it make sense to 
write this note in the comments but not in the documentation to avoid 
confusion or should it be mentioned in the documentation too?

Thanks,
Matej
>> +
>>   #else
>>   #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file"
>>   #endif
>>