From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Bart Van Assche <bvanassche@acm.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-scsi@vger.kernel.org, Can Guo <cang@codeaurora.org>
Subject: Re: [PATCH RFC 0/6] Fix a deadlock in the SCSI power management code
Date: Mon, 31 Aug 2020 11:09:37 +0200 [thread overview]
Message-ID: <88d3c835-c2f9-6384-f448-8bd731db7a13@puri.sm> (raw)
In-Reply-To: <20200831025357.32700-1-bvanassche@acm.org>
On 31.08.20 04:53, Bart Van Assche wrote:
> Recently Martin Kepplinger reported a problem with the SCSI runtime PM
> code. Alan Stern root-caused the reported deadlock. This patch series is
> an attempt to fix that deadlock. These patches compile but have not yet
> been tested.
>
> Bart Van Assche (6):
> ide: Do not set the RQF_PREEMPT flag for sense requests
> scsi: Remove an incorrect comment
> scsi: Pass a request queue pointer to __scsi_execute()
> scsi_transport_spi: Make spi_execute() accept a request queue pointer
> scsi_transport_spi: Freeze request queues instead of quiescing
> block, scsi, ide: Only submit power management requests in state
> RPM_SUSPENDED
>
this patchset works for me (as an alternative to Alan's initial fix:
https://lore.kernel.org/linux-scsi/20200623111018.31954-1-martin.kepplinger@puri.sm/T/#ma566fe2e39cb3fcccdd245564913d17a343e1d1a
)
On top of this I have to apply scsi "fixes" of course and now run
exactly this:
https://lore.kernel.org/linux-scsi/20200824190400.12339-1-martin.kepplinger@puri.sm/T/#u
Is this fully applicable still now? Again, the cardreader works and
suspends as expected. So thanks a lot for working on this!
Sure someone who has experience with block and scsi code should review
this, but definitely:
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
next prev parent reply other threads:[~2020-08-31 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 2:53 [PATCH RFC 0/6] Fix a deadlock in the SCSI power management code Bart Van Assche
2020-08-31 2:53 ` [PATCH RFC 1/6] ide: Do not set the RQF_PREEMPT flag for sense requests Bart Van Assche
2020-08-31 2:53 ` [PATCH RFC 2/6] scsi: Remove an incorrect comment Bart Van Assche
2020-08-31 2:53 ` [PATCH RFC 3/6] scsi: Pass a request queue pointer to __scsi_execute() Bart Van Assche
2020-08-31 2:53 ` [PATCH RFC 4/6] scsi_transport_spi: Make spi_execute() accept a request queue pointer Bart Van Assche
2020-08-31 2:53 ` [PATCH RFC 5/6] scsi_transport_spi: Freeze request queues instead of quiescing Bart Van Assche
2020-09-03 1:39 ` Alan Stern
2020-08-31 2:53 ` [PATCH RFC 6/6] block, scsi, ide: Only submit power management requests in state RPM_SUSPENDED Bart Van Assche
2020-08-31 18:25 ` Alan Stern
2020-09-01 5:00 ` Bart Van Assche
2020-09-01 14:50 ` Alan Stern
2020-08-31 9:09 ` Martin Kepplinger [this message]
2020-09-01 3:55 ` [PATCH RFC 0/6] Fix a deadlock in the SCSI power management code Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d3c835-c2f9-6384-f448-8bd731db7a13@puri.sm \
--to=martin.kepplinger@puri.sm \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.