From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Shujun Wang <wsj20369@163.com>
Cc: mani@kernel.org, hemantk@codeaurora.org, loic.poulain@linaro.org,
jarvis.w.jiang@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND,v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
Date: Mon, 17 May 2021 11:01:10 -0700 [thread overview]
Message-ID: <88d7754c381ba9eb927b4dd91e30ca35@codeaurora.org> (raw)
In-Reply-To: <20210517095415.3626-1-wsj20369@163.com>
On 2021-05-17 02:54 AM, Shujun Wang wrote:
> From: Jarvis Jiang <jarvis.w.jiang@gmail.com>
>
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very
> useful
> for debugging modem
>
> Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175
> support")
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
> Signed-off-by: Shujun Wang <wsj20369@163.com>
Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
>
> v2: Add: Fixes: aac426562f56
>
> drivers/bus/mhi/pci_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c
> b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config
> mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-05-17 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 9:54 [PATCH RESEND,v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Shujun Wang
2021-05-17 18:01 ` Bhaumik Bhatt [this message]
2021-05-20 11:16 ` Shujun Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d7754c381ba9eb927b4dd91e30ca35@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jarvis.w.jiang@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=wsj20369@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.