From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oscar Mateo <oscar.mateo@intel.com>
Subject: Re: [PATCH v2] drm/i915: Sanitize GuC client
	initialization
Date: Thu, 16 Feb 2017 02:50:06 -0800
Message-ID: <88dc1f33-d15e-6492-2b09-9a6cd27a9336@intel.com>
References: <1487080386-16022-1-git-send-email-joonas.lahtinen@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C71D56E2D2
 for <intel-gfx@lists.freedesktop.org>; Thu, 16 Feb 2017 18:49:59 +0000 (UTC)
In-Reply-To: <1487080386-16022-1-git-send-email-joonas.lahtinen@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

CgpPbiAwMi8xNC8yMDE3IDA1OjUzIEFNLCBKb29uYXMgTGFodGluZW4gd3JvdGU6Cj4gU3RhcnRl
ZCBhZGRpbmcgcHJvcGVyIHRlYXJkb3duIHRvIGd1Y19jbGllbnRfYWxsb2MsIGVuZGVkIHVwIHJl
bW92aW5nCj4gcXVpdGUgYSBmZXcgZGVhZCBlbmRzIHdoZXJlIGVycm9ycyBjb21tdW5pY2F0aW5n
IHdpdGggdGhlIEd1QyB3ZXJlCj4gc2lsZW50bHkgaWdub3JlZC4gVGhlcmUgYWxzbyBzZWVtZWQg
dG8gYmUgcXVpdGUgYSBmZXcgZXJyb25vdXMKPiB0ZWFyZG93biBhY3Rpb25zIHBlcmZvcm1lZCBp
biBjYXNlIG9mIGFuIGVycm9yIChvcmRlcmluZyB3cm9uZykuCj4KPiB2MjoKPiAJLSBJbmNyZWFz
ZSBmdW5jdGlvbiBzeW1tZXRyeS9wcm94aW1pdHkgKE1pY2hhbC9EYW5pZWxlKQo+IAktIEZpeCBf
X3Jlc2VydmVfZG9vcmJlbGwgYWNjb3VudGluZyBmb3IgaGlnaCBwcmlvcml0eSAoRGFuaWVsZSkK
PiAJLSBDYWxsIF9fdXBkYXRlX2Rvb3JiZWxsX2Rlc2MhIChEYW5pZWxlKQo+IAktIElzb2xhdGUg
X19ndWNfeyxkZX1hbGxvY2F0ZV9kb29yYmVsbCAoTWljaGFsL0RhbmllbGUpCj4KPiBTaWduZWQt
b2ZmLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+
Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENj
OiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+Cj4gQ2M6IE9zY2Fy
IE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0
a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls
c29uLmNvLnVrPgo+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9z
cHVyaW9AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1
Z2ZzLmMgICAgICAgIHwgICA0ICstCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19z
dWJtaXNzaW9uLmMgfCAzNzEgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19md2lmLmggICAgICB8ICAgNCArLQo+ICAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuaCAgICAgICAgICAgIHwgIDExICstCj4gICA0IGZpbGVz
IGNoYW5nZWQsIDIxNSBpbnNlcnRpb25zKCspLCAxNzUgZGVsZXRpb25zKC0pCjxTTklQPgo+ICAg
Cj4gICAJLyoKPiAgIAkgKiBTaW5jZSB0aGUgZG9vcmJlbGwgb25seSByZXF1aXJlcyBhIHNpbmds
ZSBjYWNoZWxpbmUsIHdlIGNhbiBzYXZlCj4gQEAgLTc1MywyNyArNzgxLDM1IEBAIGd1Y19jbGll
bnRfYWxsb2Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCWd1Y19wcm9j
X2Rlc2NfaW5pdChndWMsIGNsaWVudCk7Cj4gICAJZ3VjX2N0eF9kZXNjX2luaXQoZ3VjLCBjbGll
bnQpOwo+IC0JLyogRm9yIHJ1bnRpbWUgY2xpZW50IGFsbG9jYXRpb24gd2UgbmVlZCB0byBlbmFi
bGUgdGhlIGRvb3JiZWxsLiBOb3QKPiAtCSAqIHJlcXVpcmVkIHlldCBmb3IgdGhlIHN0YXRpYyBl
eGVjYnVmX2NsaWVudCBhcyB0aGlzIHNwZWNpYWwga2VybmVsCj4gLQkgKiBjbGllbnQgaXMgZW5h
YmxlZCBmcm9tIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKCkuCj4gLQkgKgo+IC0JICogZ3Vj
X3VwZGF0ZV9kb29yYmVsbF9pZChndWMsIGNsaWVudCwgZGJfaWQpOwo+IC0JICovCj4gKwkvKiBG
b3IgcnVudGltZSBjbGllbnQgYWxsb2NhdGlvbiB3ZSBuZWVkIHRvIGVuYWJsZSB0aGUgZG9vcmJl
bGwuICovCj4gKwlyZXQgPSBfX3VwZGF0ZV9kb29yYmVsbF9kZXNjKGNsaWVudCwgY2xpZW50LT5k
b29yYmVsbF9pZCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gZXJyX3ZhZGRyOwo+ICsKPiArCXJl
dCA9IF9fY3JlYXRlX2Rvb3JiZWxsKGNsaWVudCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gZXJy
X2RiOwpBdCB0aGlzIHBvaW50LCBjbGllbnQtPmRvb3JiZWxsX2lkIGlzIHN0aWxsIGludmFsaWQg
KF9fcmVzZXJ2ZV9kb29yYmVsbCAKaXMgbm90IGNhbGxlZCB1bnRpbCBsYXRlciBmcm9tIGd1Y19p
bml0X2Rvb3JiZWxsX2h3KSwgc28gdGhlIApfX2NyZWF0ZV9kb29yYmVsbCBmYWlscyAoYW5kIGZy
b20gdGhlcmUsIHRoZSB3aG9sZSB0aGluZyBmYWxscyBvdmVyOiBzZWUgCm15IG5leHQgY29tbWVu
dCBiZWxvdykuIENJLkJBVCBkaWRuJ3QgY2F0Y2ggaXQgYmVjYXVzZSBHdUMgaXMgZGlzYWJsZWQg
CmJ5IGRlZmF1bHQuCgo+ICAgCURSTV9ERUJVR19EUklWRVIoIm5ldyBwcmlvcml0eSAldSBjbGll
bnQgJXAgZm9yIGVuZ2luZShzKSAweCV4OiBjdHhfaW5kZXggJXVcbiIsCj4gLQkJcHJpb3JpdHks
IGNsaWVudCwgY2xpZW50LT5lbmdpbmVzLCBjbGllbnQtPmN0eF9pbmRleCk7Cj4gLQlEUk1fREVC
VUdfRFJJVkVSKCJkb29yYmVsbCBpZCAldSwgY2FjaGVsaW5lIG9mZnNldCAweCV4XG4iLAo+IC0J
CWNsaWVudC0+ZG9vcmJlbGxfaWQsIGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0KTsKPiArCQkJIHBy
aW9yaXR5LCBjbGllbnQsIGNsaWVudC0+ZW5naW5lcywgY2xpZW50LT5jdHhfaW5kZXgpOwo+ICsJ
RFJNX0RFQlVHX0RSSVZFUigiZG9vcmJlbGwgaWQgJXUsIGNhY2hlbGluZSBvZmZzZXQgMHglbHhc
biIsCj4gKwkJCSBjbGllbnQtPmRvb3JiZWxsX2lkLCBjbGllbnQtPmRvb3JiZWxsX29mZnNldCk7
Cj4gICAKPiAgIAlyZXR1cm4gY2xpZW50Owo+ICtlcnJfZGI6Cj4gKwlfX3VwZGF0ZV9kb29yYmVs
bF9kZXNjKGNsaWVudCwgR1VDX0RPT1JCRUxMX0lOVkFMSUQpOwo+ICtlcnJfdmFkZHI6Cj4gKwlp
OTE1X2dlbV9vYmplY3RfdW5waW5fbWFwKGNsaWVudC0+dm1hLT5vYmopOwo+ICtlcnJfdm1hOgo+
ICsJaTkxNV92bWFfdW5waW5fYW5kX3JlbGVhc2UoJmNsaWVudC0+dm1hKTsKPiArZXJyX2lkOgo+
ICsJaWRhX3NpbXBsZV9yZW1vdmUoJmd1Yy0+Y3R4X2lkcywgY2xpZW50LT5jdHhfaW5kZXgpOwo+
ICtlcnJfY2xpZW50Ogo+ICsJa2ZyZWUoY2xpZW50KTsKPiAgIAo+IC1lcnI6Cj4gLQlndWNfY2xp
ZW50X2ZyZWUoZGV2X3ByaXYsIGNsaWVudCk7Cj4gLQlyZXR1cm4gTlVMTDsKPiArCXJldHVybiBF
UlJfUFRSKHJldCk7Cj4gICB9Cj4KSSBrbm93IHlvdSBhcmUgbGVhdmluZyBpOTE1X2d1Y19zdWJt
aXNzaW9uX2luaXQgdG8gbWUsIGJ1dCB0aGlzIHBhdGNoIApzaG91bGQgYXMgYSBtaW5pbXVtIGNo
ZWNrIHRoZSByZXR1cm4gY29kZSBmcm9tIGd1Y19jbGllbnRfYWxsb2MsIApvdGhlcndpc2Ugd2Ug
bWlnaHQgZW5kIHVwIHdpdGggYW4gaW52YWxpZCBndWMtPmV4ZWNidWZfY2xpZW50IHdpdGhvdXQg
Cm5vdGljaW5nLgoKU29tZXRoaW5nIGxpa2UgdGhpcyBzaG91bGQgc3VmZmljZSwgYW5kIEkgY2Fu
IHRha2UgaXQgZnJvbSB0aGVyZToKCkBAIC05MzksNyArOTM5LDcgQEAgaW50IGk5MTVfZ3VjX3N1
Ym1pc3Npb25faW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAKKmRldl9wcml2KQpJTlRFTF9J
TkZPKGRldl9wcml2KS0+cmluZ19tYXNrLApHVUNfQ1RYX1BSSU9SSVRZX0tNRF9OT1JNQUwsCmRl
dl9wcml2LT5rZXJuZWxfY29udGV4dCk7Ci0gICAgICAgaWYgKCFndWMtPmV4ZWNidWZfY2xpZW50
KSB7CisgICAgICAgaWYgKElTX0VSUihndWMtPmV4ZWNidWZfY2xpZW50KSkgewogICAgICAgICAg
ICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBHdUMgY2xpZW50IGZvciBleGVjYnVm
IVxuIik7CiAgICAgICAgICAgICAgICAgZ290byBlcnI7CiAgICAgICAgIH0KQEAgLTEwMTYsMTAg
KzEwMTYsOCBAQCB2b2lkIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShzdHJ1Y3QgCmRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2KQogICAgICAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGll
bnQ7CgogICAgICAgICBjbGllbnQgPSBmZXRjaF9hbmRfemVybygmZ3VjLT5leGVjYnVmX2NsaWVu
dCk7Ci0gICAgICAgaWYgKCFjbGllbnQpCi0gICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAg
ICBndWNfY2xpZW50X2ZyZWUoY2xpZW50KTsKKyAgICAgICBpZiAoY2xpZW50ICYmICFJU19FUlIo
Y2xpZW50KSkKKyAgICAgICAgICAgICAgIGd1Y19jbGllbnRfZnJlZShjbGllbnQpOwoKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp
bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==