All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Luis Henriques <lhenriques@suse.de>, Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ceph: add ceph.caps vxattr
Date: Tue, 24 Nov 2020 08:09:12 -0500	[thread overview]
Message-ID: <890e73cac81113e5958a39789fa119b7437bb191.camel@kernel.org> (raw)
In-Reply-To: <20201123173846.15045-1-lhenriques@suse.de>

On Mon, 2020-11-23 at 17:38 +0000, Luis Henriques wrote:
> Add a new vxattr that allows userspace to list the caps for a specific
> directory or file.
> 
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
> Hi!
> 
> Here's a version that also shows the caps in hexadecimal format, as
> suggested by Jeff.  IMO the parenthesis and the '0x' prefix help the
> readability, but they may make it a bit harder for scripts to parsing the
> output.  I'm OK dropping those.
> 
> Cheers,

Looks good, merged into "testing".

I did make a slight change to the format -- instead of putting the hex
value in parenthesis, I separated the two fields with a /, which I think
should make things easier for scripts to parse.

You should be able to do something like this to get at the hex value for
testing:

    $ getfattr -n ceph.caps foo | cut -d / -f2

Let me know if you see issues with that and we can revisit the format.

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>


  reply	other threads:[~2020-11-24 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 14:53 [RFC PATCH] ceph: add ceph.caps vxattr Luis Henriques
2020-11-23 15:17 ` Jeff Layton
2020-11-23 16:43 ` Jeff Layton
2020-11-23 17:38   ` [PATCH v2] " Luis Henriques
2020-11-24 13:09     ` Jeff Layton [this message]
2020-11-24 13:15       ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=890e73cac81113e5958a39789fa119b7437bb191.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=lhenriques@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.