From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9FBC433F5 for ; Sun, 27 Feb 2022 21:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbiB0V2g (ORCPT ); Sun, 27 Feb 2022 16:28:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiB0V2d (ORCPT ); Sun, 27 Feb 2022 16:28:33 -0500 X-Greylist: delayed 8971 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 27 Feb 2022 13:27:55 PST Received: from 6.mo552.mail-out.ovh.net (6.mo552.mail-out.ovh.net [188.165.49.222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CC313F79 for ; Sun, 27 Feb 2022 13:27:55 -0800 (PST) Received: from mxplan5.mail.ovh.net (unknown [10.109.143.118]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id E30F222C9F; Sun, 27 Feb 2022 21:27:53 +0000 (UTC) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Sun, 27 Feb 2022 22:27:52 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-103G005bd4da659-6e74-42ae-98f4-7b2406606e6c, 949565DF20DEE76D4A77FF7731A75FE8B07B1F6B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <890fce14-8001-74c9-21a9-0de117e743ef@kaod.org> Date: Sun, 27 Feb 2022 22:27:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 08/10] spi: aspeed: Calibrate read timings Content-Language: en-US To: Pratyush Yadav CC: , , Mark Brown , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , Rob Herring , , References: <20220214094231.3753686-1-clg@kaod.org> <20220214094231.3753686-9-clg@kaod.org> <20220225091809.gvup3mcst45szi6x@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220225091809.gvup3mcst45szi6x@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 9a51f072-26f3-48de-b05f-06cdd16eb070 X-Ovh-Tracer-Id: 17066672266216704900 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgddugeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepudetudefueeffedvjeeiieffleegtefgledthfelueevieetgeekuedvffdtteehnecuffhomhgrihhnpehoiihlrggsshdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/22 10:18, Pratyush Yadav wrote: > On 14/02/22 10:42AM, Cédric Le Goater wrote: >> To accommodate the different response time of SPI transfers on different >> boards and different SPI NOR devices, the Aspeed controllers provide a >> set of Read Timing Compensation registers to tune the timing delays >> depending on the frequency being used. The AST2600 SoC has one of >> these registers per device. On the AST2500 and AST2400 SoCs, the >> timing register is shared by all devices which is a bit problematic to >> get good results other than for one device. >> >> The algorithm first reads a golden buffer at low speed and then performs >> reads with different clocks and delay cycle settings to find a breaking >> point. This selects a default good frequency for the CEx control register. >> The current settings are bit optimistic as we pick the first delay giving >> good results. A safer approach would be to determine an interval and >> choose the middle value. >> >> Due to the lack of API, calibration is performed when the direct mapping >> for reads is created. > > The dirmap_create mapping says nothing about _when_ it should be called. > So there is no guarantee that it will only be called after the flash is > fully initialized. spi_nor_create_read_dirmap() is called after spi_nor_scan() in spi_nor_probe(). Since a spi_mem_dirmap_info descriptor is created using the nor fields : struct spi_mem_dirmap_info info = { .op_tmpl = SPI_MEM_OP(SPI_MEM_OP_CMD(nor->read_opcode, 0), SPI_MEM_OP_ADDR(nor->addr_width, 0, 0), SPI_MEM_OP_DUMMY(nor->read_dummy, 0), SPI_MEM_OP_DATA_IN(0, NULL, 0)), .offset = 0, .length = nor->params->size, }; struct spi_mem_op *op = &info.op_tmpl; the spi-mem framework makes the assumption that the nor object is initialized. > I suggest you either make this a requirement of the API, how ? Thanks, C. > or create a new API that guarantees it will only be called after > the flash is initialized, like [0]. > > [0] https://patchwork.ozlabs.org/project/linux-mtd/patch/20210311191216.7363-2-p.yadav@ti.com/ > >> >> Cc: Pratyush Yadav >> Signed-off-by: Cédric Le Goater >> --- > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FB38C433EF for ; Sun, 27 Feb 2022 21:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3Ovp9B/Jb3n8aIa1BoCZ48LtyB5LYSlSHROJ1zTpCIc=; b=vbHnBQQgh2LljZ u8N/fZ9l1gUh41qypgOJ7sbJxfLKe8alZoRS5CpABn1cfWw1EsRRmSC6LW3Y8PIpv8Wkpo53DQvvW uqVfwbkvOV+D0/m+OAVPT9pTWj0+b8ddgbHT10NfRHChpsYRwqNuy7wjoi8Lwq0hADCme+zu9r7tp 1q3ScY4YwnJot20M5Y6a2KHuc3REq8u273IJK43ruHb7tGOnC0wHrr7Rfa7Am56spLXRBoAP1Sf98 C9VYrf3wmDH4C/TiWVXNJtQp681bDDyZ8tVUEzZYEkPsSsO17mV5MxJDXNAYioWWcqpcwOfEQbKhp Cxua840WrBjGg0ePawpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOR5E-00AEdk-3r; Sun, 27 Feb 2022 21:28:00 +0000 Received: from 8.mo552.mail-out.ovh.net ([46.105.37.156]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOR5A-00AEd7-Vy for linux-mtd@lists.infradead.org; Sun, 27 Feb 2022 21:27:59 +0000 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.118]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id E30F222C9F; Sun, 27 Feb 2022 21:27:53 +0000 (UTC) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Sun, 27 Feb 2022 22:27:52 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-103G005bd4da659-6e74-42ae-98f4-7b2406606e6c, 949565DF20DEE76D4A77FF7731A75FE8B07B1F6B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <890fce14-8001-74c9-21a9-0de117e743ef@kaod.org> Date: Sun, 27 Feb 2022 22:27:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 08/10] spi: aspeed: Calibrate read timings Content-Language: en-US To: Pratyush Yadav CC: , , Mark Brown , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , Rob Herring , , References: <20220214094231.3753686-1-clg@kaod.org> <20220214094231.3753686-9-clg@kaod.org> <20220225091809.gvup3mcst45szi6x@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220225091809.gvup3mcst45szi6x@ti.com> X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 9a51f072-26f3-48de-b05f-06cdd16eb070 X-Ovh-Tracer-Id: 17066672266216704900 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgddugeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepudetudefueeffedvjeeiieffleegtefgledthfelueevieetgeekuedvffdtteehnecuffhomhgrihhnpehoiihlrggsshdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220227_132757_384168_4A23557B X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMi8yNS8yMiAxMDoxOCwgUHJhdHl1c2ggWWFkYXYgd3JvdGU6Cj4gT24gMTQvMDIvMjIgMTA6 NDJBTSwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4+IFRvIGFjY29tbW9kYXRlIHRoZSBkaWZm ZXJlbnQgcmVzcG9uc2UgdGltZSBvZiBTUEkgdHJhbnNmZXJzIG9uIGRpZmZlcmVudAo+PiBib2Fy ZHMgYW5kIGRpZmZlcmVudCBTUEkgTk9SIGRldmljZXMsIHRoZSBBc3BlZWQgY29udHJvbGxlcnMg cHJvdmlkZSBhCj4+IHNldCBvZiBSZWFkIFRpbWluZyBDb21wZW5zYXRpb24gcmVnaXN0ZXJzIHRv IHR1bmUgdGhlIHRpbWluZyBkZWxheXMKPj4gZGVwZW5kaW5nIG9uIHRoZSBmcmVxdWVuY3kgYmVp bmcgdXNlZC4gVGhlIEFTVDI2MDAgU29DIGhhcyBvbmUgb2YKPj4gdGhlc2UgcmVnaXN0ZXJzIHBl ciBkZXZpY2UuIE9uIHRoZSBBU1QyNTAwIGFuZCBBU1QyNDAwIFNvQ3MsIHRoZQo+PiB0aW1pbmcg cmVnaXN0ZXIgaXMgc2hhcmVkIGJ5IGFsbCBkZXZpY2VzIHdoaWNoIGlzIGEgYml0IHByb2JsZW1h dGljIHRvCj4+IGdldCBnb29kIHJlc3VsdHMgb3RoZXIgdGhhbiBmb3Igb25lIGRldmljZS4KPj4K Pj4gVGhlIGFsZ29yaXRobSBmaXJzdCByZWFkcyBhIGdvbGRlbiBidWZmZXIgYXQgbG93IHNwZWVk IGFuZCB0aGVuIHBlcmZvcm1zCj4+IHJlYWRzIHdpdGggZGlmZmVyZW50IGNsb2NrcyBhbmQgZGVs YXkgY3ljbGUgc2V0dGluZ3MgdG8gZmluZCBhIGJyZWFraW5nCj4+IHBvaW50LiBUaGlzIHNlbGVj dHMgYSBkZWZhdWx0IGdvb2QgZnJlcXVlbmN5IGZvciB0aGUgQ0V4IGNvbnRyb2wgcmVnaXN0ZXIu Cj4+IFRoZSBjdXJyZW50IHNldHRpbmdzIGFyZSBiaXQgb3B0aW1pc3RpYyBhcyB3ZSBwaWNrIHRo ZSBmaXJzdCBkZWxheSBnaXZpbmcKPj4gZ29vZCByZXN1bHRzLiBBIHNhZmVyIGFwcHJvYWNoIHdv dWxkIGJlIHRvIGRldGVybWluZSBhbiBpbnRlcnZhbCBhbmQKPj4gY2hvb3NlIHRoZSBtaWRkbGUg dmFsdWUuCj4+Cj4+IER1ZSB0byB0aGUgbGFjayBvZiBBUEksIGNhbGlicmF0aW9uIGlzIHBlcmZv cm1lZCB3aGVuIHRoZSBkaXJlY3QgbWFwcGluZwo+PiBmb3IgcmVhZHMgaXMgY3JlYXRlZC4KPiAK PiBUaGUgZGlybWFwX2NyZWF0ZSBtYXBwaW5nIHNheXMgbm90aGluZyBhYm91dCBfd2hlbl8gaXQg c2hvdWxkIGJlIGNhbGxlZC4KPiBTbyB0aGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBpdCB3aWxs IG9ubHkgYmUgY2FsbGVkIGFmdGVyIHRoZSBmbGFzaCBpcwo+IGZ1bGx5IGluaXRpYWxpemVkLiAK CnNwaV9ub3JfY3JlYXRlX3JlYWRfZGlybWFwKCkgaXMgY2FsbGVkIGFmdGVyIHNwaV9ub3Jfc2Nh bigpIGluIHNwaV9ub3JfcHJvYmUoKS4KU2luY2UgYSBzcGlfbWVtX2Rpcm1hcF9pbmZvIGRlc2Ny aXB0b3IgaXMgY3JlYXRlZCB1c2luZyB0aGUgbm9yIGZpZWxkcyA6CgoJc3RydWN0IHNwaV9tZW1f ZGlybWFwX2luZm8gaW5mbyA9IHsKCQkub3BfdG1wbCA9IFNQSV9NRU1fT1AoU1BJX01FTV9PUF9D TUQobm9yLT5yZWFkX29wY29kZSwgMCksCgkJCQkgICAgICBTUElfTUVNX09QX0FERFIobm9yLT5h ZGRyX3dpZHRoLCAwLCAwKSwKCQkJCSAgICAgIFNQSV9NRU1fT1BfRFVNTVkobm9yLT5yZWFkX2R1 bW15LCAwKSwKCQkJCSAgICAgIFNQSV9NRU1fT1BfREFUQV9JTigwLCBOVUxMLCAwKSksCgkJLm9m ZnNldCA9IDAsCgkJLmxlbmd0aCA9IG5vci0+cGFyYW1zLT5zaXplLAoJfTsKCXN0cnVjdCBzcGlf bWVtX29wICpvcCA9ICZpbmZvLm9wX3RtcGw7Cgp0aGUgc3BpLW1lbSBmcmFtZXdvcmsgbWFrZXMg dGhlIGFzc3VtcHRpb24gdGhhdCB0aGUgbm9yIG9iamVjdCBpcyBpbml0aWFsaXplZC4KCj4gSSBz dWdnZXN0IHlvdSBlaXRoZXIgbWFrZSB0aGlzIGEgcmVxdWlyZW1lbnQgb2YgdGhlIEFQSSwKCmhv dyA/CgpUaGFua3MsCgpDLgoKCj4gb3IgY3JlYXRlIGEgbmV3IEFQSSB0aGF0IGd1YXJhbnRlZXMg aXQgd2lsbCBvbmx5IGJlIGNhbGxlZCBhZnRlcgo+IHRoZSBmbGFzaCBpcyBpbml0aWFsaXplZCwg bGlrZSBbMF0uCj4gCj4gWzBdIGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcHJvamVjdC9s aW51eC1tdGQvcGF0Y2gvMjAyMTAzMTExOTEyMTYuNzM2My0yLXAueWFkYXZAdGkuY29tLwo+IAo+ Pgo+PiBDYzogUHJhdHl1c2ggWWFkYXYgPHAueWFkYXZAdGkuY29tPgo+PiBTaWduZWQtb2ZmLWJ5 OiBDw6lkcmljIExlIEdvYXRlciA8Y2xnQGthb2Qub3JnPgo+PiAtLS0KPiAKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRp c2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEDA3C433EF for ; Sun, 27 Feb 2022 21:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xISoU7jsJolCttLfLwwQhgqoSysqG9X16P2AxxnhRVg=; b=Hrylx5RKoBCFyM K6lKPAwVyHkUGKXlRaAnmywmBEsXxz5oqRAre1HGHucTsJiGhE2oW7wnYKZkNjPx4g1Rf2s3idCwf ydYOCjQBfc63zpnIqJwd4XeojMpIhnFG9nOwGRSznorivyvruuc6fWdAMWqFQMcMvScTC2qlEPRrG trclzzgUcxOiLj4Ugpve1TbDC+OaMgWFDaT96LA85O/jaJWGrQzXixMhdPivZnep2dbqBtAjIqkas izRdSWzWQbBWdDDQrbq9I+eFfVv8jPpfe5f2P6ZODL+k4vdUfTdB2S15hvGZj6K9Ud/ZxBnRLu8OX Y2Y9AtCkC2kUBVNBwGkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOR5P-00AEel-EC; Sun, 27 Feb 2022 21:28:11 +0000 Received: from 6.mo552.mail-out.ovh.net ([188.165.49.222]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOR5A-00AEd6-Vz for linux-arm-kernel@lists.infradead.org; Sun, 27 Feb 2022 21:27:59 +0000 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.118]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id E30F222C9F; Sun, 27 Feb 2022 21:27:53 +0000 (UTC) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Sun, 27 Feb 2022 22:27:52 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-103G005bd4da659-6e74-42ae-98f4-7b2406606e6c, 949565DF20DEE76D4A77FF7731A75FE8B07B1F6B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <890fce14-8001-74c9-21a9-0de117e743ef@kaod.org> Date: Sun, 27 Feb 2022 22:27:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 08/10] spi: aspeed: Calibrate read timings Content-Language: en-US To: Pratyush Yadav CC: , , Mark Brown , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , Rob Herring , , References: <20220214094231.3753686-1-clg@kaod.org> <20220214094231.3753686-9-clg@kaod.org> <20220225091809.gvup3mcst45szi6x@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220225091809.gvup3mcst45szi6x@ti.com> X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 9a51f072-26f3-48de-b05f-06cdd16eb070 X-Ovh-Tracer-Id: 17066672266216704900 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgddugeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepudetudefueeffedvjeeiieffleegtefgledthfelueevieetgeekuedvffdtteehnecuffhomhgrihhnpehoiihlrggsshdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220227_132757_384380_BEE98BCE X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMi8yNS8yMiAxMDoxOCwgUHJhdHl1c2ggWWFkYXYgd3JvdGU6Cj4gT24gMTQvMDIvMjIgMTA6 NDJBTSwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4+IFRvIGFjY29tbW9kYXRlIHRoZSBkaWZm ZXJlbnQgcmVzcG9uc2UgdGltZSBvZiBTUEkgdHJhbnNmZXJzIG9uIGRpZmZlcmVudAo+PiBib2Fy ZHMgYW5kIGRpZmZlcmVudCBTUEkgTk9SIGRldmljZXMsIHRoZSBBc3BlZWQgY29udHJvbGxlcnMg cHJvdmlkZSBhCj4+IHNldCBvZiBSZWFkIFRpbWluZyBDb21wZW5zYXRpb24gcmVnaXN0ZXJzIHRv IHR1bmUgdGhlIHRpbWluZyBkZWxheXMKPj4gZGVwZW5kaW5nIG9uIHRoZSBmcmVxdWVuY3kgYmVp bmcgdXNlZC4gVGhlIEFTVDI2MDAgU29DIGhhcyBvbmUgb2YKPj4gdGhlc2UgcmVnaXN0ZXJzIHBl ciBkZXZpY2UuIE9uIHRoZSBBU1QyNTAwIGFuZCBBU1QyNDAwIFNvQ3MsIHRoZQo+PiB0aW1pbmcg cmVnaXN0ZXIgaXMgc2hhcmVkIGJ5IGFsbCBkZXZpY2VzIHdoaWNoIGlzIGEgYml0IHByb2JsZW1h dGljIHRvCj4+IGdldCBnb29kIHJlc3VsdHMgb3RoZXIgdGhhbiBmb3Igb25lIGRldmljZS4KPj4K Pj4gVGhlIGFsZ29yaXRobSBmaXJzdCByZWFkcyBhIGdvbGRlbiBidWZmZXIgYXQgbG93IHNwZWVk IGFuZCB0aGVuIHBlcmZvcm1zCj4+IHJlYWRzIHdpdGggZGlmZmVyZW50IGNsb2NrcyBhbmQgZGVs YXkgY3ljbGUgc2V0dGluZ3MgdG8gZmluZCBhIGJyZWFraW5nCj4+IHBvaW50LiBUaGlzIHNlbGVj dHMgYSBkZWZhdWx0IGdvb2QgZnJlcXVlbmN5IGZvciB0aGUgQ0V4IGNvbnRyb2wgcmVnaXN0ZXIu Cj4+IFRoZSBjdXJyZW50IHNldHRpbmdzIGFyZSBiaXQgb3B0aW1pc3RpYyBhcyB3ZSBwaWNrIHRo ZSBmaXJzdCBkZWxheSBnaXZpbmcKPj4gZ29vZCByZXN1bHRzLiBBIHNhZmVyIGFwcHJvYWNoIHdv dWxkIGJlIHRvIGRldGVybWluZSBhbiBpbnRlcnZhbCBhbmQKPj4gY2hvb3NlIHRoZSBtaWRkbGUg dmFsdWUuCj4+Cj4+IER1ZSB0byB0aGUgbGFjayBvZiBBUEksIGNhbGlicmF0aW9uIGlzIHBlcmZv cm1lZCB3aGVuIHRoZSBkaXJlY3QgbWFwcGluZwo+PiBmb3IgcmVhZHMgaXMgY3JlYXRlZC4KPiAK PiBUaGUgZGlybWFwX2NyZWF0ZSBtYXBwaW5nIHNheXMgbm90aGluZyBhYm91dCBfd2hlbl8gaXQg c2hvdWxkIGJlIGNhbGxlZC4KPiBTbyB0aGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBpdCB3aWxs IG9ubHkgYmUgY2FsbGVkIGFmdGVyIHRoZSBmbGFzaCBpcwo+IGZ1bGx5IGluaXRpYWxpemVkLiAK CnNwaV9ub3JfY3JlYXRlX3JlYWRfZGlybWFwKCkgaXMgY2FsbGVkIGFmdGVyIHNwaV9ub3Jfc2Nh bigpIGluIHNwaV9ub3JfcHJvYmUoKS4KU2luY2UgYSBzcGlfbWVtX2Rpcm1hcF9pbmZvIGRlc2Ny aXB0b3IgaXMgY3JlYXRlZCB1c2luZyB0aGUgbm9yIGZpZWxkcyA6CgoJc3RydWN0IHNwaV9tZW1f ZGlybWFwX2luZm8gaW5mbyA9IHsKCQkub3BfdG1wbCA9IFNQSV9NRU1fT1AoU1BJX01FTV9PUF9D TUQobm9yLT5yZWFkX29wY29kZSwgMCksCgkJCQkgICAgICBTUElfTUVNX09QX0FERFIobm9yLT5h ZGRyX3dpZHRoLCAwLCAwKSwKCQkJCSAgICAgIFNQSV9NRU1fT1BfRFVNTVkobm9yLT5yZWFkX2R1 bW15LCAwKSwKCQkJCSAgICAgIFNQSV9NRU1fT1BfREFUQV9JTigwLCBOVUxMLCAwKSksCgkJLm9m ZnNldCA9IDAsCgkJLmxlbmd0aCA9IG5vci0+cGFyYW1zLT5zaXplLAoJfTsKCXN0cnVjdCBzcGlf bWVtX29wICpvcCA9ICZpbmZvLm9wX3RtcGw7Cgp0aGUgc3BpLW1lbSBmcmFtZXdvcmsgbWFrZXMg dGhlIGFzc3VtcHRpb24gdGhhdCB0aGUgbm9yIG9iamVjdCBpcyBpbml0aWFsaXplZC4KCj4gSSBz dWdnZXN0IHlvdSBlaXRoZXIgbWFrZSB0aGlzIGEgcmVxdWlyZW1lbnQgb2YgdGhlIEFQSSwKCmhv dyA/CgpUaGFua3MsCgpDLgoKCj4gb3IgY3JlYXRlIGEgbmV3IEFQSSB0aGF0IGd1YXJhbnRlZXMg aXQgd2lsbCBvbmx5IGJlIGNhbGxlZCBhZnRlcgo+IHRoZSBmbGFzaCBpcyBpbml0aWFsaXplZCwg bGlrZSBbMF0uCj4gCj4gWzBdIGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcHJvamVjdC9s aW51eC1tdGQvcGF0Y2gvMjAyMTAzMTExOTEyMTYuNzM2My0yLXAueWFkYXZAdGkuY29tLwo+IAo+ Pgo+PiBDYzogUHJhdHl1c2ggWWFkYXYgPHAueWFkYXZAdGkuY29tPgo+PiBTaWduZWQtb2ZmLWJ5 OiBDw6lkcmljIExlIEdvYXRlciA8Y2xnQGthb2Qub3JnPgo+PiAtLS0KPiAKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==