From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUd3Z-0006Q0-UU for qemu-devel@nongnu.org; Tue, 02 Aug 2016 13:00:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUd3U-0002ha-UN for qemu-devel@nongnu.org; Tue, 02 Aug 2016 13:00:41 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:35251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUd3U-0002hN-MO for qemu-devel@nongnu.org; Tue, 02 Aug 2016 13:00:36 -0400 Date: Tue, 2 Aug 2016 13:00:35 -0400 (EDT) From: Paolo Bonzini Message-ID: <891632335.13100661.1470157235734.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1470142856-742-1-git-send-email-famz@redhat.com> <1470142856-742-2-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Fam Zheng , qemu-devel@nongnu.org, stefanha@redhat.com > I'd prefer if Paolo's remark (about blk_drain()'s ability to produce > more failed requests, stashed in s->rq) were captured in either the > commit message, or in a code comment. Something like: > > /* We drop queued requests after blk_drain() because blk_drain() > * itself can produce them. */ It's also (perhaps especially) because blk_drain() can consume them. Fam's patch to do blk_drain() first would cause a double-free. Paolo > What do you think? It's your call. I certainly lacked that bit of > information. > > Reviewed-by: Laszlo Ersek > > Thanks! > Laszlo >