From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD2C2C81 for ; Wed, 17 Nov 2021 16:19:56 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id b40so11125067lfv.10 for ; Wed, 17 Nov 2021 08:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=slbKKxQ/rurVnSEI57eisp+SX8JJlPjNvxx5V40UNkE=; b=LPsSelLRXOQ7hXG/tGo1OT5PsrkKtigvlerFF01UNiGw0JbdtWtE7K/cRew90F6eIX 6dgo8N8lCplnzkxHPN8XOh3nzbfLlAlsucENgGpvIu4f5tOCEZ2CwdJj91kOTRiYFmT+ 4hkT/UqDSayWKkllMAjcfAhQqCdMdVQItwOdIXOSZcrUYAFIQ4NYJyDr2Mw8dQamhJVJ 51S3H5wZT7aAP2mpukvg2mtyHnSc+cPvVZzdFYXzRwpXeDxGOvB0xGVWlRCHls1e6FgT CIiLVIkBvpw4Nvvjfqa1IexQaqXU3RChbVEV+Z3nGjCm+u3nlYHqo3Rl+pNkoKzS8BWB 22tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=slbKKxQ/rurVnSEI57eisp+SX8JJlPjNvxx5V40UNkE=; b=7yP7TGcMJtUfLyl0wRSkU4fyWvZbrCym2H66nHbGvG9Cbnkkbyz3290S+WRpqGu+ar +gu1FPTEdLg+Tev8XJtcwIjcreJCtuhyOHL57bmKvflTNqNdYmMU83fpD3bAcl38m6pT 1a4Vm1W1+8TG2gbA9Tc+N/V4KsOFNMw7V8PdjELEQt0RB5PmqJOYXX67YaqVdzEF4B5/ NDZ3GdF+RiwE5u/cDyAB0BAd4Vbd1GBxNsKYdEvlweceNkBjQv0185Vl3Q6R66OYSa5E UwsWu8RdBrJplaFIHHoXk7jRHAyRc6pFixALR+ASRK2PU9yLd3a5Q8woD82Dond8e9Po Npxg== X-Gm-Message-State: AOAM533cCm7SxdvJ0vRSZ8BKjwX+S3aN+N96RtZIiYDLhRRVq+f8Sd0N dG5uceGB8qsZUidlao/gTEg= X-Google-Smtp-Source: ABdhPJyfq1oyCehVK/MehD7wcDla30T+6xOUXDqwqeTSENy6xeLdvMcR4ZoYf1tizTWRd8K1lJ7mmw== X-Received: by 2002:a2e:7216:: with SMTP id n22mr8926810ljc.44.1637165994488; Wed, 17 Nov 2021 08:19:54 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id m11sm32535ljc.108.2021.11.17.08.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Nov 2021 08:19:54 -0800 (PST) Subject: Re: [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking To: Dan Carpenter Cc: Thierry Reding , Jonathan Hunter , Mauro Carvalho Chehab , Greg Kroah-Hartman , Anton Bambura , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211114222353.22435-1-digetx@gmail.com> <20211114222353.22435-2-digetx@gmail.com> <42b24cd0-ac37-3cfe-1fb2-d6292015318a@gmail.com> <20211115124402.GE26989@kadam> <20211115154858.GG27562@kadam> From: Dmitry Osipenko Message-ID: <89166c20-6b05-ed4b-ed45-451f4f1e10bc@gmail.com> Date: Wed, 17 Nov 2021 19:19:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20211115154858.GG27562@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit 15.11.2021 18:48, Dan Carpenter пишет: > On Mon, Nov 15, 2021 at 05:34:47PM +0300, Dmitry Osipenko wrote: >> 15.11.2021 15:44, Dan Carpenter пишет: >>> On Mon, Nov 15, 2021 at 01:34:18AM +0300, Dmitry Osipenko wrote: >>>> 15.11.2021 01:23, Dmitry Osipenko пишет: >>>>> + vde->secure_bo = tegra_vde_alloc_bo(vde, DMA_FROM_DEVICE, 4096); >>>>> + if (!vde->secure_bo) { >>>>> + dev_err(dev, "Failed to allocate secure BO\n"); >>>>> + goto err_pm_runtime; >>>>> + } >>>> >>>> My eye just caught that by accident err variable isn't assigned to >>>> -ENOMEM here. I'll make v2 shortly. >>> >>> Smatch has a check for this so we would have caught it. :) >> >> Whish smatch was built-in into kernel and I could simply run "make >> smatch". On the other hand, I know that you're periodically checking >> upstream with smatch and patching the found bugs, so maybe it's fine >> as-is. > > I run it every day, and it's integrated into the zero day bot and Mauro > runs it. So someone would have caught it. Very nice, I haven't noticed that 0-day runs smatch. I assume the smatch reports from the bots are private to you and Mauro since I never saw them in my inbox and on LKML, correct?