From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4BCC433EF for ; Mon, 20 Jun 2022 00:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237016AbiFTAZv (ORCPT ); Sun, 19 Jun 2022 20:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236560AbiFTAZt (ORCPT ); Sun, 19 Jun 2022 20:25:49 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84688AE4C for ; Sun, 19 Jun 2022 17:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1655684748; x=1687220748; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUSX4iWBZhA=; b=bfIYx02+58JUqR+Lv5qP1Y3SDZ+1DbCdErqHT98/09I2vVdvSpoSiK4b 2sfUk/yqYm7E0o0ku+DKnXa3mVK7e8oqE6/DqjsLFClMw8HqAG02U4j9O 6SPgXeSeKAKwEW4dzzaNU1sk7n/twWt0nDUDG5qLaRp2mkOvUq2e65WC9 ge1IhU7b2z9Lri5B3eNfKcLe40jOgwCuR33FthGDRvdbhapAXh7uOC6bg G3mqTlXfvXWIuqxIJsYUkn2bbkFyKgvifBhgafttZnremlKAWXN6MUCC3 3bGY05qG7LMveBnXF7xferzSTMOuC7G+ug98MXYvv8Nl7sC39EyRge+9L A==; X-IronPort-AV: E=Sophos;i="5.92,306,1650902400"; d="scan'208";a="315672133" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 20 Jun 2022 08:25:47 +0800 IronPort-SDR: pMmkeeyN37i6AGbO7X+Jhmw/CFW4mpRpUU8ZgJwbXn9O/jQjsRa4yV8sMkvfwKMNdJpg3REYyh FLXOlFPkHT0Y1ckglTPGqhXPd3IYcE+hsDUu3M3snStrKrGmtc9SgMnbuXcQZsGGCzFzFxtg7F VOnVD2h8rRbmFohXoLl+nR+TaRwAMm7uaYpk3uDh/7Upx6qFVwRgQVFnX/nxTWjFWflC0rGd8w KL5Ce2GwrDvMlbXI8SMab75zfXUHIliDoq9hzaqJhNkMS5MlMK9mqUIxW1xQoluegFUirlLtq0 BIHI+/m1s+wPSPKM4NfL5i+U Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 16:43:56 -0700 IronPort-SDR: LdganiwAC2sRlKTJtI2XwUe3NPe1UWXjZdeMKR10XEfI/E8JMsVMW3OUbE1C/qnfzXZfjrLASX bIcd8dSCzS89r7Qz+pQnAEveUT83DmJts67TnkIFSIQzhyZ8X8o1m0tJWnFZr4SBDjvdNKlaYl dCy30h+9W7/QriHjHpElQaz6JZbyjWC9Thnk1cmlHQP/NAj9uOa3NV2XN8xQ883gpCIo3+O3ka WnBNPc/BX5jTWSFH+lsMjn+C+MWwJOMOS9bD3ncNWRxni9m7h9AqWuWwF4tOBS58bioVp+6+NR KLw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 17:25:47 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LR9RG2hsZz1SVp4 for ; Sun, 19 Jun 2022 17:25:46 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1655684745; x=1658276746; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUS X4iWBZhA=; b=jiZLlvSxMCZ6FyKEwxTD9KC+yR9WRhcg+KBamtfquRBI7vS8pGJ mBX0zoQMpTkJaMFFdVJnj3t13KHqhbLZ0wxv4yH09WD5zap1Onl7UiZRRPdtTT8q lRpIKFHnIHS6ATDMIB1EBmgVvIKlGPRbTBmO5z1aEaR53EnGopmn8GW5MfYpr+wV dW8obWKceDCrsqysJgrYGk90jld2x82pjjO7GVot8iccx/JpoOjI3x1vD3Avo5Tq 8Z0iZwu+SbCnAqDIHlTu4eXzBK/+zo527aefCY9ZzO+FsC511gbTaO4E5/c48io7 0JzIK6++acSKredsKoDjpGQoBzQrwNc1phQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BSZ2u-ZOKesl for ; Sun, 19 Jun 2022 17:25:45 -0700 (PDT) Received: from [10.225.163.87] (unknown [10.225.163.87]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LR9R75cZsz1Rvlc; Sun, 19 Jun 2022 17:25:39 -0700 (PDT) Message-ID: <891cf74c-ac0a-b380-1d5f-dd7ce5aeda9d@opensource.wdc.com> Date: Mon, 20 Jun 2022 09:25:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node Content-Language: en-US To: Conor.Dooley@microchip.com, mail@conchuod.ie, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com, sam@ravnborg.org, Eugeniy.Paltsev@synopsys.com, vkoul@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, fancer.lancer@gmail.com, daniel.lezcano@linaro.org, palmer@dabbelt.com, palmer@rivosinc.com Cc: tglx@linutronix.de, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, masahiroy@kernel.org, geert@linux-m68k.org, niklas.cassel@wdc.com, dillon.minfei@gmail.com, jee.heng.sia@intel.com, joabreu@synopsys.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220618123035.563070-1-mail@conchuod.ie> <20220618123035.563070-8-mail@conchuod.ie> <9cd60b3b-44fe-62ac-9874-80ae2223d078@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 6/20/22 08:54, Conor.Dooley@microchip.com wrote: > On 20/06/2022 00:38, Damien Le Moal wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 6/18/22 21:30, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> The k210 memory node has a compatible string that does not match with >>> any driver or dt-binding & has several non standard properties. >>> Replace the reg names with a comment and delete the rest. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> --- >>> arch/riscv/boot/dts/canaan/k210.dtsi | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi >>> index 44d338514761..287ea6eebe47 100644 >>> --- a/arch/riscv/boot/dts/canaan/k210.dtsi >>> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi >>> @@ -69,15 +69,9 @@ cpu1_intc: interrupt-controller { >>> >>> sram: memory@80000000 { >>> device_type = "memory"; >>> - compatible = "canaan,k210-sram"; >>> reg = <0x80000000 0x400000>, >>> <0x80400000 0x200000>, >>> <0x80600000 0x200000>; >>> - reg-names = "sram0", "sram1", "aisram"; >>> - clocks = <&sysclk K210_CLK_SRAM0>, >>> - <&sysclk K210_CLK_SRAM1>, >>> - <&sysclk K210_CLK_AI>; >>> - clock-names = "sram0", "sram1", "aisram"; >>> }; >> >> These are used by u-boot to setup the memory clocks and initialize the >> aisram. Sure the kernel actually does not use this, but to be in sync with >> u-boot DT, I would prefer keeping this as is. Right now, u-boot *and* the >> kernel work fine with both u-boot internal DT and the kernel DT. > > Right, but unfortunately that desire alone doesn't do anything about > the dtbs_check complaints. > > I guess the alternative approach of actually documenting the compatible > would be more palatable? Yes, I think so. That would allow keeping the fields without the DTB build warnings. > > Thanks, > Conor. > > > -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC85FC433EF for ; Mon, 20 Jun 2022 00:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1+hXSDU8+4A6RBk9irEJazILVO1vtygNXWCoT6TrJwg=; b=zw1bmBEx+Zg60Q NZw7ZymbA4k/5GFUWoYf2HlcTBNj8zg5EdKKh61LM3OoibmdQAX5g+FwiTt97kwUqgFyUve3vE7Wd lSL4h+tSQmSLA7W+yqVFLf74gHn9U9x5xAl0KhMXQLtBaaxes7m3xwU51KP0vc2kY/ZPMzhUXPOsU XBtgVScm0XDehOHNPjrPcdzLx6u2epIIE/kdD6Pgph2d/KmubvHxX1y8f1cuc+UIiNAW1okv5hAgP KCPHVyJIgmoXpYKaRSBq0vQDeg8sR3RfPkFriXlkIJ/ooLByG01uiIcJTGpWVP7wK22e3pmYIndO+ Z4v8nsDO3tLgNoL5J96A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o35El-00FZ8E-KQ; Mon, 20 Jun 2022 00:25:51 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o35Ej-00FZ7v-7J for linux-riscv@lists.infradead.org; Mon, 20 Jun 2022 00:25:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1655684748; x=1687220748; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUSX4iWBZhA=; b=bfIYx02+58JUqR+Lv5qP1Y3SDZ+1DbCdErqHT98/09I2vVdvSpoSiK4b 2sfUk/yqYm7E0o0ku+DKnXa3mVK7e8oqE6/DqjsLFClMw8HqAG02U4j9O 6SPgXeSeKAKwEW4dzzaNU1sk7n/twWt0nDUDG5qLaRp2mkOvUq2e65WC9 ge1IhU7b2z9Lri5B3eNfKcLe40jOgwCuR33FthGDRvdbhapAXh7uOC6bg G3mqTlXfvXWIuqxIJsYUkn2bbkFyKgvifBhgafttZnremlKAWXN6MUCC3 3bGY05qG7LMveBnXF7xferzSTMOuC7G+ug98MXYvv8Nl7sC39EyRge+9L A==; X-IronPort-AV: E=Sophos;i="5.92,306,1650902400"; d="scan'208";a="202279308" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Jun 2022 08:25:47 +0800 IronPort-SDR: yIYiCHM8NXiUVoYgE3nvTcxY56C9gD1m3M09KfdWKsLPvnIcmOBvKaIOro+GRPzpI+wU8M0R2I D37CPE3IJJrB5mGZxavwxwEhaIV0cls4oK18IWwrMVdqW2HijSMBGywJzmY7MZ9mvJdZ2SsMk2 n0pzeZySsYge4odU1Dm0hXMDU6Euo4QXaJp184Yl0bMsE0bP2mFGJ/yI+7+lxOqvrng8ZJTtQh wC3/eDy6C8PeRZnzo6LTkYXcrBkup/OJTy+S2kG+51DJKb6nxAX+cTgbMJ6maVsOkNTJKUui3W /GEKQIEqD/u0qeaqRruOnG46 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 16:48:19 -0700 IronPort-SDR: Q8HLFwkWQGehk0K4x0grZAloP6Ncis+W8bx8DQAEk2/IlWjivk45di5bmG7K2sK1oLaLXnNA4p TYHJmgt4j0AMrR0hAHLFUKNlkd+9H/9ZF9KLFd9+OENutqO9LP6+RnHtYc7IIGG2H6T0ZyvlLT O7ckneSHE2WlYdS8vO48vmbSs1AeSFii87noGNIzipq2bgxzZjpf7jGmZ41mA+ex1h0Q8luzFt Or44qt/FOwJtADX/qLt2F4G/XL2bne+tOo+PL4aTmlvqsx1NXWZQjUzPqgaXzRp/8FmbgIEoBG NgU= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 17:25:47 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LR9RH2Kx5z1SVp3 for ; Sun, 19 Jun 2022 17:25:47 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1655684746; x=1658276747; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUS X4iWBZhA=; b=C9w0xWLFB/KaDMQ+IzY1oZGaVKgyVSWgQTN/9sJJGaofpjPKWWt ZKKgIMwWS1Dy3N+AKNLls5E2/TsxAp6rP+S9l0Ik2SK7XIV5qtlSHKwhGAwp4LxJ 6gePz+4huJUkrzHySdcijhxdigID+rEmfTDa4Wt/eP1LPIzIGKKw5KxzF3Dtmtap p5Va13Ox1XAtZ0OpzHoWucY1cenLs5OjDloywiS4JT1zdmVBZAj8Mo2U+pX+WsHX Xq2w2dDe0rAcZyAfGZlDDozsM67SwB5DYyhQRX3WWnevylp14JZ8tNudXLaciW4o qUyYE7ltn31FuS+79D85xj771kaXmkpnCiQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Fg3GX1Whu1ni for ; Sun, 19 Jun 2022 17:25:46 -0700 (PDT) Received: from [10.225.163.87] (unknown [10.225.163.87]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LR9R75cZsz1Rvlc; Sun, 19 Jun 2022 17:25:39 -0700 (PDT) Message-ID: <891cf74c-ac0a-b380-1d5f-dd7ce5aeda9d@opensource.wdc.com> Date: Mon, 20 Jun 2022 09:25:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node Content-Language: en-US To: Conor.Dooley@microchip.com, mail@conchuod.ie, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com, sam@ravnborg.org, Eugeniy.Paltsev@synopsys.com, vkoul@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, fancer.lancer@gmail.com, daniel.lezcano@linaro.org, palmer@dabbelt.com, palmer@rivosinc.com Cc: tglx@linutronix.de, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, masahiroy@kernel.org, geert@linux-m68k.org, niklas.cassel@wdc.com, dillon.minfei@gmail.com, jee.heng.sia@intel.com, joabreu@synopsys.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220618123035.563070-1-mail@conchuod.ie> <20220618123035.563070-8-mail@conchuod.ie> <9cd60b3b-44fe-62ac-9874-80ae2223d078@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220619_172549_446384_AA36AC8A X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 6/20/22 08:54, Conor.Dooley@microchip.com wrote: > On 20/06/2022 00:38, Damien Le Moal wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 6/18/22 21:30, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> The k210 memory node has a compatible string that does not match with >>> any driver or dt-binding & has several non standard properties. >>> Replace the reg names with a comment and delete the rest. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> --- >>> arch/riscv/boot/dts/canaan/k210.dtsi | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi >>> index 44d338514761..287ea6eebe47 100644 >>> --- a/arch/riscv/boot/dts/canaan/k210.dtsi >>> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi >>> @@ -69,15 +69,9 @@ cpu1_intc: interrupt-controller { >>> >>> sram: memory@80000000 { >>> device_type = "memory"; >>> - compatible = "canaan,k210-sram"; >>> reg = <0x80000000 0x400000>, >>> <0x80400000 0x200000>, >>> <0x80600000 0x200000>; >>> - reg-names = "sram0", "sram1", "aisram"; >>> - clocks = <&sysclk K210_CLK_SRAM0>, >>> - <&sysclk K210_CLK_SRAM1>, >>> - <&sysclk K210_CLK_AI>; >>> - clock-names = "sram0", "sram1", "aisram"; >>> }; >> >> These are used by u-boot to setup the memory clocks and initialize the >> aisram. Sure the kernel actually does not use this, but to be in sync with >> u-boot DT, I would prefer keeping this as is. Right now, u-boot *and* the >> kernel work fine with both u-boot internal DT and the kernel DT. > > Right, but unfortunately that desire alone doesn't do anything about > the dtbs_check complaints. > > I guess the alternative approach of actually documenting the compatible > would be more palatable? Yes, I think so. That would allow keeping the fields without the DTB build warnings. > > Thanks, > Conor. > > > -- Damien Le Moal Western Digital Research _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A15EEC433EF for ; Mon, 20 Jun 2022 15:09:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E3A4B1884; Mon, 20 Jun 2022 17:08:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E3A4B1884 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655737767; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUSX4iWBZhA=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JYlxCnv80f10XBY8ugcqB6ORZ9vPp1sIZAkczAnhOPgltFNRIgPsuh6VcjEWE2z8I zVMmQiRDbI4AoM1dXB2i5IMIHHlqzYS7Pt3oCcjExuQmeCWHHf2sPnzQjnVrXhAY6C DE7viY3coW65NpO3mHmon7uWRr9PnwcNy2nRSScs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C0846F80544; Mon, 20 Jun 2022 17:06:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 721BDF800E4; Mon, 20 Jun 2022 02:25:59 +0200 (CEST) Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CEB42F800E4 for ; Mon, 20 Jun 2022 02:25:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CEB42F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="reHSoUdi"; dkim=pass (2048-bit key) header.d=opensource.wdc.com header.i=@opensource.wdc.com header.b="C4jTh3Cd" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1655684753; x=1687220753; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUSX4iWBZhA=; b=reHSoUdiwW0I2KT8kfsGB6p6Qhc0OkRtXh2QOd/lR7WWvOpD11xPqTtx BWb42U3/SSWw5wQmkLrOl/UHY/WqnP7g2vQ575Z+iTBt73JsA7Aq8wRWY tPbqG9xRFKvHoi/Z1t01mDEmoYLbfqKxjNkFtGqpDrawbnwgU0SqGA+/j m8iTCAtbQkmNRlsudiV+viaZfqIejRpat9lIrxxbpdiey/Z3/ZPWjkeKT kA0v5J70LcExKYaGEFY4Y2LBcvmPLb7QXlvNB5JDNLMPmqD5TdJ7DuDIr 6O4hMUuq3UQh2bALU5F7ar2x42FvgcNaOMM432PnheldJa4LuNSFxA560 w==; X-IronPort-AV: E=Sophos;i="5.92,306,1650902400"; d="scan'208";a="203577225" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Jun 2022 08:25:46 +0800 IronPort-SDR: 932NAlgvMAQGw6sl5mDtFyXUVVbEJ7l9HT2KCIKlo/0DaZpO1KZ6XeHSPC/XbQY6ptN7q7RbbS kvShfi2Yz8IizLa/qiPZodcnJdjdeHJsx3ox51d9jpnBFV7kirod1LnoBoPj9s0+fdC8NOvBSj GawGPLdlMGD6jbxPpYbUXqy0EU0F/kQSDPnRgCRI1NIMet6TJA9CfGPLS8oKeFXHuDQ2cBWTtn Bz/F0uzhbfev6ikJimBuJ2lynou6r9PiyPj+OsaKS458bNfcMJDPx9Tf1O3hz0ml8meFNa4sMw g1JimRkPYwavFnyAShphXdkE Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 16:48:19 -0700 IronPort-SDR: K0Qh69wniC4yf20UT3La5zzLFQMPlKnAJ4eRFglT7MK7cXQtxSiquFIEAo6RGXGvyj5svr5hEm VM1G894xqOCQ/UBVzV++vTQSoGZbtCOMROGpCKMw3zaOxo9MyZpwYQdYcyQKYratoMKXd/rnUx S9h/LaK8iYLPbI/+/3IxdIncUVxZ4ZZAixkHF1el2hDUaYqE6U2wXsCqBdyCyUP7jrdSDdFhWu Fi0RFrlZzIeSqFcmj69zLH80O6uIPAwwGmk41m0FO/d9EerHiq/JxcH3lZkbim+F0pRRrH6Nt+ c0Y= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jun 2022 17:25:47 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LR9RG2H3Dz1SVp2 for ; Sun, 19 Jun 2022 17:25:46 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1655684744; x=1658276745; bh=H0ulQrMBtA6pu622Zq7Ff/HeEgzOhbo0ZUS X4iWBZhA=; b=C4jTh3Cduu7dnWqkzvP9u4tEJAeikZRq/wWmWNKkwFtT8M4pM77 3hndmJwZOZr3hCWku8+IuTH1ZnvcAIMua0Zw2k7F3+6euIqXkh5UFAbAANNHLqXU cxnLLcwkEtmk/xheSzmNHSiFDRiH3OwgiUC5d4BmDn0CS11dBqu4JpLHc/VbXFmr cE49A+9RgLD5zqbN6CO9a9Hwi11IjyTNgdsI7qunXIj89zs3C2goG1ATpKObywEM cw+htJod9TACf+L53t0cPM+3RbyaAToItQ1NDKQUEWoXwffXp6ihfDogop4ylbzA 5uHeE7r2BlfB77ZWvTPUP73mxqPCIunnq3w== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mEB39yD56-Ob for ; Sun, 19 Jun 2022 17:25:44 -0700 (PDT) Received: from [10.225.163.87] (unknown [10.225.163.87]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LR9R75cZsz1Rvlc; Sun, 19 Jun 2022 17:25:39 -0700 (PDT) Message-ID: <891cf74c-ac0a-b380-1d5f-dd7ce5aeda9d@opensource.wdc.com> Date: Mon, 20 Jun 2022 09:25:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node Content-Language: en-US To: Conor.Dooley@microchip.com, mail@conchuod.ie, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com, sam@ravnborg.org, Eugeniy.Paltsev@synopsys.com, vkoul@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, fancer.lancer@gmail.com, daniel.lezcano@linaro.org, palmer@dabbelt.com, palmer@rivosinc.com References: <20220618123035.563070-1-mail@conchuod.ie> <20220618123035.563070-8-mail@conchuod.ie> <9cd60b3b-44fe-62ac-9874-80ae2223d078@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 20 Jun 2022 17:06:44 +0200 Cc: niklas.cassel@wdc.com, alsa-devel@alsa-project.org, aou@eecs.berkeley.edu, devicetree@vger.kernel.org, masahiroy@kernel.org, linux-kernel@vger.kernel.org, jee.heng.sia@intel.com, linux-spi@vger.kernel.org, joabreu@synopsys.com, geert@linux-m68k.org, dri-devel@lists.freedesktop.org, paul.walmsley@sifive.com, dmaengine@vger.kernel.org, tglx@linutronix.de, dillon.minfei@gmail.com, linux-riscv@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/20/22 08:54, Conor.Dooley@microchip.com wrote: > On 20/06/2022 00:38, Damien Le Moal wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 6/18/22 21:30, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> The k210 memory node has a compatible string that does not match with >>> any driver or dt-binding & has several non standard properties. >>> Replace the reg names with a comment and delete the rest. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> --- >>> arch/riscv/boot/dts/canaan/k210.dtsi | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi >>> index 44d338514761..287ea6eebe47 100644 >>> --- a/arch/riscv/boot/dts/canaan/k210.dtsi >>> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi >>> @@ -69,15 +69,9 @@ cpu1_intc: interrupt-controller { >>> >>> sram: memory@80000000 { >>> device_type = "memory"; >>> - compatible = "canaan,k210-sram"; >>> reg = <0x80000000 0x400000>, >>> <0x80400000 0x200000>, >>> <0x80600000 0x200000>; >>> - reg-names = "sram0", "sram1", "aisram"; >>> - clocks = <&sysclk K210_CLK_SRAM0>, >>> - <&sysclk K210_CLK_SRAM1>, >>> - <&sysclk K210_CLK_AI>; >>> - clock-names = "sram0", "sram1", "aisram"; >>> }; >> >> These are used by u-boot to setup the memory clocks and initialize the >> aisram. Sure the kernel actually does not use this, but to be in sync with >> u-boot DT, I would prefer keeping this as is. Right now, u-boot *and* the >> kernel work fine with both u-boot internal DT and the kernel DT. > > Right, but unfortunately that desire alone doesn't do anything about > the dtbs_check complaints. > > I guess the alternative approach of actually documenting the compatible > would be more palatable? Yes, I think so. That would allow keeping the fields without the DTB build warnings. > > Thanks, > Conor. > > > -- Damien Le Moal Western Digital Research