From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5BEC4363A for ; Tue, 20 Oct 2020 21:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2CD22224A for ; Tue, 20 Oct 2020 21:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gs/w6JM7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389754AbgJTVrC (ORCPT ); Tue, 20 Oct 2020 17:47:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389617AbgJTVrC (ORCPT ); Tue, 20 Oct 2020 17:47:02 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A5B5C0613CE; Tue, 20 Oct 2020 14:47:02 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id h24so4956305ejg.9; Tue, 20 Oct 2020 14:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=Gs/w6JM7zA6yL1ixdYo1xR++QcsTBl9aPPPmTi4LPCXqtcDSCsqlk25SUycBw5BAPq lshXIwVAyQmQeHnMmNOE4CAcNnWfUuah3dultc6A7qA546Dis3N/2bSsJ3iLNk7GG4PQ Kq93Z/YksnxpG+6FLS5CU3NfXpn/ogqMrYxkiDrpJoyPi6BmQCECe9wVFBdwoAbl0SMa 01zrWTokETo5D6DzICgTxTe3pr7X1PmIFDgQxYUV5/PPk3grP87lbA5a7CRpYguw72Hs 7Aa9lBvIOaZszZoF6bNXzNag+O+25IzLyZForF8uJ8pyrOXwU9gurtOPWxZzXXtcAwQ/ pe1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=KhYM+vYvzKYOIoqE2TNN3A7vtBpTS1itNBAZFZKfmglDRzos0zVBX/5ACLmerwbcF+ WjEm01RxsLg0T+ZduwgaZLSxgubZcpGNJ464A7Q9LXQS4HdSh1eH3KO3ivxjD4MBckbz WQrI12N0hvIZB/jggYJ9Ls7W8yOI/j446mgRaL2DzeycsfiO37lwv6aNx2rauXZt/IFH /zH7/2ybY/JvrNry/alc99zajWmPSHYL03vfY8P2ZcQMi5TTCqw5J5SXJyfbKExYGkBJ Le1UANZAlXUP4cBeYecX0bEfHPrxzOvXuVe933G81KJuTPHsvbD+xJ/C5usrEcuOp8xO 4Hog== X-Gm-Message-State: AOAM533ixAtHcl53nSnvTxBMEcgILRrMD8/8piYc8jDubkKFUv5oCfSg n0eRVOnHFLQFE3iMd6ahVkpNpFGn1ac= X-Google-Smtp-Source: ABdhPJzR95k+qiXGnZue7DquJHpX6z+X0kmVYYGtiPcjz51ZgZ/tz2/zilEua/Slair4hem1PZTnaA== X-Received: by 2002:a17:906:1e95:: with SMTP id e21mr190796ejj.355.1603230420970; Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Received: from ?IPv6:2a01:110f:b59:fd00:7dff:cc5e:4622:485f? ([2a01:110f:b59:fd00:7dff:cc5e:4622:485f]) by smtp.gmail.com with ESMTPSA id p2sm107051ejd.34.2020.10.20.14.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Gene Chen Cc: Pavel Machek , Rob Herring , Matthias Brugger , Dan Murphy , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> From: Jacek Anaszewski Message-ID: <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> Date: Tue, 20 Oct 2020 23:46:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 10/20/20 8:44 AM, Gene Chen wrote: > Jacek Anaszewski 於 2020年10月9日 週五 上午5:51寫道： >> >> Hi Gene, >> >> On 10/7/20 3:42 AM, Gene Chen wrote: >>> From: Gene Chen >>> >>> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, >>> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for >>> moonlight LED. >>> >>> Signed-off-by: Gene Chen >>> --- >>> drivers/leds/Kconfig | 12 + >>> drivers/leds/Makefile | 1 + >>> drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 796 insertions(+) >>> create mode 100644 drivers/leds/leds-mt6360.c >>> >>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>> index 1c181df..c7192dd 100644 >>> --- a/drivers/leds/Kconfig >>> +++ b/drivers/leds/Kconfig >>> @@ -271,6 +271,18 @@ config LEDS_MT6323 >>> This option enables support for on-chip LED drivers found on >>> Mediatek MT6323 PMIC. >>> >>> +config LEDS_MT6360 >>> + tristate "LED Support for Mediatek MT6360 PMIC" >>> + depends on LEDS_CLASS_FLASH && OF >>> + depends on LEDS_CLASS_MULTICOLOR >> >> Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have >> below instead: >> >> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR >> >> Unless you want to prevent enabling the driver without RGB LED, >> but that does not seem to be reasonable at first glance. >> > > May I change to "select LEDS_CLASS_MULTICOLOR"? > I suppose RGB always use multicolor mode. You will also have moonlight LED that will not need multicolor framework. Is it somehow troublesome to keep "depends on"? -- Best regards, Jacek Anaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918DDC4363A for ; Tue, 20 Oct 2020 21:47:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1470722244 for ; Tue, 20 Oct 2020 21:47:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YJrkX+U2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gs/w6JM7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1470722244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sUJ0Jt3OBJYjc0UDZOw29ApGSOx64F0+1igK8o+NhpI=; b=YJrkX+U2H2EEv3BgOi8x8+nPt EFaXwDBB2H92Lup/7NtLowHkGw/s2EDn8iYKF8wg3Wlxo+m6W6NiMuJGRCejWf9tZdPSK4DeqA8rY Sxu1D6laczoNjouIZFzdPjW/6F5wsWLsjxSjQFODVXng1FnywGITV8xE79fJlrwGHv6L4WZPWMvJp K99f1pFhL82wKQhcI2w1/I9wOaSJaOsHCZoYeCPP8NkEnkuk3Xmcy2earyc7zOjrYr3EEb23uhUA+ E5g73ONYL4MTE6J7PoiuwFjNEFmobtsKEbjw6saVnOT3Y6r3GV2x8Ni1r5+c16106D8WAUHdQWiOC jLAzSIvdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUzTF-0003lE-HR; Tue, 20 Oct 2020 21:47:05 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUzTD-0003jj-H3; Tue, 20 Oct 2020 21:47:04 +0000 Received: by mail-ej1-x641.google.com with SMTP id md26so4961605ejb.10; Tue, 20 Oct 2020 14:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=Gs/w6JM7zA6yL1ixdYo1xR++QcsTBl9aPPPmTi4LPCXqtcDSCsqlk25SUycBw5BAPq lshXIwVAyQmQeHnMmNOE4CAcNnWfUuah3dultc6A7qA546Dis3N/2bSsJ3iLNk7GG4PQ Kq93Z/YksnxpG+6FLS5CU3NfXpn/ogqMrYxkiDrpJoyPi6BmQCECe9wVFBdwoAbl0SMa 01zrWTokETo5D6DzICgTxTe3pr7X1PmIFDgQxYUV5/PPk3grP87lbA5a7CRpYguw72Hs 7Aa9lBvIOaZszZoF6bNXzNag+O+25IzLyZForF8uJ8pyrOXwU9gurtOPWxZzXXtcAwQ/ pe1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=dNgPH+4h092H1k6BXAKyRri9fOKDn4YEnYNgQ1I/Fb8pnhFnN3L9/1KEYUTH5j9ILe BP+qvMDlcHCBVyi6NIgpLsDK9XEAgSgwZIlpNaSSjZ3PucEsqJ53NuIvkLGBBrvvUQJV TGLG97+AyWtv8NDtwHJ428Xywoa3uF3SJw1kko7WY7SIAtEJbEh/FOqkUJhADTUAtHqI Vxot3Xe364PEksICUHPGT/qCMZt+NGdgcMVV7vl0bT+6HHi66BR/K3mRqtv2XB43BzQ5 hbWSBJVCaEB8c+XHXm/HaELjfM8TSk/OXA9VnWB6zD6JC+SHLi9dfMFvQIWA2VBLD7dh PAyg== X-Gm-Message-State: AOAM531jXnHM2trLFdcpIEnx+Mzl1K18y3L/eWsUawKHf3XTjfSN9Hbv TaieERKkCbVj9hAsodQaCoE= X-Google-Smtp-Source: ABdhPJzR95k+qiXGnZue7DquJHpX6z+X0kmVYYGtiPcjz51ZgZ/tz2/zilEua/Slair4hem1PZTnaA== X-Received: by 2002:a17:906:1e95:: with SMTP id e21mr190796ejj.355.1603230420970; Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Received: from ?IPv6:2a01:110f:b59:fd00:7dff:cc5e:4622:485f? ([2a01:110f:b59:fd00:7dff:cc5e:4622:485f]) by smtp.gmail.com with ESMTPSA id p2sm107051ejd.34.2020.10.20.14.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Gene Chen References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> From: Jacek Anaszewski Message-ID: <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> Date: Tue, 20 Oct 2020 23:46:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_174703_564288_B288CED7 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm Mailing List , devicetree , cy_huang@richtek.com, Linux Kernel Mailing List , Gene Chen , benjamin.chao@mediatek.com, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dan Murphy , Pavel Machek , Matthias Brugger , Wilma.Wu@mediatek.com, Linux LED Subsystem , shufan_lee@richtek.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gMTAvMjAvMjAgODo0NCBBTSwgR2VuZSBDaGVuIHdyb3RlOgo+IEphY2VrIEFuYXN6ZXdza2kg PGphY2VrLmFuYXN6ZXdza2lAZ21haWwuY29tPiDmlrwgMjAyMOW5tDEw5pyIOeaXpSDpgLHkupQg 5LiK5Y2INTo1MeWvq+mBk++8mgo+Pgo+PiBIaSBHZW5lLAo+Pgo+PiBPbiAxMC83LzIwIDM6NDIg QU0sIEdlbmUgQ2hlbiB3cm90ZToKPj4+IEZyb206IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0 ZWsuY29tPgo+Pj4KPj4+IEFkZCBNVDYzNjAgTEVEIGRyaXZlciBpbmNsdWRlIDItY2hhbm5lbCBG bGFzaCBMRUQgd2l0aCB0b3JjaC9zdHJvYmUgbW9kZSwKPj4+IDMtY2hhbm5lbCBSR0IgTEVEIHN1 cHBvcnQgUmVnaXN0ZXIvRmxhc2gvQnJlYXRoIE1vZGUsIGFuZCAxLWNoYW5uZWwgZm9yCj4+PiBt b29ubGlnaHQgTEVELgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2VuZV9jaGVu QHJpY2h0ZWsuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2xlZHMvS2NvbmZpZyAgICAgICB8 ICAxMiArCj4+PiAgICBkcml2ZXJzL2xlZHMvTWFrZWZpbGUgICAgICB8ICAgMSArCj4+PiAgICBk cml2ZXJzL2xlZHMvbGVkcy1tdDYzNjAuYyB8IDc4MyArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPj4+ICAgIDMgZmlsZXMgY2hhbmdlZCwgNzk2IGluc2VydGlv bnMoKykKPj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2xlZHMvbGVkcy1tdDYzNjAu Ywo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvS2NvbmZpZyBiL2RyaXZlcnMvbGVk cy9LY29uZmlnCj4+PiBpbmRleCAxYzE4MWRmLi5jNzE5MmRkIDEwMDY0NAo+Pj4gLS0tIGEvZHJp dmVycy9sZWRzL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvbGVkcy9LY29uZmlnCj4+PiBAQCAt MjcxLDYgKzI3MSwxOCBAQCBjb25maWcgTEVEU19NVDYzMjMKPj4+ICAgICAgICAgIFRoaXMgb3B0 aW9uIGVuYWJsZXMgc3VwcG9ydCBmb3Igb24tY2hpcCBMRUQgZHJpdmVycyBmb3VuZCBvbgo+Pj4g ICAgICAgICAgTWVkaWF0ZWsgTVQ2MzIzIFBNSUMuCj4+Pgo+Pj4gK2NvbmZpZyBMRURTX01UNjM2 MAo+Pj4gKyAgICAgdHJpc3RhdGUgIkxFRCBTdXBwb3J0IGZvciBNZWRpYXRlayBNVDYzNjAgUE1J QyIKPj4+ICsgICAgIGRlcGVuZHMgb24gTEVEU19DTEFTU19GTEFTSCAmJiBPRgo+Pj4gKyAgICAg ZGVwZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IKPj4KPj4gU2luY2UgQ09ORklHX0xFRF9D TEFTU19NVUxUSUNPTE9SIGNhbiBiZSB0dXJuZWQgb2ZmIHlvdSBuZWVkIHRvIGhhdmUKPj4gYmVs b3cgaW5zdGVhZDoKPj4KPj4gZGVwZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IgfHwgISFM RURTX0NMQVNTX01VTFRJQ09MT1IKPj4KPj4gVW5sZXNzIHlvdSB3YW50IHRvIHByZXZlbnQgZW5h YmxpbmcgdGhlIGRyaXZlciB3aXRob3V0IFJHQiBMRUQsCj4+IGJ1dCB0aGF0IGRvZXMgbm90IHNl ZW0gdG8gYmUgcmVhc29uYWJsZSBhdCBmaXJzdCBnbGFuY2UuCj4+Cj4gCj4gTWF5IEkgY2hhbmdl IHRvICJzZWxlY3QgTEVEU19DTEFTU19NVUxUSUNPTE9SIj8KPiBJIHN1cHBvc2UgUkdCIGFsd2F5 cyB1c2UgbXVsdGljb2xvciBtb2RlLgoKWW91IHdpbGwgYWxzbyBoYXZlIG1vb25saWdodCBMRUQg dGhhdCB3aWxsIG5vdCBuZWVkIG11bHRpY29sb3IKZnJhbWV3b3JrLiBJcyBpdCBzb21laG93IHRy b3VibGVzb21lIHRvIGtlZXAgImRlcGVuZHMgb24iPwoKLS0gCkJlc3QgcmVnYXJkcywKSmFjZWsg QW5hc3pld3NraQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CF7C4363A for ; Tue, 20 Oct 2020 21:48:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF8C22247 for ; Tue, 20 Oct 2020 21:48:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CBixK/5K"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gs/w6JM7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF8C22247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C2JSI7vPxMA6NmQl73t9PeoIOOIXAO0FBX7W+lyPEUE=; b=CBixK/5KyaiAuOmIA7fDKyrhm 5X5IrQejFo1PeNHDggVFbiW+Tyt3syyhhziOlKtLhsVNlTCowQcRy2kqaXvsvRr89KfHej264Ma1K w50MpvlGNZVNjAZzVbaWX96cWYHFhLCWW0QKyQoVz6LccOB5lcJ0NB6GqdE4OtzaK+XFV6o/3GGzf R7yfabYLuAkrQa1Fwrdak8LMpIuIBOHKEXgxSNMUNUWwQ6HCf/rqN0hSJGWS99Y0MJlO23GMwGu6q C5EU4ax79kVlOC3lcop5jfeajw2p31G3RcMA/GpKHdNLti5vfQQ5UeE5dv00aXdrokAii5k5ZzNGj nj8J8uPTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUzTH-0003lm-N7; Tue, 20 Oct 2020 21:47:07 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUzTD-0003jj-H3; Tue, 20 Oct 2020 21:47:04 +0000 Received: by mail-ej1-x641.google.com with SMTP id md26so4961605ejb.10; Tue, 20 Oct 2020 14:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=Gs/w6JM7zA6yL1ixdYo1xR++QcsTBl9aPPPmTi4LPCXqtcDSCsqlk25SUycBw5BAPq lshXIwVAyQmQeHnMmNOE4CAcNnWfUuah3dultc6A7qA546Dis3N/2bSsJ3iLNk7GG4PQ Kq93Z/YksnxpG+6FLS5CU3NfXpn/ogqMrYxkiDrpJoyPi6BmQCECe9wVFBdwoAbl0SMa 01zrWTokETo5D6DzICgTxTe3pr7X1PmIFDgQxYUV5/PPk3grP87lbA5a7CRpYguw72Hs 7Aa9lBvIOaZszZoF6bNXzNag+O+25IzLyZForF8uJ8pyrOXwU9gurtOPWxZzXXtcAwQ/ pe1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fT5KwI1u6PV8EmjtyHpKqwjn8VqaBxGqgtD+UYm6G/w=; b=dNgPH+4h092H1k6BXAKyRri9fOKDn4YEnYNgQ1I/Fb8pnhFnN3L9/1KEYUTH5j9ILe BP+qvMDlcHCBVyi6NIgpLsDK9XEAgSgwZIlpNaSSjZ3PucEsqJ53NuIvkLGBBrvvUQJV TGLG97+AyWtv8NDtwHJ428Xywoa3uF3SJw1kko7WY7SIAtEJbEh/FOqkUJhADTUAtHqI Vxot3Xe364PEksICUHPGT/qCMZt+NGdgcMVV7vl0bT+6HHi66BR/K3mRqtv2XB43BzQ5 hbWSBJVCaEB8c+XHXm/HaELjfM8TSk/OXA9VnWB6zD6JC+SHLi9dfMFvQIWA2VBLD7dh PAyg== X-Gm-Message-State: AOAM531jXnHM2trLFdcpIEnx+Mzl1K18y3L/eWsUawKHf3XTjfSN9Hbv TaieERKkCbVj9hAsodQaCoE= X-Google-Smtp-Source: ABdhPJzR95k+qiXGnZue7DquJHpX6z+X0kmVYYGtiPcjz51ZgZ/tz2/zilEua/Slair4hem1PZTnaA== X-Received: by 2002:a17:906:1e95:: with SMTP id e21mr190796ejj.355.1603230420970; Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Received: from ?IPv6:2a01:110f:b59:fd00:7dff:cc5e:4622:485f? ([2a01:110f:b59:fd00:7dff:cc5e:4622:485f]) by smtp.gmail.com with ESMTPSA id p2sm107051ejd.34.2020.10.20.14.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 14:47:00 -0700 (PDT) Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Gene Chen References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> From: Jacek Anaszewski Message-ID: <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> Date: Tue, 20 Oct 2020 23:46:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_174703_564288_B288CED7 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm Mailing List , devicetree , cy_huang@richtek.com, Linux Kernel Mailing List , Gene Chen , benjamin.chao@mediatek.com, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dan Murphy , Pavel Machek , Matthias Brugger , Wilma.Wu@mediatek.com, Linux LED Subsystem , shufan_lee@richtek.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvMjAvMjAgODo0NCBBTSwgR2VuZSBDaGVuIHdyb3RlOgo+IEphY2VrIEFuYXN6ZXdza2kg PGphY2VrLmFuYXN6ZXdza2lAZ21haWwuY29tPiDmlrwgMjAyMOW5tDEw5pyIOeaXpSDpgLHkupQg 5LiK5Y2INTo1MeWvq+mBk++8mgo+Pgo+PiBIaSBHZW5lLAo+Pgo+PiBPbiAxMC83LzIwIDM6NDIg QU0sIEdlbmUgQ2hlbiB3cm90ZToKPj4+IEZyb206IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0 ZWsuY29tPgo+Pj4KPj4+IEFkZCBNVDYzNjAgTEVEIGRyaXZlciBpbmNsdWRlIDItY2hhbm5lbCBG bGFzaCBMRUQgd2l0aCB0b3JjaC9zdHJvYmUgbW9kZSwKPj4+IDMtY2hhbm5lbCBSR0IgTEVEIHN1 cHBvcnQgUmVnaXN0ZXIvRmxhc2gvQnJlYXRoIE1vZGUsIGFuZCAxLWNoYW5uZWwgZm9yCj4+PiBt b29ubGlnaHQgTEVELgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2VuZV9jaGVu QHJpY2h0ZWsuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2xlZHMvS2NvbmZpZyAgICAgICB8 ICAxMiArCj4+PiAgICBkcml2ZXJzL2xlZHMvTWFrZWZpbGUgICAgICB8ICAgMSArCj4+PiAgICBk cml2ZXJzL2xlZHMvbGVkcy1tdDYzNjAuYyB8IDc4MyArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPj4+ICAgIDMgZmlsZXMgY2hhbmdlZCwgNzk2IGluc2VydGlv bnMoKykKPj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2xlZHMvbGVkcy1tdDYzNjAu Ywo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvS2NvbmZpZyBiL2RyaXZlcnMvbGVk cy9LY29uZmlnCj4+PiBpbmRleCAxYzE4MWRmLi5jNzE5MmRkIDEwMDY0NAo+Pj4gLS0tIGEvZHJp dmVycy9sZWRzL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvbGVkcy9LY29uZmlnCj4+PiBAQCAt MjcxLDYgKzI3MSwxOCBAQCBjb25maWcgTEVEU19NVDYzMjMKPj4+ICAgICAgICAgIFRoaXMgb3B0 aW9uIGVuYWJsZXMgc3VwcG9ydCBmb3Igb24tY2hpcCBMRUQgZHJpdmVycyBmb3VuZCBvbgo+Pj4g ICAgICAgICAgTWVkaWF0ZWsgTVQ2MzIzIFBNSUMuCj4+Pgo+Pj4gK2NvbmZpZyBMRURTX01UNjM2 MAo+Pj4gKyAgICAgdHJpc3RhdGUgIkxFRCBTdXBwb3J0IGZvciBNZWRpYXRlayBNVDYzNjAgUE1J QyIKPj4+ICsgICAgIGRlcGVuZHMgb24gTEVEU19DTEFTU19GTEFTSCAmJiBPRgo+Pj4gKyAgICAg ZGVwZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IKPj4KPj4gU2luY2UgQ09ORklHX0xFRF9D TEFTU19NVUxUSUNPTE9SIGNhbiBiZSB0dXJuZWQgb2ZmIHlvdSBuZWVkIHRvIGhhdmUKPj4gYmVs b3cgaW5zdGVhZDoKPj4KPj4gZGVwZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IgfHwgISFM RURTX0NMQVNTX01VTFRJQ09MT1IKPj4KPj4gVW5sZXNzIHlvdSB3YW50IHRvIHByZXZlbnQgZW5h YmxpbmcgdGhlIGRyaXZlciB3aXRob3V0IFJHQiBMRUQsCj4+IGJ1dCB0aGF0IGRvZXMgbm90IHNl ZW0gdG8gYmUgcmVhc29uYWJsZSBhdCBmaXJzdCBnbGFuY2UuCj4+Cj4gCj4gTWF5IEkgY2hhbmdl IHRvICJzZWxlY3QgTEVEU19DTEFTU19NVUxUSUNPTE9SIj8KPiBJIHN1cHBvc2UgUkdCIGFsd2F5 cyB1c2UgbXVsdGljb2xvciBtb2RlLgoKWW91IHdpbGwgYWxzbyBoYXZlIG1vb25saWdodCBMRUQg dGhhdCB3aWxsIG5vdCBuZWVkIG11bHRpY29sb3IKZnJhbWV3b3JrLiBJcyBpdCBzb21laG93IHRy b3VibGVzb21lIHRvIGtlZXAgImRlcGVuZHMgb24iPwoKLS0gCkJlc3QgcmVnYXJkcywKSmFjZWsg QW5hc3pld3NraQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=