From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/3] drm/i915: Return immediately if trylock fails for direct-reclaim Date: Thu, 8 Nov 2018 16:23:08 +0000 Message-ID: <892ae58f-33ed-b468-fe7c-bd655f8567d4@linux.intel.com> References: <20181108081740.25615-1-chris@chris-wilson.co.uk> <20181108081740.25615-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 884CC6E47D for ; Thu, 8 Nov 2018 16:23:10 +0000 (UTC) In-Reply-To: <20181108081740.25615-2-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzExLzIwMTggMDg6MTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZ25vcmUgdHJ5aW5n IHRvIHNocmluayBmcm9tIGk5MTUgaWYgd2UgZmFpbCB0byBhY3F1aXJlIHRoZSBzdHJ1Y3RfbXV0 ZXgKPiBpbiB0aGUgc2hyaW5rZXIgd2hpbGUgcGVyZm9ybWluZyBkaXJlY3QtcmVjbGFpbS4gVGhl IHRyYWRlLW9mZiBiZWluZwo+IChtdWNoKSBsb3dlciBsYXRlbmN5IGZvciBub24taTkxNSBjbGll bnRzIGF0IGFuIGluY3JlYXNlZCByaXNrIG9mIGJlaW5nCj4gdW5hYmxlIHRvIG9idGFpbiBhIHBh Z2UgZnJvbSBkaXJlY3QtcmVjbGFpbSB3aXRob3V0IGhpdHRpbmcgdGhlCj4gb29tLW5vdGlmaWVy LiBUaGUgcHJvdmlzbyBiZWluZyB0aGF0IHdlIHN0aWxsIGtlZXAgdHJ5aW5nIHRvIGhhcmQKPiBv YnRhaW4gdGhlIGxvY2sgZm9yIG9vbSBzbyB0aGF0IHdlIGNhbiByZWFwIHVuZGVyIGhlYXZ5IG1l bW9yeSBwcmVzc3VyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Nocmlua2Vy LmMgfCAyNCArKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBp bnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX3Nocmlua2VyLmMKPiBpbmRleCBlYTkwZDNhMGQ1MTEuLmQ0NjFmNDU4ZjRhZiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+IEBAIC0zNiw3ICsz Niw5IEBACj4gICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiAgICNpbmNsdWRlICJpOTE1X3RyYWNl LmgiCj4gICAKPiAtc3RhdGljIGJvb2wgc2hyaW5rZXJfbG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSwgYm9vbCAqdW5sb2NrKQo+ICtzdGF0aWMgYm9vbCBzaHJpbmtlcl9sb2NrKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICsJCQkgIHVuc2lnbmVkIGludCBmbGFncywK PiArCQkJICBib29sICp1bmxvY2spCj4gICB7Cj4gICAJc3dpdGNoIChtdXRleF90cnlsb2NrX3Jl Y3Vyc2l2ZSgmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCkpIHsKPiAgIAljYXNlIE1VVEVYX1RSWUxP Q0tfUkVDVVJTSVZFOgo+IEBAIC00NSwxNSArNDcsMTEgQEAgc3RhdGljIGJvb2wgc2hyaW5rZXJf bG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCAqdW5sb2NrKQo+ICAgCj4g ICAJY2FzZSBNVVRFWF9UUllMT0NLX0ZBSUxFRDoKPiAgIAkJKnVubG9jayA9IGZhbHNlOwo+IC0J CXByZWVtcHRfZGlzYWJsZSgpOwo+IC0JCWRvIHsKPiAtCQkJY3B1X3JlbGF4KCk7Cj4gLQkJCWlm IChtdXRleF90cnlsb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KSkgewo+IC0JCQkJKnVubG9j ayA9IHRydWU7Cj4gLQkJCQlicmVhazsKPiAtCQkJfQo+IC0JCX0gd2hpbGUgKCFuZWVkX3Jlc2No ZWQoKSk7Cj4gLQkJcHJlZW1wdF9lbmFibGUoKTsKPiArCQlpZiAoZmxhZ3MgJiBJOTE1X1NIUklO S19BQ1RJVkUpIHsKClNvIHVudGlsIEk5MTVfU0hSSU5LX0FDVElWRSwgd2hpY2ggaXMgdGhlIGxh c3QgZGl0Y2ggYXR0ZW1wdCB0byBzaHJpbmsgCmluIHRoZSBub3JtYWwgY2FzZSAoZGlyZWN0IHJl Y2xhaW0/KSBvciBvb20sIHdlIGJhaWwgb3V0IG9uIHRoZSBmaXJzdCAKc2lnbiBvZiBzdHJ1Y3Qg bXV0ZXggY29udGVudGlvbi4gRG9lc24ndCB0aGlzIG1ha2Ugb3VyIHNocmlua2VyIG11Y2ggCmxl c3MgZWZmZWN0aXZlIGF0IHJ1bnRpbWUgYW5kIHdoeSBpcyB0aGF0IE9LPwoKT3IgaW4gb3RoZXIg d29yZHMsIGZvciB3aGF0IHVzZSBjYXNlcywgdGVzdHMgb3IgYmVuY2htYXJrIHdhcyB0aGUgCmV4 aXN0aW5nIGFwcHJvYWNoIG9mIGJ1c3kgbG9vcGluZyBhIHByb2JsZW0/Cgo+ICsJCQltdXRleF9s b2NrX25lc3RlZCgmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCwKPiArCQkJCQkgIEk5MTVfTU1fU0hS SU5LRVIpOwoKX25lc3RlZCBpcyBuZWVkZWQgc2luY2UgYWJhbmRvbmluZyB0cnlsb2NrIHdvdWxk IG90aGVyd2lzZSBjYXVzZSBsb2NrZGVwIAppc3N1ZXM/IEJ1dCBpcyBpdCByZWFsbHkgc2FmZT8g SSBkb24ndCBrbm93Li4gaG93IGNhbiBpdCBiZT8gSXQgaXMgCmd1YXJhbnRlZWQgdG8gYmUgYSBk aWZmZXJlbnQgcHJvY2VzcyBoZXJlIG90aGVyd2lzZSB0aGUgcmVzdWx0IHdvdWxkbid0IApiZSBN VVRFWF9UUllMT0NLX0ZBSUxFRC4KCkFsc28sIEk5MTVfTU1fU0hSSU5LRVIgaXMgc28gZmFyIG9u bHkgZG9jdW1lbnRlZCB0byBhcHBseSB0byBvYmotPm1tLmxvY2suCgpSZWdhcmRzLAoKVHZydGtv Cgo+ICsJCQkqdW5sb2NrID0gdHJ1ZTsKPiArCQl9Cj4gICAJCXJldHVybiAqdW5sb2NrOwo+ICAg Cj4gICAJY2FzZSBNVVRFWF9UUllMT0NLX1NVQ0NFU1M6Cj4gQEAgLTE2MCw3ICsxNTgsNyBAQCBp OTE1X2dlbV9zaHJpbmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gICAJdW5zaWdu ZWQgbG9uZyBzY2FubmVkID0gMDsKPiAgIAlib29sIHVubG9jazsKPiAgIAo+IC0JaWYgKCFzaHJp bmtlcl9sb2NrKGk5MTUsICZ1bmxvY2spKQo+ICsJaWYgKCFzaHJpbmtlcl9sb2NrKGk5MTUsIGZs YWdzLCAmdW5sb2NrKSkKPiAgIAkJcmV0dXJuIDA7Cj4gICAKPiAgIAkvKgo+IEBAIC0zNTcsNyAr MzU1LDcgQEAgaTkxNV9nZW1fc2hyaW5rZXJfc2NhbihzdHJ1Y3Qgc2hyaW5rZXIgKnNocmlua2Vy LCBzdHJ1Y3Qgc2hyaW5rX2NvbnRyb2wgKnNjKQo+ICAgCj4gICAJc2MtPm5yX3NjYW5uZWQgPSAw Owo+ICAgCj4gLQlpZiAoIXNocmlua2VyX2xvY2soaTkxNSwgJnVubG9jaykpCj4gKwlpZiAoIXNo cmlua2VyX2xvY2soaTkxNSwgMCwgJnVubG9jaykpCj4gICAJCXJldHVybiBTSFJJTktfU1RPUDsK PiAgIAo+ICAgCWZyZWVkID0gaTkxNV9nZW1fc2hyaW5rKGk5MTUsCj4gQEAgLTM5Nyw3ICszOTUs NyBAQCBzaHJpbmtlcl9sb2NrX3VuaW50ZXJydXB0aWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqaTkxNSwgYm9vbCAqdW5sb2NrLAo+ICAgCWRvIHsKPiAgIAkJaWYgKGk5MTVfZ2VtX3dhaXRf Zm9yX2lkbGUoaTkxNSwKPiAgIAkJCQkJICAgMCwgTUFYX1NDSEVEVUxFX1RJTUVPVVQpID09IDAg JiYKPiAtCQkgICAgc2hyaW5rZXJfbG9jayhpOTE1LCB1bmxvY2spKQo+ICsJCSAgICBzaHJpbmtl cl9sb2NrKGk5MTUsIDAsIHVubG9jaykpCj4gICAJCQlicmVhazsKPiAgIAo+ICAgCQlzY2hlZHVs ZV90aW1lb3V0X2tpbGxhYmxlKDEpOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK