From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: RFC: DPDK Long Term Support Date: Mon, 06 Jun 2016 16:23:22 +0200 Message-ID: <8934963.xif5dsyFi0@xps13> References: <12523923.duYttjjiSP@xps13> <20160606141407.GE10038@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Mcnamara, John" , dev@dpdk.org, Christian Ehrhardt , Markos Chandras , Panu Matilainen To: Yuanhan Liu Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9AD882E81 for ; Mon, 6 Jun 2016 16:23:24 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id k204so29465896wmk.0 for ; Mon, 06 Jun 2016 07:23:24 -0700 (PDT) In-Reply-To: <20160606141407.GE10038@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-06 22:14, Yuanhan Liu: > On Mon, Jun 06, 2016 at 03:31:09PM +0200, Thomas Monjalon wrote: > > 2016-06-06 19:49, Yuanhan Liu: > > > On Fri, Jun 03, 2016 at 06:05:15PM +0200, Thomas Monjalon wrote: > > > > 2016-06-03 15:07, Mcnamara, John: > > > > > Developers submitting fixes to the mainline should also CC the maintainer so > > > > > that they can evaluate the patch. A email address could be > > > > > provided for this so that it can be included as a CC in the commit messages > > > > > and documented in the Code Contribution Guidelines. [...] > > Why put a CC tag in the commit? For automatic processing? > > Maybe it is too early to run before walking ;) > > It's a tip/trick used a lot in kernel community. Assume you have made > a patchset, that just one of them fixes a bug that you hope this patch > could also be cc'ed to the original author that introduces the bug. > You could achieve that by adding him to the cc list from cli. However, > in such way, all patches are cc'ed to him. The alternative is to add > a line "Cc: some.one " in the commit log so that he will > get that patch only. > > If you look at a small micro optimization patchset I sent out last > month [0], you will find that I used this trick for the 1st patch, > as it touches the core part of virtio-net vring operation, that I > hope I can get some comments from the virtio guru/maintainer, Michael. > Therefore, he is cc'ed. However, for the 2 other patches in the same > set, it's basically DPDK vhost-user stuff, so that I didn't cc him > to not bother him. > > This rule, of course, also applies to the stable branch (for bug > fixing patches in a set). It doesn't matter which way you take if > it's just a patch set of one bug fixing patch though. > > [0]: http://dpdk.org/ml/archives/dev/2016-May/038246.html OK