From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpzlU-0000vt-B7 for qemu-devel@nongnu.org; Mon, 20 Mar 2017 12:02:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpzlQ-0008Bn-F8 for qemu-devel@nongnu.org; Mon, 20 Mar 2017 12:02:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cpzlQ-0008BI-9h for qemu-devel@nongnu.org; Mon, 20 Mar 2017 12:02:32 -0400 References: <20170317215725.GJ996@jhogan-linux.le.imgtec.org> <6b3ec98b-55e2-ecc8-d962-dc9d13866319@redhat.com> <20170320174101-mutt-send-email-mst@kernel.org> From: Marcel Apfelbaum Message-ID: <8934b5c0-14ee-4396-4101-cbeb22144b11@redhat.com> Date: Mon, 20 Mar 2017 18:02:26 +0200 MIME-Version: 1.0 In-Reply-To: <20170320174101-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: James Hogan , qemu-devel@nongnu.org, Jason Wang , virtualization@lists.linux-foundation.org On 03/20/2017 05:43 PM, Michael S. Tsirkin wrote: > On Mon, Mar 20, 2017 at 05:21:22PM +0200, Marcel Apfelbaum wrote: >> On 03/17/2017 11:57 PM, James Hogan wrote: >>> Hi, >>> >>> I've bisected the following failure of the virtio_net linux v4.10 driver >>> to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: >>> >>> virtio_net virtio0: virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 >>> virtio_net: probe of virtio0 failed with error -22 >>> >>> To QEMU commit 9a4c0e220d8a ("hw/virtio-pci: fix virtio behaviour"). >>> >>> It appears that adding ",disable-modern=on,disable-legacy=off" to the >>> virtio-net -device makes it work again. >>> >>> I presume this should really just work out of the box. Any ideas why it >>> isn't? >>> >> >> Hi, >> >> >> This is strange. This commit changes virtio devices from legacy to virtio "transitional". >> (your command line changes it to legacy) >> Linux 4.10 supports virtio modern/transitional (as far as I know) and on QEMU side >> there is nothing new. >> >> Michael, do you have any idea? >> >> Thanks, >> Marcel > > My guess would be firmware mishandling 64 bit BARs - we saw such > a case on sparc previously. As a result you are probably reading > all zeroes from features register or something like that. > Marcel, could you send a patch making the bar 32 bit? > If that helps we know what the issue is. > Sure, Thanks, Marcel >>> Cheers >>> James >>> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Apfelbaum Subject: Re: [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour' Date: Mon, 20 Mar 2017 18:02:26 +0200 Message-ID: <8934b5c0-14ee-4396-4101-cbeb22144b11@redhat.com> References: <20170317215725.GJ996@jhogan-linux.le.imgtec.org> <6b3ec98b-55e2-ecc8-d962-dc9d13866319@redhat.com> <20170320174101-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170320174101-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: James Hogan , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On 03/20/2017 05:43 PM, Michael S. Tsirkin wrote: > On Mon, Mar 20, 2017 at 05:21:22PM +0200, Marcel Apfelbaum wrote: >> On 03/17/2017 11:57 PM, James Hogan wrote: >>> Hi, >>> >>> I've bisected the following failure of the virtio_net linux v4.10 driver >>> to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: >>> >>> virtio_net virtio0: virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 >>> virtio_net: probe of virtio0 failed with error -22 >>> >>> To QEMU commit 9a4c0e220d8a ("hw/virtio-pci: fix virtio behaviour"). >>> >>> It appears that adding ",disable-modern=on,disable-legacy=off" to the >>> virtio-net -device makes it work again. >>> >>> I presume this should really just work out of the box. Any ideas why it >>> isn't? >>> >> >> Hi, >> >> >> This is strange. This commit changes virtio devices from legacy to virtio "transitional". >> (your command line changes it to legacy) >> Linux 4.10 supports virtio modern/transitional (as far as I know) and on QEMU side >> there is nothing new. >> >> Michael, do you have any idea? >> >> Thanks, >> Marcel > > My guess would be firmware mishandling 64 bit BARs - we saw such > a case on sparc previously. As a result you are probably reading > all zeroes from features register or something like that. > Marcel, could you send a patch making the bar 32 bit? > If that helps we know what the issue is. > Sure, Thanks, Marcel >>> Cheers >>> James >>>