All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Greg KH <gregkh@linuxfoundation.org>,
	Guido Kiener <guido@kiener-muenchen.de>
Cc: linux-usb@vger.kernel.org, guido.kiener@rohde-schwarz.com,
	pankaj.adhikari@ni.com, steve_bayless@keysight.com,
	dpenkler@gmail.com
Subject: [02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle
Date: Thu, 17 May 2018 09:44:40 -0700	[thread overview]
Message-ID: <8935f5f7-c426-9f28-c49e-193bba31e69b@infradead.org> (raw)

On 05/17/2018 09:20 AM, Greg KH wrote:
>> +	file_data = kzalloc(sizeof(*file_data), GFP_KERNEL);
>> +	if (!file_data)
>> +		return -ENOMEM;
>> +
>> +	pr_debug("%s - called\n", __func__);
> Please do not add "tracing" functions like this.  The kernel has a
> wonderful built-in function tracing functionality, don't try to write
> your own.  These lines should just be removed.


but pr_debug() works great with DYNAMIC_DEBUG.

Someone does not need to go all the way to tracing to get decent
debug capability.

             reply	other threads:[~2018-05-17 16:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 16:44 Randy Dunlap [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-26 15:29 [02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle Oliver Neukum
2018-05-24 12:31 Guido Kiener
2018-05-23 11:47 Oliver Neukum
2018-05-21 21:00 Guido Kiener
2018-05-18 13:10 Greg Kroah-Hartman
2018-05-18 12:36 Guido Kiener
2018-05-18 12:02 Greg Kroah-Hartman
2018-05-18 11:52 Guido Kiener
2018-05-17 17:03 Guido Kiener
2018-05-17 16:56 Greg Kroah-Hartman
2018-05-17 16:20 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8935f5f7-c426-9f28-c49e-193bba31e69b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guido.kiener@rohde-schwarz.com \
    --cc=guido@kiener-muenchen.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=pankaj.adhikari@ni.com \
    --cc=steve_bayless@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.