All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Michael Neuling <mikey@neuling.org>
Subject: Re: [V2][PATCH] New MMU feature for new hpte format in ISA3
Date: Wed, 15 Jun 2016 17:19:00 +1000	[thread overview]
Message-ID: <8938f698-7311-9e04-acd8-a8d6a54461c6@gmail.com> (raw)
In-Reply-To: <87porj9fez.fsf@skywalker.in.ibm.com>



On 15/06/16 15:42, Aneesh Kumar K.V wrote:
> Balbir Singh <bsingharora@gmail.com> writes:
> 
>> On 15/06/16 10:38, Balbir Singh wrote:
>>>
>>> Thanks for a review, I'll do a V2 with some changes
>>>
>>> Balbir
>>>
>>
>> Michael, please review and check if you like the #ifdef,
>> since we are crossing the 32 bit boundary, I've used a
>> conditional define to select the feature.
> 
> 
> We really don't need to make it unsigned long. Take a look at
> 
> http://mid.gmane.org/1465395958-21349-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com


The comment in the file states that


/*
 * First half is MMU families
 */

So effectively the first 16 bits are for families. Unless we decide to override
that decision. One can also debate the description of what a MMU family is :)


> 
> But I still am not sure why we need an mmu feature for selecting new hpte
> format. Why would the exiting ISA 3.0 check won't work?
> 

I thought I answered it in my previous email. The check for CPU_FTR_ARCH_300 is
too large and we don't want to use it unless advertised via ibm,pa-features.

> 
> For the pa-feature 58 byte look at
> http://mid.gmane.org/1465397003-26812-17-git-send-email-aneesh.kumar@linux.vnet.ibm.com

  reply	other threads:[~2016-06-15  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 15:57 [PATCH] New MMU feature for new hpte format in ISA3 Balbir Singh
2016-06-14 16:51 ` Aneesh Kumar K.V
2016-06-15  0:38   ` Balbir Singh
2016-06-15  5:01     ` [V2][PATCH] " Balbir Singh
2016-06-15  5:42       ` Aneesh Kumar K.V
2016-06-15  7:19         ` Balbir Singh [this message]
2016-06-14 17:32 ` [PATCH] " kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8938f698-7311-9e04-acd8-a8d6a54461c6@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.