From: wenxu <wenxu@ucloud.cn>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag
Date: Thu, 2 Jul 2020 17:17:47 +0800 [thread overview]
Message-ID: <89404b82-71b8-c94d-1e0b-11e3755da0b3@ucloud.cn> (raw)
In-Reply-To: <20200701.152116.1519098438346883237.davem@davemloft.net>
On 7/2/2020 6:21 AM, David Miller wrote:
> From: wenxu@ucloud.cn
> Date: Mon, 29 Jun 2020 17:16:17 +0800
>
>> From: wenxu <wenxu@ucloud.cn>
>>
>> The fragment packets do defrag in tcf_ct_handle_fragments
>> will clear the skb->cb which make the qdisc_skb_cb clear
>> too and set the pkt_len to 0. The bytes always 0 when dump
>> the filter. And it also update the pkt_len after all the
>> fragments finish the defrag to one packet and make the
>> following action counter correct.
>>
>> filter protocol ip pref 2 flower chain 0 handle 0x2
>> eth_type ipv4
>> dst_ip 1.1.1.1
>> ip_flags frag/firstfrag
>> skip_hw
>> not_in_hw
>> action order 1: ct zone 1 nat pipe
>> index 2 ref 1 bind 1 installed 11 sec used 11 sec
>> Action statistics:
>> Sent 0 bytes 11 pkt (dropped 0, overlimits 0 requeues 0)
>> backlog 0b 0p requeues 0
>> cookie e04106c2ac41769b278edaa9b5309960
>>
>> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
>> Signed-off-by: wenxu <wenxu@ucloud.cn>
> This is a much larger and serious problem IMHO. And this fix is
> not sufficient.
>
> Nothing can clobber the qdisc_skb_cb like this in these packet flows
> otherwise we will have serious crashes and problems. Some packet
> schedulers store pointers in the qdisc CB private area, for example.
Why store all the cb private and restore it can't total fix this?
>
> We need to somehow elide the CB clear when packets are defragmented by
> connection tracking.
you means add new function like ip_defrag_nocb for qdisc cb case?
>
next prev parent reply other threads:[~2020-07-02 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:16 [PATCH net 1/2] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag wenxu
2020-06-29 9:16 ` [PATCH net 2/2] net/sched: act_ct: add miss tcf_lastuse_update wenxu
2020-07-01 22:21 ` [PATCH net 1/2] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag David Miller
2020-07-02 9:17 ` wenxu [this message]
2020-07-02 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89404b82-71b8-c94d-1e0b-11e3755da0b3@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.