From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] doc: document NIC features
Date: Fri, 07 Jul 2017 15:53:22 +0200
Message-ID: <8948822.3HyaHf9bfD@xps>
References: <20170622190233.67933-1-ferruh.yigit@intel.com>
 <8a981e9a-2215-a2ae-cb75-5982fd714845@solarflare.com>
 <c0c639a6-996c-161b-c5db-ee5402871524@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
 John McNamara <john.mcnamara@intel.com>, dev@dpdk.org,
 Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B10F61F5
 for <dev@dpdk.org>; Fri,  7 Jul 2017 15:53:23 +0200 (CEST)
In-Reply-To: <c0c639a6-996c-161b-c5db-ee5402871524@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/07/2017 15:37, Ferruh Yigit:
> On 7/7/2017 11:55 AM, Andrew Rybchenko wrote:
> > Also some PMDs have few implementations of the datapath (like vector and 
> > usual). Ideally
> > we need common way to highlight it. May be it is OK that control path 
> > features are duplicated
> > in this case, but ideally it should be expressed somehow.
> 
> I agree different datapath implementations can be documented better, I
> just don't know how to do ...
> 
> For some drivers there are multiple vector implementations and the
> feature set for them is not clear. And as you said control features are
> duplicated in the table.
> 
> Perhaps control and datapath features can be separated.
> 
> Or as Thomas suggested sometime ago, vector and scalar version can be
> merged into one in the table and feature can be marked as supported if
> both scalar and vector has support for it. But this is not solving
> multiple vector implementation problem.

Yes it is the way to go.
The features should not be different from a datapath implementation to
another one. So they must be merged in only one column.
If a feature is not supported in every datapaths of a driver, it should
be marked as partially supported... and the developers must implement it.