All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>,
	linux-integrity@vger.kernel.org
Cc: Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v3 0/9] ima-evm-utils: Add support for signing with pkcs11 URIs
Date: Mon, 13 Sep 2021 12:53:58 -0400	[thread overview]
Message-ID: <894c3656b59bfc7b9581ba1606e4129e7af7cc96.camel@linux.ibm.com> (raw)
In-Reply-To: <20210908192343.4147739-1-stefanb@linux.vnet.ibm.com>

On Wed, 2021-09-08 at 15:23 -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>

Having a "From: " line normally occurs when the original author is
being credited with the patch, but the patch is being updated/modified
by someone else.

> 
> This series of patches adds support for signing with pkcs11 URIs so that
> pkcs11-enabled devices can also be used for file signing.
> 
> A test program is provided setting up SoftHSM for test cases to use. I added
> two test cases for testing with SoftHSM.

The correlation between the first paragraph and the second is
missing.   The second paragraph also needs to be written in the 3rd
person.  Perhaps say something like, "Extend the existing
sign_verify.test with tests for the new pkcs11 URI support.  Use the
SoftHSM, when available, as the pkcs11 device."

thanks,

Mimi


      parent reply	other threads:[~2021-09-13 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 19:23 [PATCH v3 0/9] ima-evm-utils: Add support for signing with pkcs11 URIs Stefan Berger
2021-09-08 19:23 ` [PATCH v3 1/9] evmctl: Implement support for EVMCTL_KEY_PASSWORD environment variable Stefan Berger
2021-09-08 19:23 ` [PATCH v3 2/9] evmctl: Handle failure to initialize the openssl engine Stefan Berger
2021-09-08 19:23 ` [PATCH v3 3/9] evmctl: Implement function for setting up an OpenSSL engine Stefan Berger
2021-09-13 16:54   ` Mimi Zohar
2021-09-08 19:23 ` [PATCH v3 4/9] evmctl: Define and use an ENGINE field in libimaevm_params Stefan Berger
2021-09-08 19:23 ` [PATCH v3 5/9] evmctl: use the pkcs11 engine for pkcs11: prefixed URIs Stefan Berger
2021-09-08 19:23 ` [PATCH v3 6/9] libimaevm: Add support for pkcs11 private keys for signing a v2 hash Stefan Berger
2021-09-08 19:23 ` [PATCH v3 7/9] tests: Import softhsm_setup script to enable pkcs11 test case Stefan Berger
2021-09-13 16:54   ` Mimi Zohar
2021-09-08 19:23 ` [PATCH v3 8/9] tests: Extend sign_verify test with pkcs11-specific test Stefan Berger
2021-09-13 16:55   ` Mimi Zohar
2021-09-08 19:23 ` [PATCH v3 9/9] tests: Get the packages for pkcs11 testing on the CI/CD system Stefan Berger
2021-09-13 16:55   ` Mimi Zohar
2021-09-13 16:53 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=894c3656b59bfc7b9581ba1606e4129e7af7cc96.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.