From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE6EC433E0 for ; Wed, 12 Aug 2020 16:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89C962076B for ; Wed, 12 Aug 2020 16:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbgHLQNA (ORCPT ); Wed, 12 Aug 2020 12:13:00 -0400 Received: from smtprelay0087.hostedemail.com ([216.40.44.87]:46150 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726394AbgHLQM7 (ORCPT ); Wed, 12 Aug 2020 12:12:59 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 03A5618224D6A; Wed, 12 Aug 2020 16:12:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bikes50_180d8bd26fec X-Filterd-Recvd-Size: 1729 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Wed, 12 Aug 2020 16:12:57 +0000 (UTC) Message-ID: <89523042b8d574fa49e7d5c52ec12f1f5f848773.camel@perches.com> Subject: Re: [PATCH 20/44] staging: mfd: hi6421-spmi-pmic: fix some coding style issues From: Joe Perches To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Lee Jones , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Wed, 12 Aug 2020 09:12:56 -0700 In-Reply-To: <867108ee50302f933fade56f8c25ef775ade36b3.1597247164.git.mchehab+huawei@kernel.org> References: <867108ee50302f933fade56f8c25ef775ade36b3.1597247164.git.mchehab+huawei@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-08-12 at 17:56 +0200, Mauro Carvalho Chehab wrote: > Checkpatch complains about some minor issues inside this > driver that were not addressed by the previous patch. > > Address them. [] > diff --git a/include/linux/mfd/hi6421-spmi-pmic.h b/include/linux/mfd/hi6421-spmi-pmic.h [] > @@ -38,7 +38,8 @@ struct hi6421_spmi_pmic { > unsigned int *irqs; > int irqnum; > int irqarray; > - struct hi6421_spmi_irq_mask_info irq_mask_addr; > + > + struct hi6421_spmi_irq_mask_info irq_mask_addr; > struct hi6421_spmi_irq_info irq_addr; > }; Was adding a blank line one of checkpatch complaints? I doubt it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_20, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C346AC433DF for ; Wed, 12 Aug 2020 16:13:10 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B6012076B for ; Wed, 12 Aug 2020 16:13:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B6012076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4158B88377; Wed, 12 Aug 2020 16:13:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G+Pmrd85nXCj; Wed, 12 Aug 2020 16:13:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 1E281882FC; Wed, 12 Aug 2020 16:13:09 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id C16D81BF4DD for ; Wed, 12 Aug 2020 16:13:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B5E12203D5 for ; Wed, 12 Aug 2020 16:13:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oFiWP-fM2v7P for ; Wed, 12 Aug 2020 16:13:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by silver.osuosl.org (Postfix) with ESMTPS id 5911920021 for ; Wed, 12 Aug 2020 16:13:06 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id E20C11801452D for ; Wed, 12 Aug 2020 16:13:01 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 03A5618224D6A; Wed, 12 Aug 2020 16:12:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bikes50_180d8bd26fec X-Filterd-Recvd-Size: 1729 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Wed, 12 Aug 2020 16:12:57 +0000 (UTC) Message-ID: <89523042b8d574fa49e7d5c52ec12f1f5f848773.camel@perches.com> Subject: Re: [PATCH 20/44] staging: mfd: hi6421-spmi-pmic: fix some coding style issues From: Joe Perches To: Mauro Carvalho Chehab Date: Wed, 12 Aug 2020 09:12:56 -0700 In-Reply-To: <867108ee50302f933fade56f8c25ef775ade36b3.1597247164.git.mchehab+huawei@kernel.org> References: <867108ee50302f933fade56f8c25ef775ade36b3.1597247164.git.mchehab+huawei@kernel.org> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linuxarm@huawei.com, linux-kernel@vger.kernel.org, mauro.chehab@huawei.com, Lee Jones Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, 2020-08-12 at 17:56 +0200, Mauro Carvalho Chehab wrote: > Checkpatch complains about some minor issues inside this > driver that were not addressed by the previous patch. > > Address them. [] > diff --git a/include/linux/mfd/hi6421-spmi-pmic.h b/include/linux/mfd/hi6421-spmi-pmic.h [] > @@ -38,7 +38,8 @@ struct hi6421_spmi_pmic { > unsigned int *irqs; > int irqnum; > int irqarray; > - struct hi6421_spmi_irq_mask_info irq_mask_addr; > + > + struct hi6421_spmi_irq_mask_info irq_mask_addr; > struct hi6421_spmi_irq_info irq_addr; > }; Was adding a blank line one of checkpatch complaints? I doubt it. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel